Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4969

TestKeyValueTextInputFormat test fails with Open JDK 7

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 3.0.0, 1-win, trunk-win
    • Fix Version/s: 1.2.0, 2.0.3-alpha, 0.23.7
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      RawLocalFileSystem.delete fails on Windows even when the files are not expected to be in use. It does not reproduce with Sun JDK 6.

      1. HADOOP-9176.branch-1.patch
        9 kB
        Arpit Agarwal
      2. HADOOP-9176.patch
        5 kB
        Arpit Agarwal
      3. HADOOP-9176.trunk.patch
        4 kB
        Arpit Agarwal

        Issue Links

          Activity

          Hide
          Steve Loughran added a comment -

          windows is a lot fussier about open files than unix, which can unlink a file from the path while still keeping it open. Windows server is better than windows client, for extra fun.

          Show
          Steve Loughran added a comment - windows is a lot fussier about open files than unix, which can unlink a file from the path while still keeping it open. Windows server is better than windows client, for extra fun.
          Hide
          Arpit Agarwal added a comment -

          Steve Loughran You are right and this is Windows being fussier about closing in-use files. Happily this instance turns out to be a test bug. An input stream was not closed on exit.

          Attached a fix and removed the workaround I put in place earlier with MAPREDUCE-4099.

          Show
          Arpit Agarwal added a comment - Steve Loughran You are right and this is Windows being fussier about closing in-use files. Happily this instance turns out to be a test bug. An input stream was not closed on exit. Attached a fix and removed the workaround I put in place earlier with MAPREDUCE-4099 .
          Hide
          Steve Loughran added a comment -

          @Arpit: I'm always right.

          Show
          Steve Loughran added a comment - @Arpit: I'm always right.
          Hide
          Suresh Srinivas added a comment -

          Is this not relevant to trunk?

          Show
          Suresh Srinivas added a comment - Is this not relevant to trunk?
          Hide
          Arpit Agarwal added a comment -

          Thanks Suresh, yes it is.

          Attached updated patches for branch-1 and trunk.

          Show
          Arpit Agarwal added a comment - Thanks Suresh, yes it is. Attached updated patches for branch-1 and trunk.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12567287/HADOOP-9176.trunk.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2121//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2121//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12567287/HADOOP-9176.trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2121//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2121//console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          +1 for the trunk patch.

          Show
          Suresh Srinivas added a comment - +1 for the trunk patch.
          Hide
          Suresh Srinivas added a comment -

          +1 for the branch-1 patch as well.

          Show
          Suresh Srinivas added a comment - +1 for the branch-1 patch as well.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3304 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3304/)
          MAPREDUCE-4969. TestKeyValueTextInputFormat test fails with Open JDK 7. Contributed by Arpit Agarwal. (Revision 1441069)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441069
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestKeyValueTextInputFormat.java
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3304 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3304/ ) MAPREDUCE-4969 . TestKeyValueTextInputFormat test fails with Open JDK 7. Contributed by Arpit Agarwal. (Revision 1441069) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441069 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestKeyValueTextInputFormat.java
          Hide
          Suresh Srinivas added a comment -

          I committed this patch to trunk, branch-2, branch-1 and branch-1-win. Phew...

          Thank you Arpit!

          Show
          Suresh Srinivas added a comment - I committed this patch to trunk, branch-2, branch-1 and branch-1-win. Phew... Thank you Arpit!
          Hide
          Arpit Agarwal added a comment -

          Thanks, Suresh and thanks for fixing the JIRA fields.

          Show
          Arpit Agarwal added a comment - Thanks, Suresh and thanks for fixing the JIRA fields.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12567287/HADOOP-9176.trunk.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3294//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3294//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12567287/HADOOP-9176.trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3294//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3294//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #114 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/114/)
          MAPREDUCE-4969. TestKeyValueTextInputFormat test fails with Open JDK 7. Contributed by Arpit Agarwal. (Revision 1441069)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441069
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestKeyValueTextInputFormat.java
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #114 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/114/ ) MAPREDUCE-4969 . TestKeyValueTextInputFormat test fails with Open JDK 7. Contributed by Arpit Agarwal. (Revision 1441069) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441069 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestKeyValueTextInputFormat.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1303 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1303/)
          MAPREDUCE-4969. TestKeyValueTextInputFormat test fails with Open JDK 7. Contributed by Arpit Agarwal. (Revision 1441069)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441069
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestKeyValueTextInputFormat.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1303 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1303/ ) MAPREDUCE-4969 . TestKeyValueTextInputFormat test fails with Open JDK 7. Contributed by Arpit Agarwal. (Revision 1441069) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441069 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestKeyValueTextInputFormat.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1331 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1331/)
          MAPREDUCE-4969. TestKeyValueTextInputFormat test fails with Open JDK 7. Contributed by Arpit Agarwal. (Revision 1441069)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441069
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestKeyValueTextInputFormat.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1331 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1331/ ) MAPREDUCE-4969 . TestKeyValueTextInputFormat test fails with Open JDK 7. Contributed by Arpit Agarwal. (Revision 1441069) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441069 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestKeyValueTextInputFormat.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #513 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/513/)
          MAPREDUCE-4969. TestKeyValueTextInputFormat test fails with Open JDK 7. (Arpit Agarwal via tgraves) (Revision 1441585)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441585
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestKeyValueTextInputFormat.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #513 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/513/ ) MAPREDUCE-4969 . TestKeyValueTextInputFormat test fails with Open JDK 7. (Arpit Agarwal via tgraves) (Revision 1441585) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441585 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestKeyValueTextInputFormat.java

            People

            • Assignee:
              Arpit Agarwal
              Reporter:
              Arpit Agarwal
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development