Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4095

TestJobInProgress#testLocality uses a bogus topology

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0, 2.0.0-alpha
    • Fix Version/s: 0.24.0, 1.1.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The following in TestJobInProgress#testLocality:

          Node r2n4 = new NodeBase("/default/rack2/s1/node4");
          nt.add(r2n4);
      

      violates the check introduced by HADOOP-8159:

      Testcase: testLocality took 0.005 sec
              Caused an ERROR
      Invalid network topology. You cannot have a rack and a non-rack node at the same level of the network topology.
      org.apache.hadoop.net.NetworkTopology$InvalidTopologyException: Invalid network topology. You cannot have a rack and a non-rack node at the same level of the network topology.
              at org.apache.hadoop.net.NetworkTopology.add(NetworkTopology.java:349)
              at org.apache.hadoop.mapred.TestJobInProgress.testLocality(TestJobInProgress.java:232)
      
      1. MAPREDUCE-4095-b1.001.patch
        1 kB
        Colin Patrick McCabe
      2. MAPREDUCE-4095.001.patch
        1 kB
        Colin Patrick McCabe

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          This test explicitly creates a topology with nodes on two different levels:

              Node r2n3 = new NodeBase("/default/rack2/node3");
              nt.add(r2n3);
          
              Node r2n4 = new NodeBase("/default/rack2/s1/node4");
          

          which is bogus. Calling toString on this topology would fail even before HADOOP-8159.

          We double checked the original topology spec in HADOOP-692 (https://issues.apache.org/jira/secure/attachment/12345251/Rack_aware_HDFS_proposal.pdf) which does not support imbalanced topology. Let's fixup the test to use a valid topolgy.

          Show
          Eli Collins added a comment - This test explicitly creates a topology with nodes on two different levels: Node r2n3 = new NodeBase( "/ default /rack2/node3" ); nt.add(r2n3); Node r2n4 = new NodeBase( "/ default /rack2/s1/node4" ); which is bogus. Calling toString on this topology would fail even before HADOOP-8159 . We double checked the original topology spec in HADOOP-692 ( https://issues.apache.org/jira/secure/attachment/12345251/Rack_aware_HDFS_proposal.pdf ) which does not support imbalanced topology. Let's fixup the test to use a valid topolgy.
          Hide
          Colin Patrick McCabe added a comment -
          • TestJobInProgress: don't create imbalanced topology (branch-1 version)
          Show
          Colin Patrick McCabe added a comment - TestJobInProgress: don't create imbalanced topology (branch-1 version)
          Hide
          Colin Patrick McCabe added a comment -
          • TestJobInProgress: don't create imbalanced topology (trunk version)
          Show
          Colin Patrick McCabe added a comment - TestJobInProgress: don't create imbalanced topology (trunk version)
          Hide
          Eli Collins added a comment -

          +1 pending jenkins

          Show
          Eli Collins added a comment - +1 pending jenkins
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12520999/MAPREDUCE-4095.001.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.mapreduce.v2.TestMiniMRProxyUser
          org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution
          org.apache.hadoop.mapred.TestSpecialCharactersInOutputPath
          org.apache.hadoop.mapreduce.v2.TestRMNMInfo
          org.apache.hadoop.mapred.TestReduceFetchFromPartialMem
          org.apache.hadoop.mapred.TestLazyOutput
          org.apache.hadoop.mapreduce.TestChild
          org.apache.hadoop.mapred.TestReduceFetch
          org.apache.hadoop.mapred.TestMiniMRBringup
          org.apache.hadoop.mapred.TestMiniMRClientCluster
          org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter
          org.apache.hadoop.mapreduce.v2.TestMROldApiJobs
          org.apache.hadoop.mapreduce.v2.TestNonExistentJob
          org.apache.hadoop.mapred.TestMiniMRChildTask
          org.apache.hadoop.mapred.TestJobCounters
          org.apache.hadoop.mapreduce.v2.TestUberAM
          org.apache.hadoop.conf.TestNoDefaultsJobConf
          org.apache.hadoop.mapred.TestJobSysDirWithDFS
          org.apache.hadoop.mapreduce.v2.TestMRJobs
          org.apache.hadoop.mapred.TestClientRedirect
          org.apache.hadoop.mapred.TestJobCleanup
          org.apache.hadoop.mapreduce.TestMapReduceLazyOutput

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2128//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2128//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520999/MAPREDUCE-4095.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.mapreduce.v2.TestMiniMRProxyUser org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution org.apache.hadoop.mapred.TestSpecialCharactersInOutputPath org.apache.hadoop.mapreduce.v2.TestRMNMInfo org.apache.hadoop.mapred.TestReduceFetchFromPartialMem org.apache.hadoop.mapred.TestLazyOutput org.apache.hadoop.mapreduce.TestChild org.apache.hadoop.mapred.TestReduceFetch org.apache.hadoop.mapred.TestMiniMRBringup org.apache.hadoop.mapred.TestMiniMRClientCluster org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter org.apache.hadoop.mapreduce.v2.TestMROldApiJobs org.apache.hadoop.mapreduce.v2.TestNonExistentJob org.apache.hadoop.mapred.TestMiniMRChildTask org.apache.hadoop.mapred.TestJobCounters org.apache.hadoop.mapreduce.v2.TestUberAM org.apache.hadoop.conf.TestNoDefaultsJobConf org.apache.hadoop.mapred.TestJobSysDirWithDFS org.apache.hadoop.mapreduce.v2.TestMRJobs org.apache.hadoop.mapred.TestClientRedirect org.apache.hadoop.mapred.TestJobCleanup org.apache.hadoop.mapreduce.TestMapReduceLazyOutput +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2128//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2128//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          The test failures are the same as MAPREDUCE-4094, TestJobInProgress no longer fails.

          Show
          Eli Collins added a comment - The test failures are the same as MAPREDUCE-4094 , TestJobInProgress no longer fails.
          Hide
          Eli Collins added a comment -

          I've committed this to trunk and branch-1. I didn't merge to branch-2 because this test was removed from branch-2.

          Show
          Eli Collins added a comment - I've committed this to trunk and branch-1. I didn't merge to branch-2 because this test was removed from branch-2.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1972 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1972/)
          MAPREDUCE-4095. TestJobInProgress#testLocality uses a bogus topology. Contributed by Colin Patrick McCabe (Revision 1308519)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308519
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJobInProgress.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1972 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1972/ ) MAPREDUCE-4095 . TestJobInProgress#testLocality uses a bogus topology. Contributed by Colin Patrick McCabe (Revision 1308519) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308519 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJobInProgress.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2047 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2047/)
          MAPREDUCE-4095. TestJobInProgress#testLocality uses a bogus topology. Contributed by Colin Patrick McCabe (Revision 1308519)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308519
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJobInProgress.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2047 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2047/ ) MAPREDUCE-4095 . TestJobInProgress#testLocality uses a bogus topology. Contributed by Colin Patrick McCabe (Revision 1308519) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308519 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJobInProgress.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1985 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1985/)
          MAPREDUCE-4095. TestJobInProgress#testLocality uses a bogus topology. Contributed by Colin Patrick McCabe (Revision 1308519)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308519
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJobInProgress.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1985 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1985/ ) MAPREDUCE-4095 . TestJobInProgress#testLocality uses a bogus topology. Contributed by Colin Patrick McCabe (Revision 1308519) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308519 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJobInProgress.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1004 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1004/)
          MAPREDUCE-4095. TestJobInProgress#testLocality uses a bogus topology. Contributed by Colin Patrick McCabe (Revision 1308519)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308519
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJobInProgress.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1004 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1004/ ) MAPREDUCE-4095 . TestJobInProgress#testLocality uses a bogus topology. Contributed by Colin Patrick McCabe (Revision 1308519) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308519 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJobInProgress.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1039 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1039/)
          MAPREDUCE-4095. TestJobInProgress#testLocality uses a bogus topology. Contributed by Colin Patrick McCabe (Revision 1308519)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308519
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJobInProgress.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1039 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1039/ ) MAPREDUCE-4095 . TestJobInProgress#testLocality uses a bogus topology. Contributed by Colin Patrick McCabe (Revision 1308519) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308519 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJobInProgress.java
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop-1.1.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.

            People

            • Assignee:
              Colin Patrick McCabe
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development