Hadoop Common
  1. Hadoop Common
  2. HADOOP-8159

NetworkTopology: getLeaf should check for invalid topologies

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 1.1.0, 2.0.0-alpha
        • Component/s: None
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          Currently, in NetworkTopology, getLeaf doesn't do too much validation on the InnerNode object itself. This results in us getting ClassCastException sometimes when the network topology is invalid. We should have a less confusing exception message for this case.

          1. Text File
            HADOOP-8159.005.patch
            7 kB
            Colin P. McCabe
          2. Text File
            HADOOP-8159.006.patch
            7 kB
            Colin P. McCabe
          3. Text File
            HADOOP-8159.007.patch
            4 kB
            Colin P. McCabe
          4. Text File
            HADOOP-8159.008.patch
            4 kB
            Colin P. McCabe
          5. Text File
            HADOOP-8159.009.patch
            2 kB
            Colin P. McCabe
          6. Text File
            HADOOP-8159-b1.005.patch
            6 kB
            Colin P. McCabe
          7. Text File
            HADOOP-8159-b1.007.patch
            2 kB
            Colin P. McCabe

            Issue Links

            is related to

            Bug - A problem which impairs or prevents the functions of the product. HADOOP-12173 NetworkTopology#add calls NetworkTopology#toString always

            • Major - Major loss of function.
            • Resolved
            relates to

            Test - A new unit, integration or system test. HDFS-3129 NetworkTopology: add test that getLeaf should check for invalid topologies

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Colin P. McCabe added a comment -
              • refactor getLeaf a bit
              • the exception getLeaf() throws for an invalid Node now includes the offending Node as a string, and a helpful error message.
              Show
              Colin P. McCabe added a comment - refactor getLeaf a bit the exception getLeaf() throws for an invalid Node now includes the offending Node as a string, and a helpful error message.
              Hide
              Permalink
              Eli Collins added a comment -

              Patch for trunk and test case in TestNetworkTopology?

              Show
              Eli Collins added a comment - Patch for trunk and test case in TestNetworkTopology?
              Hide
              Permalink
              Colin P. McCabe added a comment -
              • Add unit test of rejecting a bad topology with a sane error message
              Show
              Colin P. McCabe added a comment - Add unit test of rejecting a bad topology with a sane error message
              Hide
              Permalink
              Colin P. McCabe added a comment -

              rebase patch against trunk

              Show
              Colin P. McCabe added a comment - rebase patch against trunk
              Hide
              Permalink
              Colin P. McCabe added a comment -

              attach branch-1 variant

              Show
              Colin P. McCabe added a comment - attach branch-1 variant
              Hide
              Permalink
              Eli Collins added a comment -
              • Why report the entire topology as json in the message? This string is likely to be very big on a real cluster right? Probably better to make that accessible via the NN web UI (can punt to a separate change)
              • An error message like "Invalid network location for Datanode: Datanode given rack-level network location can not be at rack-level" is probably more clear than referencing class names not visible to the user
              • In testCreateInvalidTopology in the catch clause let's assert the contents of
                e.getMessage, ie that it indicates that h3 is the bad node
              • How about adding test cases for other invalid toplogies (eg 3 or 4 level deep topology, null, empty string)
              • Nit: bracket for catch InvalidTopologyException goes on the same line
              Show
              Eli Collins added a comment - Why report the entire topology as json in the message? This string is likely to be very big on a real cluster right? Probably better to make that accessible via the NN web UI (can punt to a separate change) An error message like "Invalid network location for Datanode: Datanode given rack-level network location can not be at rack-level" is probably more clear than referencing class names not visible to the user In testCreateInvalidTopology in the catch clause let's assert the contents of e.getMessage, ie that it indicates that h3 is the bad node How about adding test cases for other invalid toplogies (eg 3 or 4 level deep topology, null, empty string) Nit: bracket for catch InvalidTopologyException goes on the same line
              Hide
              Permalink
              Colin P. McCabe added a comment -

              address eli's comments

              Show
              Colin P. McCabe added a comment - address eli's comments
              Hide
              Permalink
              Eli Collins added a comment -

              The 1st, 3rd, and 4th bullets still need addressing, otherwise looks great.

              Show
              Eli Collins added a comment - The 1st, 3rd, and 4th bullets still need addressing, otherwise looks great.
              Hide
              Permalink
              Colin P. McCabe added a comment -
              • validate exception text in test
              • don't put topology text into exception-- just log it.
              • simpler, less invasive change which just checks invariants in NetworkTopology::add
              Show
              Colin P. McCabe added a comment - validate exception text in test don't put topology text into exception-- just log it. simpler, less invasive change which just checks invariants in NetworkTopology::add
              Hide
              Permalink
              Eli Collins added a comment -

              Looks great

              Two nits:

              • The invalid topo exception references "data node" but can be used for MR too. Can just say "node".
              • Let's define INVALID_LEVEL = -1 and use that (can put next to DEFAULT_HOST_LEVEL).
              Show
              Eli Collins added a comment - Looks great Two nits: The invalid topo exception references "data node" but can be used for MR too. Can just say "node". Let's define INVALID_LEVEL = -1 and use that (can put next to DEFAULT_HOST_LEVEL).
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12519127/HADOOP-8159.007.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 3 new or modified tests.

              -1 patch. The patch command could not apply the patch.

              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/746//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519127/HADOOP-8159.007.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/746//console This message is automatically generated.
              Hide
              Permalink
              Eli Collins added a comment -

              Not sure what's up with Jenkins. It claims "The patch does not appear to apply with p0 to p2" but the patch applies cleanly for me on trunk on the latest rev.

              Show
              Eli Collins added a comment - Not sure what's up with Jenkins. It claims "The patch does not appear to apply with p0 to p2" but the patch applies cleanly for me on trunk on the latest rev.
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12519127/HADOOP-8159.007.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 3 new or modified tests.

              -1 patch. The patch command could not apply the patch.

              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/747//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519127/HADOOP-8159.007.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/747//console This message is automatically generated.
              Hide
              Permalink
              Colin P. McCabe added a comment -
              • rebase
              Show
              Colin P. McCabe added a comment - rebase
              Hide
              Permalink
              Aaron T. Myers added a comment -

              Not sure what's up with Jenkins. It claims "The patch does not appear to apply with p0 to p2" but the patch applies cleanly for me on trunk on the latest rev.

              The patch is cross-project, which test-patch can't handle.

              Show
              Aaron T. Myers added a comment - Not sure what's up with Jenkins. It claims "The patch does not appear to apply with p0 to p2" but the patch applies cleanly for me on trunk on the latest rev. The patch is cross-project, which test-patch can't handle.
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12519495/HADOOP-8159.008.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 3 new or modified tests.

              -1 patch. The patch command could not apply the patch.

              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/748//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519495/HADOOP-8159.008.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/748//console This message is automatically generated.
              Hide
              Permalink
              Eli Collins added a comment -

              Ah, I missed that the test was in HDFS, Colin, mind filing an HDFS jira for the test and we'll check this one it w/o the test and then do the HDFS jira with test?

              Show
              Eli Collins added a comment - Ah, I missed that the test was in HDFS, Colin, mind filing an HDFS jira for the test and we'll check this one it w/o the test and then do the HDFS jira with test?
              Hide
              Permalink
              Colin P. McCabe added a comment -

              Filed HDFS-3129 for the test-- will split that out of this patch.

              Show
              Colin P. McCabe added a comment - Filed HDFS-3129 for the test-- will split that out of this patch.
              Hide
              Permalink
              Colin P. McCabe added a comment -

              split out HDFS parts into a separate patch

              Show
              Colin P. McCabe added a comment - split out HDFS parts into a separate patch
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12519513/HADOOP-8159.009.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
              Please justify why no new tests are needed for this patch.
              Also please list what manual steps were performed to verify this patch.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests:
              org.apache.hadoop.fs.viewfs.TestViewFsTrash

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/749//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/749//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519513/HADOOP-8159.009.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/749//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/749//console This message is automatically generated.
              Hide
              Permalink
              Eli Collins added a comment -

              The test failure is unrelated. I've committed this to trunk and merged to 23.

              Show
              Eli Collins added a comment - The test failure is unrelated. I've committed this to trunk and merged to 23.
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk-Commit #1992 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1992/)
              HADOOP-8159. NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118)

              Result = SUCCESS
              eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1992 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1992/ ) HADOOP-8159 . NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-0.23-Commit #708 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/708/)
              HADOOP-8159. svn merge -c 1304118 from trunk (Revision 1304119)

              Result = SUCCESS
              eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119
              Files :

              • /hadoop/common/branches/branch-0.23
              • /hadoop/common/branches/branch-0.23/hadoop-common-project
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
              • /hadoop/common/branches/branch-0.23/hadoop-project
              • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #708 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/708/ ) HADOOP-8159 . svn merge -c 1304118 from trunk (Revision 1304119) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
              Hide
              Permalink
              Colin P. McCabe added a comment -
              • branch-1 version
              Show
              Colin P. McCabe added a comment - branch-1 version
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Common-trunk-Commit #1918 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1918/)
              HADOOP-8159. NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118)

              Result = SUCCESS
              eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              Show
              Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1918 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1918/ ) HADOOP-8159 . NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Common-0.23-Commit #717 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/717/)
              HADOOP-8159. svn merge -c 1304118 from trunk (Revision 1304119)

              Result = SUCCESS
              eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119
              Files :

              • /hadoop/common/branches/branch-0.23
              • /hadoop/common/branches/branch-0.23/hadoop-common-project
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
              • /hadoop/common/branches/branch-0.23/hadoop-project
              • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
              Show
              Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #717 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/717/ ) HADOOP-8159 . svn merge -c 1304118 from trunk (Revision 1304119) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12519537/HADOOP-8159-b1.007.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
              Please justify why no new tests are needed for this patch.
              Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/752//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519537/HADOOP-8159-b1.007.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/752//console This message is automatically generated.
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk-Commit #1927 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1927/)
              HADOOP-8159. NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118)

              Result = ABORTED
              eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1927 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1927/ ) HADOOP-8159 . NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-0.23-Commit #725 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/725/)
              HADOOP-8159. svn merge -c 1304118 from trunk (Revision 1304119)

              Result = ABORTED
              eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119
              Files :

              • /hadoop/common/branches/branch-0.23
              • /hadoop/common/branches/branch-0.23/hadoop-common-project
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
              • /hadoop/common/branches/branch-0.23/hadoop-project
              • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #725 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/725/ ) HADOOP-8159 . svn merge -c 1304118 from trunk (Revision 1304119) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk #993 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/993/)
              HADOOP-8159. NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118)

              Result = FAILURE
              eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #993 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/993/ ) HADOOP-8159 . NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-0.23-Build #206 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/206/)
              HADOOP-8159. svn merge -c 1304118 from trunk (Revision 1304119)

              Result = SUCCESS
              eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119
              Files :

              • /hadoop/common/branches/branch-0.23
              • /hadoop/common/branches/branch-0.23/hadoop-common-project
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
              • /hadoop/common/branches/branch-0.23/hadoop-project
              • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #206 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/206/ ) HADOOP-8159 . svn merge -c 1304118 from trunk (Revision 1304119) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-0.23-Build #234 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/234/)
              HADOOP-8159. svn merge -c 1304118 from trunk (Revision 1304119)

              Result = FAILURE
              eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119
              Files :

              • /hadoop/common/branches/branch-0.23
              • /hadoop/common/branches/branch-0.23/hadoop-common-project
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
              • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
              • /hadoop/common/branches/branch-0.23/hadoop-project
              • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #234 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/234/ ) HADOOP-8159 . svn merge -c 1304118 from trunk (Revision 1304119) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk #1028 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1028/)
              HADOOP-8159. NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118)

              Result = SUCCESS
              eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1028 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1028/ ) HADOOP-8159 . NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
              Hide
              Permalink
              Eli Collins added a comment -

              I've merged this to branch-1.

              Show
              Eli Collins added a comment - I've merged this to branch-1.

                People

                • Assignee:
                  Colin P. McCabe
                  Reporter:
                  Colin P. McCabe
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development