Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: build, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895.

      Description

      Seeing this:

          [javac] /Users/vinodkv/Workspace/eclipse-workspace/apache-git/hadoop-common/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java:155: cannot find symbol
          [javac] symbol  : class ClientNamenodeWireProtocol
          [javac] location: class org.apache.hadoop.mapred.TestSubmitJob
          [javac]       RPC.getProxy(ClientNamenodeWireProtocol.class,
          [javac]                    ^
      
      1. MAPREDUCE-3818.txt
        2 kB
        Suresh Srinivas

        Issue Links

          Activity

          Hide
          Aaron T. Myers added a comment -

          Seems very likely this is due to the recent commit of HDFS-2895.

          Show
          Aaron T. Myers added a comment - Seems very likely this is due to the recent commit of HDFS-2895 .
          Hide
          Suresh Srinivas added a comment -

          DFSClient, ClientProtocol etc. is is classified as private interface. The tests should be using FileSystem interface. We should create a bug to track this.

          Vinod, can you please run a quick validation for this patch and commit it. I do not have my mapreduce env completely setup.

          Show
          Suresh Srinivas added a comment - DFSClient, ClientProtocol etc. is is classified as private interface. The tests should be using FileSystem interface. We should create a bug to track this. Vinod, can you please run a quick validation for this patch and commit it. I do not have my mapreduce env completely setup.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          +1. This looks good. I can confirm that the compilation passes with the patch and fails without.

          Jenkins won't run these tests, but just submitting in case it catches any warnings. Will commit it post that.

          Show
          Vinod Kumar Vavilapalli added a comment - +1. This looks good. I can confirm that the compilation passes with the patch and fails without. Jenkins won't run these tests, but just submitting in case it catches any warnings. Will commit it post that.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12513493/MAPREDUCE-3818.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.mapred.TestJobCounters

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1796//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1796//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513493/MAPREDUCE-3818.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.mapred.TestJobCounters +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1796//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1796//console This message is automatically generated.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          I suspect MAPREDUCE-3822 is tracking the same TestJobCounters issues.

          In any case, the patch is fixing TestSubmitJob and should not affect TestJobCounters.

          I am pushing this in.

          Show
          Vinod Kumar Vavilapalli added a comment - I suspect MAPREDUCE-3822 is tracking the same TestJobCounters issues. In any case, the patch is fixing TestSubmitJob and should not affect TestJobCounters. I am pushing this in.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Just committed this to trunk. Will see if and when 0.23 needs it.

          Thanks Suresh!

          Show
          Vinod Kumar Vavilapalli added a comment - Just committed this to trunk. Will see if and when 0.23 needs it. Thanks Suresh!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1674 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1674/)
          MAPREDUCE-3818. Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895. Contributed by Suresh Srinivas.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1674 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1674/ ) MAPREDUCE-3818 . Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895 . Contributed by Suresh Srinivas. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1747 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1747/)
          MAPREDUCE-3818. Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895. Contributed by Suresh Srinivas.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1747 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1747/ ) MAPREDUCE-3818 . Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895 . Contributed by Suresh Srinivas. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1688 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1688/)
          MAPREDUCE-3818. Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895. Contributed by Suresh Srinivas.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1688 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1688/ ) MAPREDUCE-3818 . Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895 . Contributed by Suresh Srinivas. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #949 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/949/)
          MAPREDUCE-3818. Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895. Contributed by Suresh Srinivas.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #949 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/949/ ) MAPREDUCE-3818 . Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895 . Contributed by Suresh Srinivas. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #982 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/982/)
          MAPREDUCE-3818. Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895. Contributed by Suresh Srinivas.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #982 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/982/ ) MAPREDUCE-3818 . Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895 . Contributed by Suresh Srinivas. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have merged this to 0.23.

          Show
          Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.

            People

            • Assignee:
              Suresh Srinivas
              Reporter:
              Vinod Kumar Vavilapalli
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development