Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2895

Remove Writable wire protocol related code that is no longer necessary

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: datanode, namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      With recent changes to move wire protocol to protocol buffers, the existing writable, related translators are no longer necessary.

      1. HDFS-2895.txt
        334 kB
        Suresh Srinivas

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have merged this to 0.23.

          Show
          Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #982 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/982/)
          MAPREDUCE-3818. Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895. Contributed by Suresh Srinivas.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #982 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/982/ ) MAPREDUCE-3818 . Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895 . Contributed by Suresh Srinivas. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #949 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/949/)
          MAPREDUCE-3818. Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895. Contributed by Suresh Srinivas.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #949 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/949/ ) MAPREDUCE-3818 . Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895 . Contributed by Suresh Srinivas. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1688 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1688/)
          MAPREDUCE-3818. Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895. Contributed by Suresh Srinivas.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1688 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1688/ ) MAPREDUCE-3818 . Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895 . Contributed by Suresh Srinivas. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1747 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1747/)
          MAPREDUCE-3818. Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895. Contributed by Suresh Srinivas.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1747 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1747/ ) MAPREDUCE-3818 . Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895 . Contributed by Suresh Srinivas. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1674 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1674/)
          MAPREDUCE-3818. Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895. Contributed by Suresh Srinivas.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1674 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1674/ ) MAPREDUCE-3818 . Fixed broken compilation in TestSubmitJob after the patch for HDFS-2895 . Contributed by Suresh Srinivas. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241253 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestSubmitJob.java
          Hide
          Suresh Srinivas added a comment -

          I committed the patch to trunk. Thanks for the review Sanjay.

          Show
          Suresh Srinivas added a comment - I committed the patch to trunk. Thanks for the review Sanjay.
          Hide
          Sanjay Radia added a comment -

          +1

          Show
          Sanjay Radia added a comment - +1
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12513366/HDFS-2895.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1846//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1846//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513366/HDFS-2895.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1846//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1846//console This message is automatically generated.

            People

            • Assignee:
              Suresh Srinivas
              Reporter:
              Suresh Srinivas
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development