[MAPREDUCE-3502] Review all Service.stop() operations and make sure that they work before a service is started

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.23.0, 2.0.0-alpha
• Fix Version/s: 2.1.0-beta
• Component/s: mrv2
• Target Version/s: 2.0.0-alpha
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 02/Dec/11 17:16
• Updated: 10/Mar/15 04:32
• Resolved: 24/Jun/13 15:46

Description

MAPREDUCE-3431 has shown that some of the key services's shutdown operations are not robust against being invoked before the service is started. They need to be by

1. not calling other things if the other things are null
2. not being re-entrant (i.e. make synchronized if possible),

Maybe

1. have a StopService operation that only stops a service if it is live
2. factor out the is-running test from the base service class and make it a pre-check for all the child services, so they bail out sooner rather than later. This would be the best as it would be the one guaranteed to work consistently across all instances, so only one or two would need testing

my first iteration will skip the sync though it's something to consider.

Testing: try to create each instance; call stop() straight after construction.

Issue Links

• incorporates: YARN-123 Make yarn Resource Manager services robust against shutdown
• incorporates: YARN-124 Make Yarn Node Manager services robust against shutdown
• is part of: YARN-117 Enhance YARN service model