Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3502

Review all Service.stop() operations and make sure that they work before a service is started

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 2.0.0-alpha
    • Fix Version/s: 2.1.0-beta
    • Component/s: mrv2
    • Labels:
      None

      Description

      MAPREDUCE-3431 has shown that some of the key services's shutdown operations are not robust against being invoked before the service is started. They need to be by

      1. not calling other things if the other things are null
      2. not being re-entrant (i.e. make synchronized if possible),

      Maybe

      1. have a StopService operation that only stops a service if it is live
      2. factor out the is-running test from the base service class and make it a pre-check for all the child services, so they bail out sooner rather than later. This would be the best as it would be the one guaranteed to work consistently across all instances, so only one or two would need testing

      my first iteration will skip the sync though it's something to consider.

      Testing: try to create each instance; call stop() straight after construction.

      1. MAPREDUCE-3502.patch
        45 kB
        Steve Loughran
      2. MAPREDUCE-3502.patch
        17 kB
        Steve Loughran

        Issue Links

          Activity

          Steve Loughran created issue -
          Steve Loughran made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Steve Loughran made changes -
          Link This issue blocks MAPREDUCE-3431 [ MAPREDUCE-3431 ]
          Steve Loughran made changes -
          Attachment MAPREDUCE-3502.patch [ 12505908 ]
          Steve Loughran made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Target Version/s 0.24.0, 0.23.1 [ 12317654, 12318883 ] 0.23.1, 0.24.0 [ 12318883, 12317654 ]
          Steve Loughran made changes -
          Remaining Estimate 24h [ 86400 ] 23.5h [ 84600 ]
          Time Spent 0.5h [ 1800 ]
          Worklog Id 12434 [ 12434 ]
          Steve Loughran made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Target Version/s 0.24.0, 0.23.1 [ 12317654, 12318883 ] 0.23.1, 0.24.0 [ 12318883, 12317654 ]
          Steve Loughran made changes -
          Attachment MAPREDUCE-3502.patch [ 12507037 ]
          Steve Loughran made changes -
          Remaining Estimate 23.5h [ 84600 ] 21.5h [ 77400 ]
          Time Spent 0.5h [ 1800 ] 2.5h [ 9000 ]
          Worklog Id 12534 [ 12534 ]
          Steve Loughran made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Target Version/s 0.24.0, 0.23.1 [ 12317654, 12318883 ] 0.23.1, 0.24.0 [ 12318883, 12317654 ]
          Steve Loughran made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Target Version/s 0.24.0, 0.23.1 [ 12317654, 12318883 ] 0.23.1, 0.24.0 [ 12318883, 12317654 ]
          Steve Loughran made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Steve Loughran made changes -
          Link This issue is part of MAPREDUCE-3939 [ MAPREDUCE-3939 ]
          Steve Loughran made changes -
          Link This issue blocks MAPREDUCE-3431 [ MAPREDUCE-3431 ]
          Steve Loughran made changes -
          Link This issue incorporates MAPREDUCE-4021 [ MAPREDUCE-4021 ]
          Steve Loughran made changes -
          Link This issue incorporates MAPREDUCE-4022 [ MAPREDUCE-4022 ]
          Robert Joseph Evans made changes -
          Target Version/s 0.24.0, 0.23.1 [ 12317654, 12318883 ] 2.0.0, 3.0.0 [ 12320354, 12320355 ]
          Steve Loughran made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Fix Version/s 3.0.0 [ 12320355 ]
          Fix Version/s 2.1.0-beta [ 12324032 ]
          Resolution Fixed [ 1 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Allen Wittenauer made changes -
          Fix Version/s 3.0.0 [ 12320355 ]
          Allen Wittenauer made changes -
          Affects Version/s 2.0.0-alpha [ 12320354 ]
          Affects Version/s 0.24.0 [ 12317654 ]

            People

            • Assignee:
              Steve Loughran
              Reporter:
              Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Time Spent - 2.5h Remaining Estimate - 21.5h
                21.5h
                Logged:
                Time Spent - 2.5h Remaining Estimate - 21.5h
                2.5h

                  Development