Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3502

Review all Service.stop() operations and make sure that they work before a service is started

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 2.0.0-alpha
    • Fix Version/s: 2.1.0-beta
    • Component/s: mrv2
    • Labels:
      None

      Description

      MAPREDUCE-3431 has shown that some of the key services's shutdown operations are not robust against being invoked before the service is started. They need to be by

      1. not calling other things if the other things are null
      2. not being re-entrant (i.e. make synchronized if possible),

      Maybe

      1. have a StopService operation that only stops a service if it is live
      2. factor out the is-running test from the base service class and make it a pre-check for all the child services, so they bail out sooner rather than later. This would be the best as it would be the one guaranteed to work consistently across all instances, so only one or two would need testing

      my first iteration will skip the sync though it's something to consider.

      Testing: try to create each instance; call stop() straight after construction.

        Attachments

        1. MAPREDUCE-3502.patch
          45 kB
          Steve Loughran
        2. MAPREDUCE-3502.patch
          17 kB
          Steve Loughran

          Issue Links

            Activity

              People

              • Assignee:
                stevel@apache.org Steve Loughran
                Reporter:
                stevel@apache.org Steve Loughran
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 24h
                  24h
                  Remaining:
                  Time Spent - 2.5h Remaining Estimate - 21.5h
                  21.5h
                  Logged:
                  Time Spent - 2.5h Remaining Estimate - 21.5h
                  2.5h