Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3419

Don't mark exited TT threads as dead in MiniMRCluster

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 1.1.0
        • Fix Version/s: 1.1.0
        • Component/s: tasktracker, test
        • Labels:
          None
        • Target Version/s:
        • Hadoop Flags:
          Reviewed

          Description

          MAPREDUCE-2850 flagged all TT threads that exited in the MiniMRCluster as dead, this breaks a number of the other tests that use MiniMRCluster across restart.

            Issue Links

            relates to

            Sub-task - The sub-task of the issue MAPREDUCE-2850 Add test for TaskTracker disk failure handling (MR-2413)

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              eli Eli Collins added a comment -

              The change to MiniMRCluster to clean up exited TTs threads is actually somewhat invasive so let's just revert the setting of isDead from MR-2850 and add a field that flags what TestDiskFailures would like to check, which is that the TT exited cleanly.

              Show
              eli Eli Collins added a comment - The change to MiniMRCluster to clean up exited TTs threads is actually somewhat invasive so let's just revert the setting of isDead from MR-2850 and add a field that flags what TestDiskFailures would like to check, which is that the TT exited cleanly.
              Hide
              Permalink
              ravidotg Ravi Gummadi added a comment -

              Patch looks good to me.
              +1

              Hope you ran all tests that were failing earlier.

              Show
              ravidotg Ravi Gummadi added a comment - Patch looks good to me. +1 Hope you ran all tests that were failing earlier.
              Hide
              Permalink
              eli Eli Collins added a comment -

              Thanks Ravi. Yea, this fixes the other tets. I'll re-run the whole suite on branch-20-security for sanity before committing.

              Show
              eli Eli Collins added a comment - Thanks Ravi. Yea, this fixes the other tets. I'll re-run the whole suite on branch-20-security for sanity before committing.
              Hide
              Permalink
              eli Eli Collins added a comment -

              All tests ran cleanly except for one, which is unrelated, filed HADOOP-7836 for it. I've committed this.

              Show
              eli Eli Collins added a comment - All tests ran cleanly except for one, which is unrelated, filed HADOOP-7836 for it. I've committed this.
              Hide
              Permalink
              mattf Matt Foley added a comment -

              Closed upon release of Hadoop-1.1.0.

              Show
              mattf Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.

                People

                • Assignee:
                  eli Eli Collins
                  Reporter:
                  eli Eli Collins
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development