Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-3419

Don't mark exited TT threads as dead in MiniMRCluster

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: tasktracker, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Target Version/s:

      Description

      MAPREDUCE-2850 flagged all TT threads that exited in the MiniMRCluster as dead, this breaks a number of the other tests that use MiniMRCluster across restart.

        Issue Links

          Activity

          Eli Collins created issue -
          Hide
          Eli Collins added a comment -

          The change to MiniMRCluster to clean up exited TTs threads is actually somewhat invasive so let's just revert the setting of isDead from MR-2850 and add a field that flags what TestDiskFailures would like to check, which is that the TT exited cleanly.

          Show
          Eli Collins added a comment - The change to MiniMRCluster to clean up exited TTs threads is actually somewhat invasive so let's just revert the setting of isDead from MR-2850 and add a field that flags what TestDiskFailures would like to check, which is that the TT exited cleanly.
          Eli Collins made changes -
          Field Original Value New Value
          Attachment mapreduce-2850-1.patch [ 12503962 ]
          Eli Collins made changes -
          Assignee Eli Collins [ eli ]
          Eli Collins made changes -
          Link This issue relates to MAPREDUCE-2850 [ MAPREDUCE-2850 ]
          Hide
          Ravi Gummadi added a comment -

          Patch looks good to me.
          +1

          Hope you ran all tests that were failing earlier.

          Show
          Ravi Gummadi added a comment - Patch looks good to me. +1 Hope you ran all tests that were failing earlier.
          Hide
          Eli Collins added a comment -

          Thanks Ravi. Yea, this fixes the other tets. I'll re-run the whole suite on branch-20-security for sanity before committing.

          Show
          Eli Collins added a comment - Thanks Ravi. Yea, this fixes the other tets. I'll re-run the whole suite on branch-20-security for sanity before committing.
          Eli Collins made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Eli Collins added a comment -

          All tests ran cleanly except for one, which is unrelated, filed HADOOP-7836 for it. I've committed this.

          Show
          Eli Collins added a comment - All tests ran cleanly except for one, which is unrelated, filed HADOOP-7836 for it. I've committed this.
          Eli Collins made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Matt Foley made changes -
          Fix Version/s 1.1.0 [ 12317960 ]
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop-1.1.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development