Hadoop Common
  1. Hadoop Common
  2. HADOOP-7836

TestSaslRPC#testDigestAuthMethodHostBasedToken fails with hostname localhost.localdomain

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: ipc, test
    • Labels:
      None

      Description

      TestSaslRPC#testDigestAuthMethodHostBasedToken fails on branch-1 on some hosts.

      null expected:<localhost[]> but was:<localhost[.localdomain]>
      junit.framework.ComparisonFailure: null expected:<localhost[]> but was:<localhost[.localdomain]>

      null expected:<[localhost]> but was:<[eli-thinkpad]>
      junit.framework.ComparisonFailure: null expected:<[localhost]> but was:<[eli-thinkpad]>

      1. HADOOP-7836.patch
        0.9 kB
        Daryn Sharp
      2. hadoop-7836.txt
        0.5 kB
        Eli Collins

        Activity

        Hide
        Eli Collins added a comment -

        Patch to disable this case for the time being.

        Looks like the branch-1 test for hose-based tokens wasn't forward ported to trunk so no need to update anything there.

        Show
        Eli Collins added a comment - Patch to disable this case for the time being. Looks like the branch-1 test for hose-based tokens wasn't forward ported to trunk so no need to update anything there.
        Hide
        Daryn Sharp added a comment -

        This appears to be indicative of a bug that will affect host-based tokens. I'll look into it today, but if we can't fix it quickly then I guess we can disable and file a followup jira. Do you know if this issue only occurs in 1.1, or earlier 1.x releases too?

        Show
        Daryn Sharp added a comment - This appears to be indicative of a bug that will affect host-based tokens. I'll look into it today, but if we can't fix it quickly then I guess we can disable and file a followup jira. Do you know if this issue only occurs in 1.1, or earlier 1.x releases too?
        Hide
        Daryn Sharp added a comment -

        Actually, the test is flawed. It's using the address the rpc server is reporting to set the service. However, it is the client's responsibility to set the token service since the server has no way to know exactly what hostname/ip the client used.

        Eli, please see if this fixes the issue for you.

        Show
        Daryn Sharp added a comment - Actually, the test is flawed. It's using the address the rpc server is reporting to set the service. However, it is the client's responsibility to set the token service since the server has no way to know exactly what hostname/ip the client used. Eli, please see if this fixes the issue for you.
        Hide
        Eli Collins added a comment -

        +1 looks good

        Show
        Eli Collins added a comment - +1 looks good
        Hide
        Eli Collins added a comment -

        I've committed this, thanks Daryn!

        Do we need a jira for the same test forward ported to trunk?

        Show
        Eli Collins added a comment - I've committed this, thanks Daryn! Do we need a jira for the same test forward ported to trunk?
        Hide
        Daryn Sharp added a comment -

        I haven't checked but if trunk is indeed missing these tests – and it's not that they moved? – then yes we need to port to trunk.

        Show
        Daryn Sharp added a comment - I haven't checked but if trunk is indeed missing these tests – and it's not that they moved? – then yes we need to port to trunk.
        Hide
        Eli Collins added a comment -

        I looked at the trunk test and the forward port didn't add any new tests to this class, couldn't tell if that was on purpose (ie they're covered elsewhere).

        Show
        Eli Collins added a comment - I looked at the trunk test and the forward port didn't add any new tests to this class, couldn't tell if that was on purpose (ie they're covered elsewhere).
        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.

          People

          • Assignee:
            Daryn Sharp
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development