[MAPREDUCE-2913] TestMRJobs.testFailingMapper does not assert the correct thing.

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.23.0, 2.0.0-alpha
• Fix Version/s: 0.23.0
• Component/s: mrv2, test
• Hadoop Flags: Reviewed
• Assignee: Jonathan Turner Eagles
• Reporter: Robert Joseph Evans
• Created: 30/Aug/11 14:12
• Updated: 16/Mar/15 17:57
• Resolved: 05/Oct/11 17:10

Description

    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        events[0].getStatus().FAILED);
    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        events[1].getStatus().FAILED);

when optimized would be

    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        TaskCompletionEvent.Status.FAILED);
    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        TaskCompletionEvent.Status.FAILED);

obviously these assertions will never fail. If we remove the

.FAILED

the asserts no longer pass. This could be because MRApp mocks out the task launcher and never actually launches anything.