Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2913

TestMRJobs.testFailingMapper does not assert the correct thing.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 2.0.0-alpha
    • Fix Version/s: 0.23.0
    • Component/s: mrv2, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

          Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
              events[0].getStatus().FAILED);
          Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
              events[1].getStatus().FAILED);
      

      when optimized would be

          Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
              TaskCompletionEvent.Status.FAILED);
          Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
              TaskCompletionEvent.Status.FAILED);
      

      obviously these assertions will never fail. If we remove the

      .FAILED

      the asserts no longer pass. This could be because MRApp mocks out the task launcher and never actually launches anything.

        Attachments

          Activity

            People

            • Assignee:
              jeagles Jonathan Eagles
              Reporter:
              revans2 Robert Joseph Evans
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: