Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MAPREDUCE-2494 introduced the following findbugs warning in trunk:
      TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
      Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a static inner class?

      This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.

      1. MR-2573-mr-trunk-V1.patch
        0.5 kB
        Robert Joseph Evans

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          18h 45m 1 Robert Joseph Evans 08/Jun/11 16:41
          Patch Available Patch Available Resolved Resolved
          1d 6h 5m 1 Todd Lipcon 09/Jun/11 22:46
          Resolved Resolved Closed Closed
          158d 2h 3m 1 Arun C Murthy 15/Nov/11 00:50
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/ )
          Hide
          Robert Joseph Evans added a comment -

          Todd, thanks for catching this and committing it.

          Show
          Robert Joseph Evans added a comment - Todd, thanks for catching this and committing it.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #720 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/720/)
          MAPREDUCE-2573. Fix new findbugs warning introduced by MAPREDUCE-2494. Contributed by Robert Joseph Evans.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134121
          Files :

          • /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/filecache/TrackerDistributedCacheManager.java
          • /hadoop/mapreduce/trunk/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #720 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/720/ ) MAPREDUCE-2573 . Fix new findbugs warning introduced by MAPREDUCE-2494 . Contributed by Robert Joseph Evans. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134121 Files : /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/filecache/TrackerDistributedCacheManager.java /hadoop/mapreduce/trunk/CHANGES.txt
          Todd Lipcon made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.23.0 [ 12315570 ]
          Resolution Fixed [ 1 ]
          Hide
          Todd Lipcon added a comment -

          Committed to trunk. Thanks Robert.

          Show
          Todd Lipcon added a comment - Committed to trunk. Thanks Robert.
          Hide
          Robert Joseph Evans added a comment -

          I really don't know what is happening with the contrib and core tests. I only changed a single line to make an inner class static that should be static. Also the precommit 363 build, that Jenkins is pointing us to failed, so it must not be the correct build.

          Show
          Robert Joseph Evans added a comment - I really don't know what is happening with the contrib and core tests. I only changed a single line to make an inner class static that should be static. Also the precommit 363 build, that Jenkins is pointing us to failed, so it must not be the correct build.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12481836/MR-2573-mr-trunk-V1.patch
          against trunk revision 1133226.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.cli.TestMRCLI
          org.apache.hadoop.fs.TestFileSystem

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/363//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/363//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/363//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481836/MR-2573-mr-trunk-V1.patch against trunk revision 1133226. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestMRCLI org.apache.hadoop.fs.TestFileSystem -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/363//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/363//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/363//console This message is automatically generated.
          Robert Joseph Evans made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Robert Joseph Evans made changes -
          Attachment MR-2573-mr-trunk-V1.patch [ 12481836 ]
          Hide
          Robert Joseph Evans added a comment -

          OK I was wrong after looking at the changed I did touch that part of the code with the intention of making it static, but I guess I never did it. This patch fixes that. There are no new tests for it, as it is a very simple change.

          Show
          Robert Joseph Evans added a comment - OK I was wrong after looking at the changed I did touch that part of the code with the intention of making it static, but I guess I never did it. This patch fixes that. There are no new tests for it, as it is a very simple change.
          Robert Joseph Evans made changes -
          Assignee Robert Joseph Evans [ revans2 ]
          Hide
          Robert Joseph Evans added a comment -

          I am not sure why this issue is showing up now because MAPREDUCE-2494 did not modify that part of the code, but it is correct that it should be a static inner class. The change is simple to do, I should have a patch for it very shortly.

          Show
          Robert Joseph Evans added a comment - I am not sure why this issue is showing up now because MAPREDUCE-2494 did not modify that part of the code, but it is correct that it should be a static inner class. The change is simple to do, I should have a patch for it very shortly.
          Todd Lipcon made changes -
          Field Original Value New Value
          Link This issue is broken by MAPREDUCE-2494 [ MAPREDUCE-2494 ]
          Todd Lipcon created issue -

            People

            • Assignee:
              Robert Joseph Evans
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development