Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2573

New findbugs warning after MAPREDUCE-2494

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.23.0
    • None
    • None
    • Reviewed

    Description

      MAPREDUCE-2494 introduced the following findbugs warning in trunk:
      TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
      Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a static inner class?

      This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.

      Attachments

        1. MR-2573-mr-trunk-V1.patch
          0.5 kB
          Robert Joseph Evans

        Issue Links

          is broken by

          Improvement - An improvement or enhancement to an existing feature or task. MAPREDUCE-2494 Make the distributed cache delete entires using LRU priority

          • Major - Major loss of function.
          • Closed

          Activity

            People

              revans2 Robert Joseph Evans
              tlipcon Todd Lipcon
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: