Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Adding new property for multi user list.

      1. MAPREDUCE-1896.patch
        0.6 kB
        Vinay Kumar Thota
      2. MAPREDUCE-1896.patch
        0.6 kB
        Vinay Kumar Thota
      3. MAPREDUCE-1896.patch
        0.6 kB
        Vinay Kumar Thota

        Issue Links

          Activity

          Hide
          Vinay Kumar Thota added a comment -

          Patch for trunk.

          Show
          Vinay Kumar Thota added a comment - Patch for trunk.
          Hide
          Balaji Rajagopalan added a comment -

          link this to hadoop-6839, +1

          Show
          Balaji Rajagopalan added a comment - link this to hadoop-6839, +1
          Hide
          Konstantin Boudnik added a comment -

          Am I missing something? Why this is needed?
          Besides, please don't use .txt extensions for the config files. Better drop the extension all together.

          Show
          Konstantin Boudnik added a comment - Am I missing something? Why this is needed? Besides, please don't use .txt extensions for the config files. Better drop the extension all together.
          Hide
          Vinay Kumar Thota added a comment -

          Addressed the comments and attached the new patch.

          Show
          Vinay Kumar Thota added a comment - Addressed the comments and attached the new patch.
          Hide
          Konstantin Boudnik added a comment -

          Sorry for not making this suggestion earlier: let's call the file proxyusers and then patch seems to be good to go.
          HDFS version of this is needed still.

          Show
          Konstantin Boudnik added a comment - Sorry for not making this suggestion earlier: let's call the file proxyusers and then patch seems to be good to go. HDFS version of this is needed still.
          Hide
          Vinay Kumar Thota added a comment -

          Changed the file name and attached the new patch. For HDFS, I am creating a separate jira ticktet.

          Show
          Vinay Kumar Thota added a comment - Changed the file name and attached the new patch. For HDFS, I am creating a separate jira ticktet.
          Hide
          Konstantin Boudnik added a comment -

          +1 looks good. Please run this through usual patch validation.

          Show
          Konstantin Boudnik added a comment - +1 looks good. Please run this through usual patch validation.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12448436/MAPREDUCE-1896.patch
          against trunk revision 962682.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/297/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/297/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/297/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/297/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448436/MAPREDUCE-1896.patch against trunk revision 962682. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/297/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/297/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/297/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/297/console This message is automatically generated.
          Hide
          Vinay Kumar Thota added a comment -

          I could see two failures and they are unrelated to this patch. I don't think so the patch could raise these failures because the scope is just adds the new property in a xml file.

          Show
          Vinay Kumar Thota added a comment - I could see two failures and they are unrelated to this patch. I don't think so the patch could raise these failures because the scope is just adds the new property in a xml file.
          Hide
          Konstantin Boudnik added a comment -

          I have just committed this. Thanks Vinay

          Show
          Konstantin Boudnik added a comment - I have just committed this. Thanks Vinay
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )

            People

            • Assignee:
              Vinay Kumar Thota
              Reporter:
              Vinay Kumar Thota
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development