Hadoop Common
  1. Hadoop Common
  2. HADOOP-6839

[Herriot] Implement a functionality for getting the user list for creating proxy users.

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Develop a new method for getting the user list.

      Method signature is
      public ArrayList<String> getHadoopMultiUsersList() throws IOException;
      Add new attribute in system-test.xml file for getting userlist path.

      For submitting the jobs as different user a proxy user id is needed. So,get the available users from a userlist and then pass the user as proxy instead of hardcoding user id in a test.

      1. HADOOP-6839.patch
        2 kB
        Vinay Kumar Thota
      2. HADOOP-6839.patch
        2 kB
        Vinay Kumar Thota
      3. HADOOP-6839.patch
        2 kB
        Vinay Kumar Thota
      4. 6839-ydist-security.patch
        3 kB
        Vinay Kumar Thota
      5. 6839-ydist-security.patch
        3 kB
        Vinay Kumar Thota
      6. 6839-ydist-security.patch
        3 kB
        Vinay Kumar Thota

        Issue Links

          Activity

          Vinay Kumar Thota created issue -
          Hide
          Vinay Kumar Thota added a comment -

          Patch for yahoo dist security branch.

          Show
          Vinay Kumar Thota added a comment - Patch for yahoo dist security branch.
          Vinay Kumar Thota made changes -
          Field Original Value New Value
          Attachment 6839-ydist-security.patch [ 12448038 ]
          Hide
          Vinay Kumar Thota added a comment -

          Patch for trunk.

          Show
          Vinay Kumar Thota added a comment - Patch for trunk.
          Vinay Kumar Thota made changes -
          Attachment HADOOP-6839.patch [ 12448039 ]
          Vinay Kumar Thota made changes -
          Link This issue depends on MAPREDUCE-1774 [ MAPREDUCE-1774 ]
          Hide
          Balaji Rajagopalan added a comment -

          test.system.hdrc.multi-user.list.path

          changes to system-test.xml is with other JIRA call out the dependency.

          Show
          Balaji Rajagopalan added a comment - test.system.hdrc.multi-user.list.path changes to system-test.xml is with other JIRA call out the dependency.
          Vinay Kumar Thota made changes -
          Link This issue requires MAPREDUCE-1896 [ MAPREDUCE-1896 ]
          Hide
          Konstantin Boudnik added a comment -

          As I have asked on another JIRA I perhaps missing a point of having this functionality in place. I'd appreciate a better info on this.
          Also, similar to MAPREDUCE-1896 HDFS' system-test-hdfs.xml needs to be changed if this feature is going to be committed.

          Show
          Konstantin Boudnik added a comment - As I have asked on another JIRA I perhaps missing a point of having this functionality in place. I'd appreciate a better info on this. Also, similar to MAPREDUCE-1896 HDFS' system-test-hdfs.xml needs to be changed if this feature is going to be committed.
          Vinay Kumar Thota made changes -
          Description Develop a new method for getting the user list.

          Method signature is
          public ArrayList<String> getHadoopMultiUsersList() throws IOException;
          Add new attribute in system-test.xml file for getting userlist path.
          Develop a new method for getting the user list.

          Method signature is
          public ArrayList<String> getHadoopMultiUsersList() throws IOException;
          Add new attribute in system-test.xml file for getting userlist path.

          For submitting the jobs as different user, we need a porxy user id right. So,get the available users from userlist and then pass the user as proxy instead of hardcoded user id in the test.
          Konstantin Boudnik made changes -
          Description Develop a new method for getting the user list.

          Method signature is
          public ArrayList<String> getHadoopMultiUsersList() throws IOException;
          Add new attribute in system-test.xml file for getting userlist path.

          For submitting the jobs as different user, we need a porxy user id right. So,get the available users from userlist and then pass the user as proxy instead of hardcoded user id in the test.
          Develop a new method for getting the user list.

          Method signature is
          public ArrayList<String> getHadoopMultiUsersList() throws IOException;
          Add new attribute in system-test.xml file for getting userlist path.

          For submitting the jobs as different user a proxy user id is needed. So,get the available users from a userlist and then pass the user as proxy instead of hardcoding user id in a test.
          Konstantin Boudnik made changes -
          Link This issue is required by HDFS-1277 [ HDFS-1277 ]
          Konstantin Boudnik made changes -
          Link This issue is required by MAPREDUCE-1896 [ MAPREDUCE-1896 ]
          Konstantin Boudnik made changes -
          Link This issue requires MAPREDUCE-1896 [ MAPREDUCE-1896 ]
          Hide
          Konstantin Boudnik added a comment -

          Looks good overall. Please fix the formatting (white space are inconsistent) and make exception and error messages more meaningful. Submit the patch for verification whenever is ready.

          Show
          Konstantin Boudnik added a comment - Looks good overall. Please fix the formatting (white space are inconsistent) and make exception and error messages more meaningful. Submit the patch for verification whenever is ready.
          Hide
          Vinay Kumar Thota added a comment -

          Addressed the cos comments and attached new patches.

          Show
          Vinay Kumar Thota added a comment - Addressed the cos comments and attached new patches.
          Vinay Kumar Thota made changes -
          Attachment 6839-ydist-security.patch [ 12449273 ]
          Attachment HADOOP-6839.patch [ 12449274 ]
          Vinay Kumar Thota made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags [Reviewed]
          Affects Version/s 0.21.0 [ 12313563 ]
          Hide
          Konstantin Boudnik added a comment -
          • CONF_HADOOP_MULTI_USER_LIST has to be unquoted if you want to print the value of the constant.
            + LOG.error("Multi users list path not passed "
            + + "for CONF_HADOOP_MULTI_USER_LIST ");
          Show
          Konstantin Boudnik added a comment - CONF_HADOOP_MULTI_USER_LIST has to be unquoted if you want to print the value of the constant. + LOG.error("Multi users list path not passed " + + "for CONF_HADOOP_MULTI_USER_LIST ");
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12449274/HADOOP-6839.patch
          against trunk revision 963490.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/87/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/87/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/87/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/87/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449274/HADOOP-6839.patch against trunk revision 963490. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/87/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/87/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/87/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/87/console This message is automatically generated.
          Hide
          Vinay Kumar Thota added a comment -

          Addressed the cos comments and attached latest patch for trunk.

          Show
          Vinay Kumar Thota added a comment - Addressed the cos comments and attached latest patch for trunk.
          Vinay Kumar Thota made changes -
          Attachment HADOOP-6839.patch [ 12449449 ]
          Hide
          Vinay Kumar Thota added a comment -

          I can see there are 6 javadoc warnings and all of them are related to warning: sun.security.krb5.Config. So, I don't think the patch could raise the number of java doc warning considering the scope of the patch.

          Show
          Vinay Kumar Thota added a comment - I can see there are 6 javadoc warnings and all of them are related to warning: sun.security.krb5.Config. So, I don't think the patch could raise the number of java doc warning considering the scope of the patch.
          Hide
          Konstantin Boudnik added a comment -

          +1 patch looks good. I'll commit it by COB today if hear no objections.

          Show
          Konstantin Boudnik added a comment - +1 patch looks good. I'll commit it by COB today if hear no objections.
          Hide
          Konstantin Boudnik added a comment -

          I have just committed this. Thanks Vinay.

          Show
          Konstantin Boudnik added a comment - I have just committed this. Thanks Vinay.
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.21.0 [ 12313563 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #325 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/325/)
          HADOOP-6839. [Herriot] Implement a functionality for getting the user list for creating proxy users. Contributed by Vinay Thota.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #325 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/325/ ) HADOOP-6839 . [Herriot] Implement a functionality for getting the user list for creating proxy users. Contributed by Vinay Thota.
          Vinay Kumar Thota made changes -
          Attachment 6839-ydist-security.patch [ 12449534 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #393 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/393/)
          HADOOP-6839. [Herriot] Implement a functionality for getting the user list for creating proxy users. Contributed by Vinay Thota.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #393 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/393/ ) HADOOP-6839 . [Herriot] Implement a functionality for getting the user list for creating proxy users. Contributed by Vinay Thota.
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Konstantin Boudnik made changes -
          Link This issue is related to HADOOP-6944 [ HADOOP-6944 ]
          Gavin made changes -
          Link This issue depends on MAPREDUCE-1774 [ MAPREDUCE-1774 ]
          Gavin made changes -
          Link This issue depends upon MAPREDUCE-1774 [ MAPREDUCE-1774 ]

            People

            • Assignee:
              Vinay Kumar Thota
              Reporter:
              Vinay Kumar Thota
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development