Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1592

Generate Eclipse's .classpath file from Ivy config

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: build
    • Labels:
    • Release Note:
      Added support to auto-generate the Eclipse .classpath file from ivy.

      Description

      MapReduce companion issue for HADOOP-6407.

      1. MAPREDUCE-1592.patch
        10 kB
        Paolo Castagna
      2. MAPREDUCE-1592.patch
        13 kB
        Tom White
      3. MAPREDUCE-1592.patch
        13 kB
        Tom White
      4. MAPREDUCE-1592.patch
        13 kB
        Nigel Daley

        Issue Links

          Activity

          Hide
          Paolo Castagna added a comment -

          From duplicate issue MAPREDUCE-1619:

          We should include source paths for the Java source (including tests) for each contrib module.

          I followed the approach in HADOOP-6407 which does not include contrib modules.
          There are 15 contrib modules and I do not see an easy way to automate this.

          I don't think the copy task is needed in the new eclipse target.

          I left it there to copy .launch scripts, but it can be removed if you think it's better.

          Show
          Paolo Castagna added a comment - From duplicate issue MAPREDUCE-1619 : We should include source paths for the Java source (including tests) for each contrib module. I followed the approach in HADOOP-6407 which does not include contrib modules. There are 15 contrib modules and I do not see an easy way to automate this. I don't think the copy task is needed in the new eclipse target. I left it there to copy .launch scripts, but it can be removed if you think it's better.
          Hide
          Paolo Castagna added a comment -

          The new patch does not copy .launch scripts, but it does not address the problem with the 15 contrib modules.

          Show
          Paolo Castagna added a comment - The new patch does not copy .launch scripts, but it does not address the problem with the 15 contrib modules.
          Hide
          Tom White added a comment -

          I was thinking we list the contrib source paths explicitly in build.xml. Does that sound reasonable?

          Show
          Tom White added a comment - I was thinking we list the contrib source paths explicitly in build.xml. Does that sound reasonable?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12439755/MAPREDUCE-1592.patch
          against trunk revision 927995.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 13 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439755/MAPREDUCE-1592.patch against trunk revision 927995. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 13 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/62/console This message is automatically generated.
          Hide
          Tom White added a comment -

          Here's a patch that includes the contrib source paths (except the ones for the eclipse-plugin and index, since these didn't compile - I didn't look into why at this point). It also keeps the code to install the launch files that are in .eclipse.templates/.launches.

          Show
          Tom White added a comment - Here's a patch that includes the contrib source paths (except the ones for the eclipse-plugin and index, since these didn't compile - I didn't look into why at this point). It also keeps the code to install the launch files that are in .eclipse.templates/.launches.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12443036/MAPREDUCE-1592.patch
          against trunk revision 938779.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 33 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443036/MAPREDUCE-1592.patch against trunk revision 938779. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/150/console This message is automatically generated.
          Hide
          bc Wong added a comment -

          +1. Tried out the patch. It works, and resolves my earlier classpath errors.

          Show
          bc Wong added a comment - +1. Tried out the patch. It works, and resolves my earlier classpath errors.
          Hide
          Nigel Daley added a comment -

          Tom, are we going to go with this solution or should I submit a patch for .eclipse.templates/.classpath? It's woefully out of date.

          Show
          Nigel Daley added a comment - Tom, are we going to go with this solution or should I submit a patch for .eclipse.templates/.classpath? It's woefully out of date.
          Hide
          Tom White added a comment -

          Sorry that this patch got forgotten. I just tried it out and it still works for me (ant clean compile eclipse). The compile step is needed to generate the Avro classes in org.apache.hadoop.mapreduce.jobhistory. So I think we should commit this, probably to the 0.21 branch and trunk. Similarly for HDFS-1035.

          Show
          Tom White added a comment - Sorry that this patch got forgotten. I just tried it out and it still works for me ( ant clean compile eclipse ). The compile step is needed to generate the Avro classes in org.apache.hadoop.mapreduce.jobhistory. So I think we should commit this, probably to the 0.21 branch and trunk. Similarly for HDFS-1035 .
          Hide
          Nigel Daley added a comment -

          Made a small change to the patch to use $

          {build.dir}

          variable when defining build.dir.eclipse

          Show
          Nigel Daley added a comment - Made a small change to the patch to use $ {build.dir} variable when defining build.dir.eclipse
          Hide
          Tom White added a comment -

          +1 works for me

          Show
          Tom White added a comment - +1 works for me
          Hide
          Nigel Daley added a comment -

          I just committed this. Thanks Tom. (sorry, got the contributor name wrong in my commit msg)

          Show
          Nigel Daley added a comment - I just committed this. Thanks Tom. (sorry, got the contributor name wrong in my commit msg)
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #533 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/533/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #533 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/533/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )

            People

            • Assignee:
              Tom White
              Reporter:
              Tom White
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development