Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1546

Jobtracker JSP pages should automatically redirect to the corresponding history page if not in memory

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MAPREDUCE-1185 redirects jobdetails.jsp to it's corresponding history page.

      For convenience, we should also redirect the following JSP pages to the corresponding history pages:
      jobconf.jsp
      jobtasks.jsp
      taskdetails.jsp
      taskstats.jsp

      1. MAPREDUCE-1546-v3.txt
        7 kB
        Scott Chen
      2. MAPREDUCE-1546-v3.2.txt
        8 kB
        Scott Chen
      3. MAPREDUCE-1546-v3.1.txt
        8 kB
        Scott Chen
      4. MAPREDUCE-1546-v2.txt
        4 kB
        Scott Chen
      5. MAPREDUCE-1546.txt
        1 kB
        Scott Chen

        Activity

        Hide
        Scott Chen added a comment -

        Thanks for the help, Sharad and Amareshwari.

        Show
        Scott Chen added a comment - Thanks for the help, Sharad and Amareshwari.
        Hide
        Sharad Agarwal added a comment -

        I just committed this. Thanks Scott.

        Show
        Sharad Agarwal added a comment - I just committed this. Thanks Scott.
        Hide
        Amareshwari Sriramadasu added a comment -

        Patch looks fine to me.

        Show
        Amareshwari Sriramadasu added a comment - Patch looks fine to me.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12443671/MAPREDUCE-1546-v3.2.txt
        against trunk revision 940740.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/164/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/164/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/164/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/164/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443671/MAPREDUCE-1546-v3.2.txt against trunk revision 940740. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/164/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/164/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/164/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/164/console This message is automatically generated.
        Hide
        Scott Chen added a comment -

        Suppress the findbugs warning.

        Show
        Scott Chen added a comment - Suppress the findbugs warning.
        Hide
        Scott Chen added a comment -

        You are right. I think HTTP response splitting is not an issue here but the findbugs still report warnings.
        I will suppress it and update the patch.

        Show
        Scott Chen added a comment - You are right. I think HTTP response splitting is not an issue here but the findbugs still report warnings. I will suppress it and update the patch.
        Hide
        Amareshwari Sriramadasu added a comment -

        Looks like your change did not fix the findbugs. But i think you need to suppress the findbugs warning : HRS_REQUEST_PARAMETER_TO_HTTP_HEADER. It is suppressed for jobdetails.jsp in MAPREDUCE-1185.

        Show
        Amareshwari Sriramadasu added a comment - Looks like your change did not fix the findbugs. But i think you need to suppress the findbugs warning : HRS_REQUEST_PARAMETER_TO_HTTP_HEADER. It is suppressed for jobdetails.jsp in MAPREDUCE-1185 .
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12443535/MAPREDUCE-1546-v3.1.txt
        against trunk revision 940364.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/162/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/162/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/162/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/162/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443535/MAPREDUCE-1546-v3.1.txt against trunk revision 940364. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/162/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/162/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/162/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/162/console This message is automatically generated.
        Hide
        Scott Chen added a comment -

        Fixed the HTTP response splitting problem found by findbugs.

        Show
        Scott Chen added a comment - Fixed the HTTP response splitting problem found by findbugs.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12443318/MAPREDUCE-1546-v3.txt
        against trunk revision 939505.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/160/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/160/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/160/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/160/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443318/MAPREDUCE-1546-v3.txt against trunk revision 939505. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/160/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/160/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/160/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/160/console This message is automatically generated.
        Hide
        Scott Chen added a comment -

        Added unit tests to verify the redirection of the JSP pages actually work based on Amareshwari and Ravi's comments.

        Show
        Scott Chen added a comment - Added unit tests to verify the redirection of the JSP pages actually work based on Amareshwari and Ravi's comments.
        Hide
        Scott Chen added a comment -

        Thanks for the information, Ravi. I will work on TestJobRetire and also take a look at TestWebUIAuthorization.

        Show
        Scott Chen added a comment - Thanks for the information, Ravi. I will work on TestJobRetire and also take a look at TestWebUIAuthorization.
        Hide
        Ravi Gummadi added a comment -

        TestWebUIAuthorization does have tests for almost all jsps, but mostly concentrates on if authorization works as expected or not. Anyway, TestJobRetire seems to be good enough starting point for the tests for this JIRA.

        Show
        Ravi Gummadi added a comment - TestWebUIAuthorization does have tests for almost all jsps, but mostly concentrates on if authorization works as expected or not. Anyway, TestJobRetire seems to be good enough starting point for the tests for this JIRA.
        Hide
        Scott Chen added a comment -

        Can you add tests for redirection of urls? You can look at TestJobRetire, it already has test for jobdetails.jsp

        I see. I thought there is no way to test JSP. I will look at TestJobRetire and add some tests there.

        Show
        Scott Chen added a comment - Can you add tests for redirection of urls? You can look at TestJobRetire, it already has test for jobdetails.jsp I see. I thought there is no way to test JSP. I will look at TestJobRetire and add some tests there.
        Hide
        Amareshwari Sriramadasu added a comment -

        Canceling the patch until testcases are added.

        Show
        Amareshwari Sriramadasu added a comment - Canceling the patch until testcases are added.
        Hide
        Amareshwari Sriramadasu added a comment -

        Changes look fine. I hope you have tested the patch for re-directions.
        Can you add tests for redirection of urls? You can look at TestJobRetire, it already has test for jobdetails.jsp

        Show
        Amareshwari Sriramadasu added a comment - Changes look fine. I hope you have tested the patch for re-directions. Can you add tests for redirection of urls? You can look at TestJobRetire, it already has test for jobdetails.jsp
        Hide
        Scott Chen added a comment -

        The attached patch redirects these four pages to their corresponding history pages.

        Note that there are no unit tests for JSP pages.

        Show
        Scott Chen added a comment - The attached patch redirects these four pages to their corresponding history pages. Note that there are no unit tests for JSP pages.
        Hide
        Scott Chen added a comment -

        In the attached file, we redirect taskdetails.jsp to the corresponding taskdetailshistory.jsp.

        Most of the work is already done by MAPREDUCE-1185.
        In MAPREDUCE-1185, a LinkedHashMap is used to store history file names.
        We use that to find the history file name and redirect tot he correct page.

        Show
        Scott Chen added a comment - In the attached file, we redirect taskdetails.jsp to the corresponding taskdetailshistory.jsp. Most of the work is already done by MAPREDUCE-1185 . In MAPREDUCE-1185 , a LinkedHashMap is used to store history file names. We use that to find the history file name and redirect tot he correct page.
        Hide
        Scott Chen added a comment -

        That is awesome, Amareshwari. That's exactly what I need.
        I will change this one for taskdetails.jsp only.

        Show
        Scott Chen added a comment - That is awesome, Amareshwari. That's exactly what I need. I will change this one for taskdetails.jsp only.
        Hide
        Amareshwari Sriramadasu added a comment -

        jobdetails.jsp will be automatically re-directed to jobdetailshistory.jsp after MAPREDUCE-1185.

        Show
        Amareshwari Sriramadasu added a comment - jobdetails.jsp will be automatically re-directed to jobdetailshistory.jsp after MAPREDUCE-1185 .

          People

          • Assignee:
            Scott Chen
            Reporter:
            Scott Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development