Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1185

URL to JT webconsole for running job and job history should be the same

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: jobtracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      If the running job is retired, then Job url is redirected to the history page. To construct the history url, JobTracker maintains the mapping of job id to history file names. The entries from mapping is purged for jobs older than mapreduce.jobtracker.jobhistory.maxage configured value.
      Show
      If the running job is retired, then Job url is redirected to the history page. To construct the history url, JobTracker maintains the mapping of job id to history file names. The entries from mapping is purged for jobs older than mapreduce.jobtracker.jobhistory.maxage configured value.

      Description

      The tracking url for running jobs and the jobs which are retired is different. This creates problem for clients which caches the job running url because soon it becomes invalid when job is retired.

      1. 1185_v1.patch
        6 kB
        Sharad Agarwal
      2. 1185_v2.patch
        6 kB
        Sharad Agarwal
      3. 1185_v3.patch
        6 kB
        Sharad Agarwal
      4. 1185_v4.patch
        6 kB
        Sharad Agarwal
      5. 1185_v5.patch
        8 kB
        Sharad Agarwal
      6. patch-1185-ydist.txt
        8 kB
        Amareshwari Sriramadasu
      7. patch-1185-1-ydist.txt
        9 kB
        Amareshwari Sriramadasu
      8. patch-1185-2-ydist.txt
        9 kB
        Amareshwari Sriramadasu
      9. 1185_v6.patch
        7 kB
        Amareshwari Sriramadasu
      10. patch-1185-3-ydist.txt
        8 kB
        Amareshwari Sriramadasu
      11. 1185_v7.patch
        7 kB
        Amareshwari Sriramadasu

        Activity

        Sharad Agarwal created issue -
        Hide
        Sharad Agarwal added a comment -

        Simple fix would be: JT to redirect to history url in case job is already retired.

        Show
        Sharad Agarwal added a comment - Simple fix would be: JT to redirect to history url in case job is already retired.
        Sharad Agarwal made changes -
        Field Original Value New Value
        Attachment 1185_v1.patch [ 12424566 ]
        Sharad Agarwal made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12424566/1185_v1.patch
        against trunk revision 834284.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/236/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/236/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/236/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/236/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424566/1185_v1.patch against trunk revision 834284. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/236/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/236/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/236/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/236/console This message is automatically generated.
        Sharad Agarwal made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Sharad Agarwal made changes -
        Attachment 1185_v2.patch [ 12424596 ]
        Sharad Agarwal made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12424596/1185_v2.patch
        against trunk revision 834284.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/134/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/134/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/134/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/134/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424596/1185_v2.patch against trunk revision 834284. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/134/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/134/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/134/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/134/console This message is automatically generated.
        Hide
        Amareshwari Sriramadasu added a comment -

        In JSPUtil, instead of creating the url from jobid and user, we can get it from status.getTrackingUrl()

        Show
        Amareshwari Sriramadasu added a comment - In JSPUtil, instead of creating the url from jobid and user, we can get it from status.getTrackingUrl()
        Sharad Agarwal made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Sharad Agarwal added a comment -

        In JSPUtil, instead of creating the url from jobid and user, we can get it from status.getTrackingUrl()

        Thanks Amareshwari. Attaching the new patch with this fix.

        Show
        Sharad Agarwal added a comment - In JSPUtil, instead of creating the url from jobid and user, we can get it from status.getTrackingUrl() Thanks Amareshwari. Attaching the new patch with this fix.
        Sharad Agarwal made changes -
        Attachment 1185_v3.patch [ 12424814 ]
        Hide
        Jothi Padmanabhan added a comment -

        In the test case, does it also make sense to add one more check – do not set conn.setInstanceFollowRedirects(false) and then ensure that conn.connect() is successful. If not the contents, we would at least verify that the redirection works as expected, no?

        Show
        Jothi Padmanabhan added a comment - In the test case, does it also make sense to add one more check – do not set conn.setInstanceFollowRedirects(false) and then ensure that conn.connect() is successful. If not the contents, we would at least verify that the redirection works as expected, no?
        Hide
        Sharad Agarwal added a comment -

        Added the test case to test redirected url validating response code of 200.

        Show
        Sharad Agarwal added a comment - Added the test case to test redirected url validating response code of 200.
        Sharad Agarwal made changes -
        Attachment 1185_v4.patch [ 12425183 ]
        Sharad Agarwal made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12425183/1185_v4.patch
        against trunk revision 881095.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/247/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/247/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/247/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/247/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12425183/1185_v4.patch against trunk revision 881095. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/247/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/247/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/247/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/247/console This message is automatically generated.
        Hide
        Milind Bhandarkar added a comment -

        I think the approach of including the job history file name in the URL since the beginning will cause more headaches, since the job history file name includes some things that are unparseable by humans. It may be easier and more human-friendly to translate the job id internally to the history file name, and return the content of job history. This will require a map between job ids and the file name to be kept inside the jobtracker, but that should not be too big, since the entries can be removed when job history is purged periodically. Makes sense ?

        In any case, Hadoop 0.21 will have a different human-friendly file naming scheme, when this can go away.

        Show
        Milind Bhandarkar added a comment - I think the approach of including the job history file name in the URL since the beginning will cause more headaches, since the job history file name includes some things that are unparseable by humans. It may be easier and more human-friendly to translate the job id internally to the history file name, and return the content of job history. This will require a map between job ids and the file name to be kept inside the jobtracker, but that should not be too big, since the entries can be removed when job history is purged periodically. Makes sense ? In any case, Hadoop 0.21 will have a different human-friendly file naming scheme, when this can go away.
        Hide
        Sharad Agarwal added a comment -

        I think the approach of including the job history file name in the URL since the beginning will cause more headaches, since the job history file name includes some things that are unparseable by humans. This will require a map between job ids and the file name to be kept inside the jobtracker,

        Since URL is given by the JobClient API, the thinking was that users don't really need to bother about the contents and map based thing will not survive JT restarts. The long term solution being done by MAPREDUCE-323. Saying that it looks like (also based on off line discussion with Arun) that map based solution is acceptable in medium term until MAPREDUCE-323 is done.

        but that should not be too big, since the entries can be removed when job history is purged periodically. Makes sense ?

        Yes, that should work. The only problem we also need to keep in mind that when history cleaner thread runs, it does a listing of the files in history folder and deletes the ones which are older than 30 days (default). But in the meanwhile operations could have manually purged the files. So those entries won't be purged from the map. To address this timestamp can be maintained along with the history file name.

        Show
        Sharad Agarwal added a comment - I think the approach of including the job history file name in the URL since the beginning will cause more headaches, since the job history file name includes some things that are unparseable by humans. This will require a map between job ids and the file name to be kept inside the jobtracker, Since URL is given by the JobClient API, the thinking was that users don't really need to bother about the contents and map based thing will not survive JT restarts. The long term solution being done by MAPREDUCE-323 . Saying that it looks like (also based on off line discussion with Arun) that map based solution is acceptable in medium term until MAPREDUCE-323 is done. but that should not be too big, since the entries can be removed when job history is purged periodically. Makes sense ? Yes, that should work. The only problem we also need to keep in mind that when history cleaner thread runs, it does a listing of the files in history folder and deletes the ones which are older than 30 days (default). But in the meanwhile operations could have manually purged the files. So those entries won't be purged from the map. To address this timestamp can be maintained along with the history file name.
        Sharad Agarwal made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Sharad Agarwal added a comment -

        Patch for review. This maintains a map of {JobID, {historyFileName, timestamp}} in JobHistory class. The entries are purged in HistoryCleaner thread.

        Show
        Sharad Agarwal added a comment - Patch for review. This maintains a map of {JobID, {historyFileName, timestamp}} in JobHistory class. The entries are purged in HistoryCleaner thread.
        Sharad Agarwal made changes -
        Attachment 1185_v5.patch [ 12426083 ]
        Hide
        Amareshwari Sriramadasu added a comment -

        Patch for Yahoo! distribution

        Show
        Amareshwari Sriramadasu added a comment - Patch for Yahoo! distribution
        Amareshwari Sriramadasu made changes -
        Attachment patch-1185-ydist.txt [ 12426384 ]
        Amareshwari Sriramadasu made changes -
        Attachment patch-1185-ydist.txt [ 12426384 ]
        Hide
        Amareshwari Sriramadasu added a comment -

        Earlier patch had a findbugs warning. Attaching patch after suppressing it.

        Show
        Amareshwari Sriramadasu added a comment - Earlier patch had a findbugs warning. Attaching patch after suppressing it.
        Amareshwari Sriramadasu made changes -
        Attachment patch-1185-ydist.txt [ 12426388 ]
        Hide
        Amareshwari Sriramadasu added a comment -

        test-patch and ant test passed on Y!20 patch, except TestHdfsProxy.

        Show
        Amareshwari Sriramadasu added a comment - test-patch and ant test passed on Y!20 patch, except TestHdfsProxy.
        Hide
        Amareshwari Sriramadasu added a comment -

        The test for redirection was missing in earlier Y!20 patch. Added the test in attached patch.

        Show
        Amareshwari Sriramadasu added a comment - The test for redirection was missing in earlier Y!20 patch. Added the test in attached patch.
        Amareshwari Sriramadasu made changes -
        Attachment patch-1185-1-ydist.txt [ 12426499 ]
        Hide
        Jothi Padmanabhan added a comment -

        Trunk patch.
        Since you are already doing a remove of entries from the jobHistoryFileMap while iterating through it to handle the manual move scenario, I think the jobHistoryFileMap.remove() while deleting the history file is redundant and can be removed.

        Show
        Jothi Padmanabhan added a comment - Trunk patch. Since you are already doing a remove of entries from the jobHistoryFileMap while iterating through it to handle the manual move scenario, I think the jobHistoryFileMap.remove() while deleting the history file is redundant and can be removed.
        Hide
        Amareshwari Sriramadasu added a comment -

        Y!20 Patch incorporating Jothi's comment. Also fixed a bug in jobdetails.jsp

        Show
        Amareshwari Sriramadasu added a comment - Y!20 Patch incorporating Jothi's comment. Also fixed a bug in jobdetails.jsp
        Amareshwari Sriramadasu made changes -
        Attachment patch-1185-2-ydist.txt [ 12426525 ]
        Hide
        Iyappan Srinivasan added a comment -

        Testing completed with new patch. All testcases pased:
        +1 for QA.

        Scenarios tested:

        Change the mapred.job.tracker.history.completed.location to point to a local file system directory
        1) Run some jobs like sleep, randomwriter, streaming job and see if their job URI gets redirected to the done folder
        after the jobs are retired.

        2) Run multiple jobs and see if still the jobs are getting redirected properly.

        3) Do a JT restart and then type the jobid URL (not the done folder URL) of the job before the JT restart and see if
        it gives proper error.

        4) Change the mapred.job.tracker.history.completed.location to point to a dfs directory and then run steps 1,2,3 and
        see if it works properly.

        Show
        Iyappan Srinivasan added a comment - Testing completed with new patch. All testcases pased: +1 for QA. Scenarios tested: Change the mapred.job.tracker.history.completed.location to point to a local file system directory 1) Run some jobs like sleep, randomwriter, streaming job and see if their job URI gets redirected to the done folder after the jobs are retired. 2) Run multiple jobs and see if still the jobs are getting redirected properly. 3) Do a JT restart and then type the jobid URL (not the done folder URL) of the job before the JT restart and see if it gives proper error. 4) Change the mapred.job.tracker.history.completed.location to point to a dfs directory and then run steps 1,2,3 and see if it works properly.
        Amareshwari Sriramadasu made changes -
        Attachment 1185_v6.patch [ 12426531 ]
        Amareshwari Sriramadasu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Amareshwari Sriramadasu added a comment -

        Uploaded the patch for trunk with Jothi's comment incorporated.

        Show
        Amareshwari Sriramadasu added a comment - Uploaded the patch for trunk with Jothi's comment incorporated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12426531/1185_v6.patch
        against trunk revision 885530.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/157/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/157/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/157/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/157/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426531/1185_v6.patch against trunk revision 885530. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/157/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/157/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/157/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/157/console This message is automatically generated.
        Hide
        Jothi Padmanabhan added a comment -

        A couple of minor nits on v6:

        1. The comment before removing the MovedFileInfo has to be fixed
        2. The method getJobId is no longer required
        Show
        Jothi Padmanabhan added a comment - A couple of minor nits on v6: The comment before removing the MovedFileInfo has to be fixed The method getJobId is no longer required
        Amareshwari Sriramadasu made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Amareshwari Sriramadasu added a comment -

        Y!20 patch incorporating review comments.

        Show
        Amareshwari Sriramadasu added a comment - Y!20 patch incorporating review comments.
        Amareshwari Sriramadasu made changes -
        Attachment patch-1185-3-ydist.txt [ 12426630 ]
        Hide
        Amareshwari Sriramadasu added a comment -

        Patch for trunk

        Show
        Amareshwari Sriramadasu added a comment - Patch for trunk
        Amareshwari Sriramadasu made changes -
        Attachment 1185_v7.patch [ 12426631 ]
        Amareshwari Sriramadasu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Jothi Padmanabhan added a comment -

        +1, patch looks good!

        Show
        Jothi Padmanabhan added a comment - +1, patch looks good!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12426631/1185_v7.patch
        against trunk revision 886059.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/285/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/285/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/285/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/285/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426631/1185_v7.patch against trunk revision 886059. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/285/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/285/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/285/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/285/console This message is automatically generated.
        Hide
        Amareshwari Sriramadasu added a comment -

        test-patch and ant test passed on Y!20 patch.

        Show
        Amareshwari Sriramadasu added a comment - test-patch and ant test passed on Y!20 patch.
        Hide
        Arun C Murthy added a comment -

        +1

        Show
        Arun C Murthy added a comment - +1
        Hide
        Sharad Agarwal added a comment -

        I just committed this. Thanks Amareshwari.

        Show
        Sharad Agarwal added a comment - I just committed this. Thanks Amareshwari.
        Sharad Agarwal made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Release Note If the running job is retired, then Job url is redirected to the history page. To construct the history url, JobTracker maintains the mapping of job id to history file names. The entries from mapping is purged for jobs older than mapreduce.jobtracker.jobhistory.maxage configured value.
        Assignee Sharad Agarwal [ sharadag ] Amareshwari Sriramadasu [ amareshwari ]
        Fix Version/s 0.22.0 [ 12314184 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #145 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/145/)
        . Redirect running job url to history url if job is already retired. Contributed by Amareshwari Sriramadasu and Sharad Agarwal.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #145 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/145/ ) . Redirect running job url to history url if job is already retired. Contributed by Amareshwari Sriramadasu and Sharad Agarwal.
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12314045 ]
        Fix Version/s 0.22.0 [ 12314184 ]
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        10d 22h 39m 4 Amareshwari Sriramadasu 02/Dec/09 05:16
        Open Open Patch Available Patch Available
        15d 22h 45m 5 Amareshwari Sriramadasu 02/Dec/09 05:19
        Patch Available Patch Available Resolved Resolved
        5d 1h 1 Sharad Agarwal 07/Dec/09 06:19
        Resolved Resolved Closed Closed
        260d 14h 59m 1 Tom White 24/Aug/10 22:19

          People

          • Assignee:
            Amareshwari Sriramadasu
            Reporter:
            Sharad Agarwal
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development