Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.1, 0.20.2, 0.20.205.0, 0.21.0, 0.22.0
    • Fix Version/s: 0.20.2
    • Component/s: None
    • Labels:
      None
    • Environment:

      ubuntu karmic 64-bit

    • Hadoop Flags:
      Reviewed

      Description

      c++ utils doesn't compile on ubuntu karmic 64-bit. The latest patch for HADOOP-5611 needs to be applied first.

      1. MR-1251.patch
        0.6 kB
        Eli Collins
      2. HDFS-790-1.patch
        0.7 kB
        Eli Collins
      3. HDFS-790.patch
        0.7 kB
        Eli Collins

        Activity

        Hide
        Eli Collins added a comment -

        Uploaded a patch.

        Show
        Eli Collins added a comment - Uploaded a patch.
        Hide
        Eli Collins added a comment -

        The include of stdint.h in Pipes.hh should be outside the #if.

        Show
        Eli Collins added a comment - The include of stdint.h in Pipes.hh should be outside the #if.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12426449/HDFS-790-1.patch
        against trunk revision 885538.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/126/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426449/HDFS-790-1.patch against trunk revision 885538. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/126/console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Patch for trunk, against MR where pipes lives.

        Show
        Eli Collins added a comment - Patch for trunk, against MR where pipes lives.
        Hide
        Todd Lipcon added a comment -

        +1 - started a new karmic VM on ec2, verified build failure, applied MR-1251.patch, and verified a successful build.

        This should be committed to branch-20 as well. From the 0.20.1 tarball, I had to apply HADOOP-5612, HADOOP-5611, and MR-1251.patch before pipes would build (this same patch applies cleanly to that tarball). Doesn't look like any of those are in branch-20, but they all are necessary if we consider build failure to be critical.

        Show
        Todd Lipcon added a comment - +1 - started a new karmic VM on ec2, verified build failure, applied MR-1251.patch, and verified a successful build. This should be committed to branch-20 as well. From the 0.20.1 tarball, I had to apply HADOOP-5612 , HADOOP-5611 , and MR-1251.patch before pipes would build (this same patch applies cleanly to that tarball). Doesn't look like any of those are in branch-20, but they all are necessary if we consider build failure to be critical.
        Hide
        Eli Collins added a comment -

        Thanks Todd. Also tested the patch against Centos 5.4 64-bit.

        Show
        Eli Collins added a comment - Thanks Todd. Also tested the patch against Centos 5.4 64-bit.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12426461/MR-1251.patch
        against trunk revision 885530.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/281/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/281/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/281/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/281/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426461/MR-1251.patch against trunk revision 885530. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/281/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/281/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/281/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/281/console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12426461/MR-1251.patch
        against trunk revision 889496.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/318/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/318/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/318/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/318/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426461/MR-1251.patch against trunk revision 889496. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/318/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/318/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/318/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/318/console This message is automatically generated.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Eli!

        Show
        Tom White added a comment - I've just committed this. Thanks Eli!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #196 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/196/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #196 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/196/ )
        Hide
        Todd Lipcon added a comment -

        This should be committed to branch-0.20 as well, since it causes a fail to build from release source on many systems.

        Show
        Todd Lipcon added a comment - This should be committed to branch-0.20 as well, since it causes a fail to build from release source on many systems.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #235 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/235/)
        . Commit to branch 0.20

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #235 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/235/ ) . Commit to branch 0.20
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #233 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/233/)
        . Commit to branch 0.20

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #233 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/233/ ) . Commit to branch 0.20
        Hide
        Chris Douglas added a comment -

        I committed this to the 0.20 branch

        Show
        Chris Douglas added a comment - I committed this to the 0.20 branch
        Hide
        Joep Rottinghuis added a comment -

        Problem is related to header cleanup in gcc 3.4.
        See comment in HADOOP-5611

        This should be applied to branch-0.20-security and the 0.20.205 branch

        Show
        Joep Rottinghuis added a comment - Problem is related to header cleanup in gcc 3.4. See comment in HADOOP-5611 This should be applied to branch-0.20-security and the 0.20.205 branch
        Hide
        Konstantin Shvachko added a comment -

        This one has disappeared from branch-0.20-security although it is present on 0.20.2 where it was committed along with HADOOP-5611.
        If there are no objections I'll reinstate it in 0.20-security.

        Show
        Konstantin Shvachko added a comment - This one has disappeared from branch-0.20-security although it is present on 0.20.2 where it was committed along with HADOOP-5611 . If there are no objections I'll reinstate it in 0.20-security.
        Hide
        Konstantin Shvachko added a comment -

        Committed to branch-0.20-security, 205, and 204.

        Show
        Konstantin Shvachko added a comment - Committed to branch-0.20-security, 205, and 204.

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development