Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8805

Parameter changes for stringField() in StoredFieldVisitor

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 9.0
    • None
    • None
    • New

    Description

      I wrote this patch after seeing the comments left by mikemccand when SortingStoredFieldsConsumer class was first created.

      @Override
      public void binaryField(FieldInfo fieldInfo, byte[] value) throws IOException {
        ...
        // TODO: can we avoid new BR here?
        ...
      }
      @Override
      public void stringField(FieldInfo fieldInfo, byte[] value) throws IOException {
        ...
        // TODO: can we avoid new String here?
        ...
      }
      

      I changed two things.
      1) change binaryField() parameters from byte[] to BytesRef.
      2) change stringField() parameters from byte[] to String.

      I also changed the related contents while doing the work.

      Attachments

        1. LUCENE-8805.patch
          18 kB
          Namgyu Kim
        2. LUCENE-8805.patch
          18 kB
          Namgyu Kim
        3. LUCENE-8805.patch
          19 kB
          Namgyu Kim

        Issue Links

          Activity

            People

              Unassigned Unassigned
              danmuzi Namgyu Kim
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: