[LUCENE-8805] Parameter changes for stringField() in StoredFieldVisitor

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Namgyu Kim
• Created: 18/May/19 17:00
• Updated: 15/Dec/22 15:14
• Resolved: 21/May/19 18:23

Description

I wrote this patch after seeing the comments left by mikemccand when SortingStoredFieldsConsumer class was first created.

@Override
public void binaryField(FieldInfo fieldInfo, byte[] value) throws IOException {
  ...
  // TODO: can we avoid new BR here?
  ...
}
@Override
public void stringField(FieldInfo fieldInfo, byte[] value) throws IOException {
  ...
  // TODO: can we avoid new String here?
  ...
}

I changed two things.
1) change binaryField() parameters from byte[] to BytesRef.
2) change stringField() parameters from byte[] to String.

I also changed the related contents while doing the work.

Issue Links

• causes: SOLR-16589 Large fields with large="true" can be truncated when using unicode values