[LUCENE-7818] Suspicious condition

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 6.5
• Component/s: modules/queryparser
• Labels: static-analysis
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: AppChecker
• Created: 06/May/17 16:05
• Updated: 28/Aug/22 15:14
• Resolved: 07/May/17 11:13

Description

Hi
Please, look this code fragment:

    else if (q1 instanceof AndQueryNode)
      op = ANDOperation.Q1;
    else if (q1 instanceof AndQueryNode)
      op = ANDOperation.Q2;

(q1 instanceof AndQueryNode) is checked twice.

Probably it should be:

    else if (q1 instanceof AndQueryNode)
      op = ANDOperation.Q1;
    else if (q2 instanceof AndQueryNode)
      op = ANDOperation.Q2;

This possible defect found by AppChecker

Issue Links

• duplicates: LUCENE-5365 Typo with QueryNodeOperation.logicalAnd