Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.6, 4.7, 6.0
    • Fix Version/s: 7.0, 6.6
    • Component/s: core/queryparser
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Intellij IDEA finds a bug/typo in QueryNodeOperation.logicalAnd
      -> a boolean condition is always false
      Which means that A and B fails when A is not an ANDQueryNode and B is

      1. typo.patch
        0.7 kB
        Olivier Binda

        Issue Links

          Activity

          Hide
          thetaphi Uwe Schindler added a comment -

          Hi, this is indeed a bug. I will take care of fixing this. – Uwe

          Show
          thetaphi Uwe Schindler added a comment - Hi, this is indeed a bug. I will take care of fixing this. – Uwe
          Hide
          thetaphi Uwe Schindler added a comment -

          Hi, I just wondered why the whole thing does not cause a test failure. The problem here is that this code is just for "optimization" (it merges nodes, if they are AndNodes, otherwise it creates a new AndNode and both childs (this is what happens). So in fact this is not a real bug, everything works. IMHO: The whole logic should be removed!

          Show
          thetaphi Uwe Schindler added a comment - Hi, I just wondered why the whole thing does not cause a test failure. The problem here is that this code is just for "optimization" (it merges nodes, if they are AndNodes, otherwise it creates a new AndNode and both childs (this is what happens). So in fact this is not a real bug, everything works. IMHO: The whole logic should be removed!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0ed39b2774c1c39faf5a6c4cfc9cb68540b16f11 in lucene-solr's branch refs/heads/master from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0ed39b2 ]

          LUCENE-5365, LUCENE-7818: Fix incorrect condition in queryparser's QueryNodeOperation#logicalAnd()

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0ed39b2774c1c39faf5a6c4cfc9cb68540b16f11 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0ed39b2 ] LUCENE-5365 , LUCENE-7818 : Fix incorrect condition in queryparser's QueryNodeOperation#logicalAnd()
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a46b5fc1b6609b6b7723f328c6150c314e3c0d9c in lucene-solr's branch refs/heads/branch_6x from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a46b5fc ]

          LUCENE-5365, LUCENE-7818: Fix incorrect condition in queryparser's QueryNodeOperation#logicalAnd()

          Show
          jira-bot ASF subversion and git services added a comment - Commit a46b5fc1b6609b6b7723f328c6150c314e3c0d9c in lucene-solr's branch refs/heads/branch_6x from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a46b5fc ] LUCENE-5365 , LUCENE-7818 : Fix incorrect condition in queryparser's QueryNodeOperation#logicalAnd()

            People

            • Assignee:
              thetaphi Uwe Schindler
              Reporter:
              Lakedaemon Olivier Binda
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1m
                1m
                Remaining:
                Remaining Estimate - 1m
                1m
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development