Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7564

AnalyzingInfixSuggester should close its IndexWriter by default at the end of build()

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: None
    • Labels:
      None

      Description

      From SOLR-6246, where AnalyzingInfixSuggester's write lock on its index is causing trouble when reloading a Solr core:

      Grant Ingersoll wrote:

      One suggestion that might minimize the impact: close the writer after build

      Varun Thacker wrote:

      This is what I am thinking -

      Create a Lucene issue in which AnalyzingInfixSuggester#build closes the writer by default at the end.
      The add and update methods call ensureOpen and those who do frequent real time updates directly via lucene won't see any slowdowns.

      Michael McCandless - Would this approach have any major drawback from Lucene's perspective? Else I can go ahead an tackle this in a Lucene issue

      Michael McCandless wrote:

      Fixing AnalyzingInfixSuggester to close the writer at the end of build seems reasonable?

        Attachments

        1. LUCENE-7564.patch
          13 kB
          Steven Rowe
        2. LUCENE-7564.patch
          13 kB
          Steven Rowe
        3. LUCENE-7564-fix-random-NRT-failures.patch
          8 kB
          Steven Rowe
        4. LUCENE-7564-fix-random-NRT-failures.patch
          4 kB
          Steven Rowe

          Issue Links

            Activity

              People

              • Assignee:
                sarowe Steven Rowe
                Reporter:
                sarowe Steven Rowe
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: