[LUCENE-6961] Improve Exception handling in AnalysisFactory/SPI loader

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.4
• Fix Version/s: 5.5, 6.0
• Component/s: modules/analysis
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 05/Jan/16 01:27
• Updated: 28/Aug/22 14:47
• Resolved: 05/Jan/16 01:39

Description

Currently the AnalysisSPILoader used by AbstractAnalysisFactory uses a catch Exception block when invoking the constructor. If the constructor throws stuff like IllegalArgumentExceptions or similar, this is hidden inside InvocationTargetException, which gets wrapped in IllegalArgumentException. This is not useful.

This patch will:

• Only catch ReflectiveOperationException
• If it is InvocationTargetException it will rethrow the cause, if it is unchecked. Otherwise it will wrap in RuntimeException
• If the constructor cannot be called at all (reflective access denied, method not found,...) UOE is thrown with explaining message.

This patch will be required by next version of LUCENE-6958.

Issue Links

• is required by: LUCENE-6958 Improve CustomAnalyzer to also allow to specify factory directly (for compile-time safety)