Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6958

Improve CustomAnalyzer to also allow to specify factory directly (for compile-time safety)

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 5.4
    • 5.5, 6.0
    • modules/analysis
    • None
    • New

    Description

      Currently CustomAnalyzer only allows to specify the SPI names of factories. As the fluent builder pattern is mostly used inside Java code, it is better for type safety to optionally also specify the factory class directly (using compile-time safe patterns like .withTokenizer(WhitespaceTokenizerFactory.class)). With the string names, you get the error only at runtime. Of course this does not help with wrong, spelled parameter names, but it also has the side effect that you can click on the class name in your code to get javadocs with the parameter names.

      This issue will add this functionality and update the docs/example.

      Thanks to shaie for suggesting this!

      Attachments

        1. LUCENE-6958.patch
          14 kB
          Uwe Schindler
        2. LUCENE-6958.patch
          16 kB
          Uwe Schindler

        Issue Links

          Activity

            People

              uschindler Uwe Schindler
              uschindler Uwe Schindler
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: