Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5953

Refactor LockFactory usage in Directory

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.0, 6.0
    • core/store
    • None
    • New

    Description

      We should remove the setters for the LockFactory from Directory and make the field final. It is a bug to change the LockFactory after creating a directory, because you may break locking (if locks are currently held).

      The LockFactory should be passed on ctor only.

      The other suggestion: Should LockFactory have a directory at all? We moved away from having the lock separately from the index directory. This is no longer a supported configuration (since approx Lucene 2.9 or 3.0). I would like to remove the directory from LockFactory and make it part of the Directory only.

      Attachments

        1. LUCENE-5953.patch
          132 kB
          Uwe Schindler
        2. LUCENE-5953.patch
          130 kB
          Uwe Schindler
        3. LUCENE-5953.patch
          127 kB
          Uwe Schindler
        4. LUCENE-5953.patch
          130 kB
          Uwe Schindler
        5. LUCENE-5953.patch
          128 kB
          Uwe Schindler

        Issue Links

          Activity

            People

              uschindler Uwe Schindler
              uschindler Uwe Schindler
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: