[LUCENE-5953] Refactor LockFactory usage in Directory

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0, 6.0
• Component/s: core/store
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 15/Sep/14 22:33
• Updated: 28/Aug/22 14:16
• Resolved: 09/Nov/14 13:11

Description

We should remove the setters for the LockFactory from Directory and make the field final. It is a bug to change the LockFactory after creating a directory, because you may break locking (if locks are currently held).

The LockFactory should be passed on ctor only.

The other suggestion: Should LockFactory have a directory at all? We moved away from having the lock separately from the index directory. This is no longer a supported configuration (since approx Lucene 2.9 or 3.0). I would like to remove the directory from LockFactory and make it part of the Directory only.

Issue Links

• is blocked by: SOLR-6519 In trunk change Solr's DirectoryFactory.create method to take LockFactory
• is related to: SOLR-6151 Intermittent TestReplicationHandlerBackup failures