Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5929

Standard highlighting doesn't work for ToParentBlockJoinQuery

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: modules/highlighter
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Because WeightedSpanTermExtractor#extract doesn't check for ToParentBlockJoinQuery, the Highlighter class fails to produce highlights for this type of query.

      At first it may seem like there's no issue, because ToParentBlockJoinQuery only returns parent documents, while the highlighting applies to children. But if a client can directly supply the text from child documents (as elasticsearch does if _source is enabled), then highlighting will unexpectedly fail.

      A test case that triggers the bug is attached. The same issue exists for ToChildBlockJoinQuery.

        Attachments

        1. LUCENE-5929.patch
          9 kB
          Julie Tibshirani
        2. LUCENE-5929.patch
          11 kB
          Michael McCandless
        3. HighligherTest.patch
          6 kB
          Julie Tibshirani

          Activity

            People

            • Assignee:
              mikemccand Michael McCandless
              Reporter:
              jtibs Julie Tibshirani

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment