[LUCENE-5929] Standard highlighting doesn't work for ToParentBlockJoinQuery

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 5.0, 6.0
• Component/s: modules/highlighter
• Lucene Fields: New, Patch Available
• Assignee: Michael McCandless
• Reporter: Julie Tibshirani
• Created: 09/Sep/14 21:48
• Updated: 28/Aug/22 14:15
• Resolved: 13/Nov/14 15:38

Description

Because WeightedSpanTermExtractor#extract doesn't check for ToParentBlockJoinQuery, the Highlighter class fails to produce highlights for this type of query.

At first it may seem like there's no issue, because ToParentBlockJoinQuery only returns parent documents, while the highlighting applies to children. But if a client can directly supply the text from child documents (as elasticsearch does if _source is enabled), then highlighting will unexpectedly fail.

A test case that triggers the bug is attached. The same issue exists for ToChildBlockJoinQuery.