Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5929

Standard highlighting doesn't work for ToParentBlockJoinQuery

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • None
    • 5.0, 6.0
    • modules/highlighter
    • None
    • New, Patch Available

    Description

      Because WeightedSpanTermExtractor#extract doesn't check for ToParentBlockJoinQuery, the Highlighter class fails to produce highlights for this type of query.

      At first it may seem like there's no issue, because ToParentBlockJoinQuery only returns parent documents, while the highlighting applies to children. But if a client can directly supply the text from child documents (as elasticsearch does if _source is enabled), then highlighting will unexpectedly fail.

      A test case that triggers the bug is attached. The same issue exists for ToChildBlockJoinQuery.

      Attachments

        1. HighligherTest.patch
          6 kB
          Julie Tibshirani
        2. LUCENE-5929.patch
          11 kB
          Michael McCandless
        3. LUCENE-5929.patch
          9 kB
          Julie Tibshirani

        Activity

          People

            mikemccand Michael McCandless
            jtibs Julie Tibshirani
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: