[LUCENE-5650] Enforce read-only access to any path outside the temporary folder via security manager

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.0, 6.0
• Component/s: general/test
• Lucene Fields: New
• Assignee: Dawid Weiss
• Reporter: Ryan Ernst
• Created: 06/May/14 20:10
• Updated: 28/Aug/22 14:06
• Resolved: 23/Aug/14 17:40

Description

The recent refactoring to all the create temp file/dir functions (which is great!) has a minor regression from what existed before. With the old LuceneTestCase.TEMP_DIR, the directory was created if it did not exist. So, if you set java.io.tmpdir to "./temp", then it would create that dir within the per jvm working dir. However, getBaseTempDirForClass() now does asserts that check the dir exists, is a dir, and is writeable.

Lucene uses "." as java.io.tmpdir. Then in the test security manager, the per jvm cwd has read/write/execute permissions. However, this allows tests to write to their cwd, which I'm trying to protect against (by setting cwd to read/execute in my test security manager).

Issue Links

• contains: SOLR-6410 Suggester CloseHook for Lookup instances needs backported to 4x branch