Solr
  1. Solr
  2. SOLR-6410

Suggester CloseHook for Lookup instances needs backported to 4x branch

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.10, 5.0, Trunk
    • Component/s: None
    • Labels:
      None

      Description

      Spin off of bug uncovered in LUCENE-5889...

      the Suggester class needs to register a CloseHook for the Lookup instances returned by the LookupFactory – this is currently happening on trunk, but not on 4x.

        Issue Links

          Activity

          Hide
          Anshum Gupta added a comment -

          Bulk close after 5.0 release.

          Show
          Anshum Gupta added a comment - Bulk close after 5.0 release.
          Hide
          Hoss Man added a comment -

          this has been backported to branch_4_10 for inclusion in 4.10.0RC1

          Show
          Hoss Man added a comment - this has been backported to branch_4_10 for inclusion in 4.10.0RC1
          Hide
          ASF subversion and git services added a comment -

          Commit 1620678 from hossman@apache.org in branch 'dev/branches/lucene_solr_4_10'
          [ https://svn.apache.org/r1620678 ]

          SOLR-6410: Ensure all Lookup instances are closed via CloseHook (merge r1619947 and r1620674

          Show
          ASF subversion and git services added a comment - Commit 1620678 from hossman@apache.org in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1620678 ] SOLR-6410 : Ensure all Lookup instances are closed via CloseHook (merge r1619947 and r1620674
          Hide
          ASF subversion and git services added a comment -

          Commit 1620675 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1620675 ]

          SOLR-6410: Ensure all Lookup instances are closed via CloseHook - move CHANGES.txt entry for 4.10 backport (merge r1620674)

          Show
          ASF subversion and git services added a comment - Commit 1620675 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1620675 ] SOLR-6410 : Ensure all Lookup instances are closed via CloseHook - move CHANGES.txt entry for 4.10 backport (merge r1620674)
          Hide
          ASF subversion and git services added a comment -

          Commit 1620674 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1620674 ]

          SOLR-6410: Ensure all Lookup instances are closed via CloseHook - move CHANGES.txt entry for 4.10 backport

          Show
          ASF subversion and git services added a comment - Commit 1620674 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1620674 ] SOLR-6410 : Ensure all Lookup instances are closed via CloseHook - move CHANGES.txt entry for 4.10 backport
          Hide
          Hoss Man added a comment -

          In the interest of trying to see if we can get something in place for 4.10...

          i should have mentioned: my biggest concern is actually just getting the test on the 4x branch passing again.

          Ryan Ernst msged me that he already had the 4.10 RC cut and was mid-smoke checker, so for now i've only backported to the 4x branch (with CAHNGES.txt recording this issue as fixed in 4.11).

          I have no strong opinions about wether it's worth respining the 4.10 RC for this issue, or if we should merge it ot branch_4_10 if a respin is required for any other issues .. for now i'm just happy that it's on 4x and jenkins is beating on it.

          Show
          Hoss Man added a comment - In the interest of trying to see if we can get something in place for 4.10... i should have mentioned: my biggest concern is actually just getting the test on the 4x branch passing again. Ryan Ernst msged me that he already had the 4.10 RC cut and was mid-smoke checker, so for now i've only backported to the 4x branch (with CAHNGES.txt recording this issue as fixed in 4.11). I have no strong opinions about wether it's worth respining the 4.10 RC for this issue, or if we should merge it ot branch_4_10 if a respin is required for any other issues .. for now i'm just happy that it's on 4x and jenkins is beating on it.
          Hide
          ASF subversion and git services added a comment -

          Commit 1619947 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1619947 ]

          SOLR-6410: Ensure all Lookup instances are closed via CloseHook (merge r1596767 from LUCENE-5650 just for the solr/spelling/suggest paths; and merge r1619946 for the CHANGES.txt entry)

          Show
          ASF subversion and git services added a comment - Commit 1619947 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1619947 ] SOLR-6410 : Ensure all Lookup instances are closed via CloseHook (merge r1596767 from LUCENE-5650 just for the solr/spelling/suggest paths; and merge r1619946 for the CHANGES.txt entry)
          Hide
          ASF subversion and git services added a comment -

          Commit 1619946 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1619946 ]

          CHANGES.txt entry for SOLR-6410, 4x only issue

          Show
          ASF subversion and git services added a comment - Commit 1619946 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1619946 ] CHANGES.txt entry for SOLR-6410 , 4x only issue
          Hide
          Hoss Man added a comment -

          LUCENE-5650 seems to be the issue where the correct CloseHook logic was added to the Solr Suggester code ... but for whatever reason that hasn't been backported to 4x?

          In the interest of trying to see if we can get something in place for 4.10, I'm going to try to backport r1596767 for only the following files...

          • solr/core/src/java/org/apache/solr/spelling/suggest/SolrSuggester.java
          • solr/core/src/java/org/apache/solr/spelling/suggest/Suggester.java
          • solr/core/src/java/org/apache/solr/spelling/suggest/fst/AnalyzingInfixLookupFactory.java
          • solr/core/src/java/org/apache/solr/spelling/suggest/fst/BlendedInfixLookupFactory.java
          • solr/core/src/test/org/apache/solr/spelling/suggest/TestAnalyzeInfixSuggestions.java
          • solr/core/src/test/org/apache/solr/spelling/suggest/TestBlendedInfixSuggestions.java
          Show
          Hoss Man added a comment - LUCENE-5650 seems to be the issue where the correct CloseHook logic was added to the Solr Suggester code ... but for whatever reason that hasn't been backported to 4x? In the interest of trying to see if we can get something in place for 4.10, I'm going to try to backport r1596767 for only the following files... solr/core/src/java/org/apache/solr/spelling/suggest/SolrSuggester.java solr/core/src/java/org/apache/solr/spelling/suggest/Suggester.java solr/core/src/java/org/apache/solr/spelling/suggest/fst/AnalyzingInfixLookupFactory.java solr/core/src/java/org/apache/solr/spelling/suggest/fst/BlendedInfixLookupFactory.java solr/core/src/test/org/apache/solr/spelling/suggest/TestAnalyzeInfixSuggestions.java solr/core/src/test/org/apache/solr/spelling/suggest/TestBlendedInfixSuggestions.java

            People

            • Assignee:
              Hoss Man
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development