[LUCENE-5325] Move ValueSource and FunctionValues under core/

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.4, 7.0
• Component/s: core/search
• Lucene Fields: New
• Assignee: Alan Woodward
• Reporter: Shai Erera
• Created: 03/Nov/13 19:47
• Updated: 28/Aug/22 13:56
• Resolved: 29/Dec/16 20:29

Description

Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs which exist under the queries/ module. That causes any module which wants to depend on these APIs (but not necessarily on any of their actual implementations!), to depend on the queries/ module. If we move these APIs under core/, we can eliminate these dependencies and add some mock impls for testing purposes.

Quoting Robert from LUCENE-5298:

we should eliminate the suggest/ dependencies on expressions and queries, the expressions/ on queries, the grouping/ dependency on queries, the spatial/ dependency on queries, its a mess.

To add to that list, facet/ should not depend on queries too.

Issue Links

• relates to: SOLR-6575 ValueSources/FunctionValues should be able to (dynamically) indicate their prefered data type (propogating up)

Sub-Tasks

• Change raw Map type to Map<String,Object> for ValueSource context: Open