Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5325

Move ValueSource and FunctionValues under core/

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs which exist under the queries/ module. That causes any module which wants to depend on these APIs (but not necessarily on any of their actual implementations!), to depend on the queries/ module. If we move these APIs under core/, we can eliminate these dependencies and add some mock impls for testing purposes.

      Quoting Robert from LUCENE-5298:

      we should eliminate the suggest/ dependencies on expressions and queries, the expressions/ on queries, the grouping/ dependency on queries, the spatial/ dependency on queries, its a mess.

      To add to that list, facet/ should not depend on queries too.

        Attachments

        1. LUCENE-5325-6x-matchingbits.patch
          3 kB
          Alan Woodward
        2. LUCENE-5325-6x.patch
          33 kB
          Alan Woodward
        3. LUCENE-5325.patch
          33 kB
          Alan Woodward
        4. LUCENE-5325.patch
          34 kB
          Alan Woodward
        5. LUCENE-5325.patch
          34 kB
          Alan Woodward
        6. LUCENE-5325.patch
          122 kB
          Alan Woodward
        7. LUCENE-5325.patch
          56 kB
          Alan Woodward
        8. LUCENE-5325.patch
          62 kB
          Alan Woodward
        9. LUCENE-5325.patch
          57 kB
          Alan Woodward

          Issue Links

            Activity

              People

              • Assignee:
                romseygeek Alan Woodward
                Reporter:
                shaie Shai Erera
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: