Lucene - Core
  1. Lucene - Core
  2. LUCENE-5196

Revive LTC.PREFLEX_IMPERSONATION_IS_ACTIVE

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, 5.0
    • Component/s: general/test
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      This constant is currently not used and from what I understand, it was used in the past to test 3.x stuff? Anyway, I want to revive it by renaming it to OLD_FORMAT_IMPERSONATION_IS_ACTIVE (defaults to true) and have the RWCodecs respect it by not supporting e.g. fieldsConsumer() if it's set to false. This will allow tests that want to verify e.g. old formats are not supported work.

      Currently it's impossible because the RWCodec gets loaded before the non-RW by SPI, and so writing segments in an old format always work. I want to test something like that in LUCENE-5189 and prevents it.

      Will post a patch soon.

      1. LUCENE-5196.patch
        10 kB
        Shai Erera
      2. LUCENE-5196.patch
        12 kB
        Shai Erera

        Activity

        Adrien Grand made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Shai Erera made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 5.0 [ 12321663 ]
        Fix Version/s 4.5 [ 12324742 ]
        Resolution Fixed [ 1 ]
        Shai Erera made changes -
        Attachment LUCENE-5196.patch [ 12600930 ]
        Shai Erera made changes -
        Field Original Value New Value
        Attachment LUCENE-5196.patch [ 12600926 ]
        Shai Erera created issue -

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development