[LUCENE-5016] Sampling can break FacetResult labeling

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.3
• Fix Version/s: 4.4, 6.0
• Component/s: modules/facet
• Lucene Fields: New, Patch Available
• Assignee: Shai Erera
• Reporter: Rob Audenaerde
• Created: 24/May/13 09:16
• Updated: 28/Aug/22 13:46
• Resolved: 30/May/13 10:40

Description

When sampling FacetResults, the TopKInEachNodeHandler is used to get the FacetResults.

This is my case:
A FacetResult is returned (which matches a FacetRequest) from the StandardFacetAccumulator. The facet has 0 results. The labelling of the root-node seems incorrect. I know, from the StandardFacetAccumulator, that the rootnode has a label, so I can use that one.

Currently the recursivelyLabel method uses the taxonomyReader.getPath() to retrieve the label. I think we can skip that for the rootNode when there are no children (and gain a little performance on the way too?)