Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5016

Sampling can break FacetResult labeling

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.3
    • 4.4, 6.0
    • modules/facet
    • None
    • New, Patch Available

    Description

      When sampling FacetResults, the TopKInEachNodeHandler is used to get the FacetResults.

      This is my case:
      A FacetResult is returned (which matches a FacetRequest) from the StandardFacetAccumulator. The facet has 0 results. The labelling of the root-node seems incorrect. I know, from the StandardFacetAccumulator, that the rootnode has a label, so I can use that one.

      Currently the recursivelyLabel method uses the taxonomyReader.getPath() to retrieve the label. I think we can skip that for the rootNode when there are no children (and gain a little performance on the way too?)

      Attachments

        1. LUCENE-5016.patch
          11 kB
          Shai Erera
        2. test-labels.zip
          4 kB
          Rob Audenaerde

        Activity

          People

            shaie Shai Erera
            robau Rob Audenaerde
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: