Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-3973

Incorporate PMD / FindBugs

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: general/build
    • Labels:
    • Lucene Fields:
      New

      Description

      This has been touched on a few times over the years. Having static analysis as part of our build seems like a big win. For example, we could use PMD to look at System.out.println statements like discussed in LUCENE-3877 and we could possibly incorporate the nocommit / @author checks as well.

      There are a few things to work out as part of this:

      • Should we use both PMD and FindBugs or just one of them? They look at code from different perspectives (bytecode vs source code) and target different issues. At the moment I'm in favour of trying both but that might be too heavy handed for our needs.
      • What checks should we use? There's no point having the analysis if it's going to raise too many false-positives or problems we don't deem problematic.
      • How should the analysis be integrated in our build? Need to work out when the analysis should run, how it should be incorporated in Ant and/or Maven, what impact errors should have.

        Attachments

        1. core.html
          472 kB
          Chris Male
        2. findbugs-lucene.patch
          2 kB
          Daniel Jelinski
        3. LUCENE-3973.patch
          7 kB
          Mike Drob
        4. LUCENE-3973.patch
          7 kB
          Mike Drob
        5. LUCENE-3973.patch
          6 kB
          Mike Drob
        6. LUCENE-3973.patch
          5 kB
          Chris Male
        7. LUCENE-3973.patch
          3 kB
          Robert Muir
        8. LUCENE-3973.patch
          2 kB
          Chris Male
        9. LUCENE-3973.patch
          2 kB
          Chris Male
        10. LUCENE-3973.patch
          0.9 kB
          Chris Male
        11. solr-core.html
          382 kB
          Chris Male

        Issue Links

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              cmale Chris Male

              Dates

              • Created:
                Updated:

                Issue deployment