Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: general/build
    • Labels:
    • Lucene Fields:
      New

      Description

      This has been touched on a few times over the years. Having static analysis as part of our build seems like a big win. For example, we could use PMD to look at System.out.println statements like discussed in LUCENE-3877 and we could possibly incorporate the nocommit / @author checks as well.

      There are a few things to work out as part of this:

      • Should we use both PMD and FindBugs or just one of them? They look at code from different perspectives (bytecode vs source code) and target different issues. At the moment I'm in favour of trying both but that might be too heavy handed for our needs.
      • What checks should we use? There's no point having the analysis if it's going to raise too many false-positives or problems we don't deem problematic.
      • How should the analysis be integrated in our build? Need to work out when the analysis should run, how it should be incorporated in Ant and/or Maven, what impact errors should have.
      1. core.html
        472 kB
        Chris Male
      2. LUCENE-3973.patch
        7 kB
        Mike Drob
      3. LUCENE-3973.patch
        7 kB
        Mike Drob
      4. LUCENE-3973.patch
        6 kB
        Mike Drob
      5. LUCENE-3973.patch
        5 kB
        Chris Male
      6. LUCENE-3973.patch
        3 kB
        Robert Muir
      7. LUCENE-3973.patch
        2 kB
        Chris Male
      8. LUCENE-3973.patch
        2 kB
        Chris Male
      9. LUCENE-3973.patch
        0.9 kB
        Chris Male
      10. solr-core.html
        382 kB
        Chris Male

        Issue Links

          Activity

          Mike Drob made changes -
          Attachment LUCENE-3973.patch [ 12697123 ]
          Mike Drob made changes -
          Attachment LUCENE-3973.patch [ 12697060 ]
          Mike Drob made changes -
          Attachment LUCENE-3973.patch [ 12696871 ]
          Robert Muir made changes -
          Labels newdev
          Chris Male made changes -
          Attachment LUCENE-3973.patch [ 12525252 ]
          Robert Muir made changes -
          Attachment LUCENE-3973.patch [ 12523746 ]
          Chris Male made changes -
          Attachment LUCENE-3973.patch [ 12523744 ]
          Chris Male made changes -
          Attachment LUCENE-3973.patch [ 12523742 ]
          Robert Muir made changes -
          Comment [ {quote}
          I believe both pmd and findbugs are on maven repos so one could use ivy to fetch them automatically. One thing less to think about.
          {q ]
          Chris Male made changes -
          Attachment core.html [ 12522668 ]
          Attachment solr-core.html [ 12522669 ]
          Chris Male made changes -
          Attachment LUCENE-3973.patch [ 12522667 ]
          Hoss Man made changes -
          Field Original Value New Value
          Link This issue relates to SOLR-143 [ SOLR-143 ]
          Chris Male created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              Chris Male
            • Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:

                Development