| # | File | Line | Problem |
| 1 |
org/apache/solr/SolrLogFormatter.java |
187 |
Deeply nested if..then statements are hard to read |
| 2 |
org/apache/solr/SolrLogFormatter.java |
197 |
Deeply nested if..then statements are hard to read |
| 3 |
org/apache/solr/SolrLogFormatter.java |
204 |
Deeply nested if..then statements are hard to read |
| 4 |
org/apache/solr/SolrLogFormatter.java |
241 |
Avoid if (x != y) ..; else ..; |
| 5 |
org/apache/solr/SolrLogFormatter.java |
263 |
Private field 'classAndMethod' could be made final; it is only initialized in the declaration or constructor. |
| 6 |
org/apache/solr/SolrLogFormatter.java |
355 |
Overriding method merely calls super |
| 7 |
org/apache/solr/SolrLogFormatter.java |
360 |
Overriding method merely calls super |
| 8 |
org/apache/solr/analysis/BaseTokenFilterFactory.java |
28 |
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. |
| 9 |
org/apache/solr/analysis/BaseTokenStreamFactory.java |
50 |
This abstract class does not have any abstract methods |
| 10 |
org/apache/solr/analysis/BaseTokenStreamFactory.java |
126 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 11 |
org/apache/solr/analysis/BaseTokenStreamFactory.java |
147 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 12 |
org/apache/solr/analysis/BaseTokenizerFactory.java |
28 |
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. |
| 13 |
org/apache/solr/analysis/CollationKeyFilterFactory.java |
95 |
Avoid if (x != y) ..; else ..; |
| 14 |
org/apache/solr/analysis/CollationKeyFilterFactory.java |
144 |
Avoid if (x != y) ..; else ..; |
| 15 |
org/apache/solr/analysis/CollationKeyFilterFactory.java |
146 |
Avoid if (x != y) ..; else ..; |
| 16 |
org/apache/solr/analysis/CommonGramsFilterFactory.java |
50 |
Avoid if (x != y) ..; else ..; |
| 17 |
org/apache/solr/analysis/CommonGramsFilterFactory.java |
79 |
Consider simply returning the value vs storing it in local variable 'commonGrams' |
| 18 |
org/apache/solr/analysis/CommonGramsQueryFilterFactory.java |
57 |
Avoid if (x != y) ..; else ..; |
| 19 |
org/apache/solr/analysis/DelimitedPayloadTokenFilterFactory.java |
57 |
Overriding method merely calls super |
| 20 |
org/apache/solr/analysis/DelimitedPayloadTokenFilterFactory.java |
63 |
Position literals first in String comparisons |
| 21 |
org/apache/solr/analysis/DelimitedPayloadTokenFilterFactory.java |
65 |
Position literals first in String comparisons |
| 22 |
org/apache/solr/analysis/DelimitedPayloadTokenFilterFactory.java |
67 |
Position literals first in String comparisons |
| 23 |
org/apache/solr/analysis/EdgeNGramFilterFactory.java |
46 |
Avoid if (x != y) ..; else ..; |
| 24 |
org/apache/solr/analysis/EdgeNGramFilterFactory.java |
50 |
Avoid if (x != y) ..; else ..; |
| 25 |
org/apache/solr/analysis/EdgeNGramTokenizerFactory.java |
46 |
Avoid if (x != y) ..; else ..; |
| 26 |
org/apache/solr/analysis/EdgeNGramTokenizerFactory.java |
49 |
Avoid if (x != y) ..; else ..; |
| 27 |
org/apache/solr/analysis/FSTSynonymFilterFactory.java |
86 |
Position literals first in String comparisons |
| 28 |
org/apache/solr/analysis/JapaneseTokenizerFactory.java |
68 |
Avoid if (x != y) ..; else ..; |
| 29 |
org/apache/solr/analysis/JapaneseTokenizerFactory.java |
94 |
Avoid if (x != y) ..; else ..; |
| 30 |
org/apache/solr/analysis/LegacyHTMLStripCharFilter.java |
133 |
A switch statement does not contain a break |
| 31 |
org/apache/solr/analysis/LegacyHTMLStripCharFilter.java |
709 |
A high ratio of statements to labels in a switch statement. Consider refactoring. |
| 32 |
org/apache/solr/analysis/LegacyHTMLStripCharFilter.java |
763 |
Avoid reassigning parameters such as 'off' |
| 33 |
org/apache/solr/analysis/MappingCharFilterFactory.java |
109 |
Switch statements should have a default label |
| 34 |
org/apache/solr/analysis/NGramFilterFactory.java |
45 |
Avoid if (x != y) ..; else ..; |
| 35 |
org/apache/solr/analysis/NGramFilterFactory.java |
49 |
Avoid if (x != y) ..; else ..; |
| 36 |
org/apache/solr/analysis/NGramTokenizerFactory.java |
45 |
Avoid if (x != y) ..; else ..; |
| 37 |
org/apache/solr/analysis/NGramTokenizerFactory.java |
48 |
Avoid if (x != y) ..; else ..; |
| 38 |
org/apache/solr/analysis/PathHierarchyTokenizerFactory.java |
52 |
Avoid if (x != y) ..; else ..; |
| 39 |
org/apache/solr/analysis/PathHierarchyTokenizerFactory.java |
53 |
Avoid if (x != y) ..; else ..; |
| 40 |
org/apache/solr/analysis/PathHierarchyTokenizerFactory.java |
65 |
Avoid if (x != y) ..; else ..; |
| 41 |
org/apache/solr/analysis/PathHierarchyTokenizerFactory.java |
66 |
Avoid if (x != y) ..; else ..; |
| 42 |
org/apache/solr/analysis/PatternReplaceFilterFactory.java |
59 |
Position literals first in String comparisons |
| 43 |
org/apache/solr/analysis/PatternReplaceFilterFactory.java |
62 |
Position literals first in String comparisons |
| 44 |
org/apache/solr/analysis/PatternTokenizerFactory.java |
96 |
New exception is thrown in catch block, original stack trace may be lost |
| 45 |
org/apache/solr/analysis/PhoneticFilterFactory.java |
68 |
Non-static initializers are confusing |
| 46 |
org/apache/solr/analysis/PhoneticFilterFactory.java |
126 |
New exception is thrown in catch block, original stack trace may be lost |
| 47 |
org/apache/solr/analysis/PhoneticFilterFactory.java |
126 |
New exception is thrown in catch block, original stack trace may be lost |
| 48 |
org/apache/solr/analysis/PhoneticFilterFactory.java |
130 |
New exception is thrown in catch block, original stack trace may be lost |
| 49 |
org/apache/solr/analysis/ReversedWildcardFilter.java |
40 |
Private field 'withOriginal' could be made final; it is only initialized in the declaration or constructor. |
| 50 |
org/apache/solr/analysis/ReversedWildcardFilter.java |
41 |
Private field 'markerChar' could be made final; it is only initialized in the declaration or constructor. |
| 51 |
org/apache/solr/analysis/ReversedWildcardFilter.java |
43 |
Private field 'termAtt' could be made final; it is only initialized in the declaration or constructor. |
| 52 |
org/apache/solr/analysis/ReversedWildcardFilter.java |
44 |
Private field 'posAtt' could be made final; it is only initialized in the declaration or constructor. |
| 53 |
org/apache/solr/analysis/ReversedWildcardFilter.java |
69 |
Avoid unnecessary comparisons in boolean expressions |
| 54 |
org/apache/solr/analysis/ReversedWildcardFilterFactory.java |
66 |
Private field 'markerChar' could be made final; it is only initialized in the declaration or constructor. |
| 55 |
org/apache/solr/analysis/ReversedWildcardFilterFactory.java |
107 |
Avoid if (x != y) ..; else ..; |
| 56 |
org/apache/solr/analysis/SlowSynonymFilter.java |
94 |
Avoid if (x != y) ..; else ..; |
| 57 |
org/apache/solr/analysis/SlowSynonymFilter.java |
198 |
Avoid if (x != y) ..; else ..; |
| 58 |
org/apache/solr/analysis/SlowSynonymFilter.java |
233 |
Avoid if (x != y) ..; else ..; |
| 59 |
org/apache/solr/analysis/SlowSynonymFilter.java |
251 |
Use equals() to compare object references. |
| 60 |
org/apache/solr/analysis/SlowSynonymMap.java |
40 |
Document empty constructor |
| 61 |
org/apache/solr/analysis/SlowSynonymMap.java |
137 |
Avoid if (x != y) ..; else ..; |
| 62 |
org/apache/solr/analysis/SlowSynonymMap.java |
138 |
Avoid if (x != y) ..; else ..; |
| 63 |
org/apache/solr/analysis/SlowSynonymMap.java |
147 |
Avoid if (x != y) ..; else ..; |
| 64 |
org/apache/solr/analysis/SlowSynonymMap.java |
156 |
Avoid if (x != y) ..; else ..; |
| 65 |
org/apache/solr/analysis/SnowballPorterFilterFactory.java |
79 |
Avoid reassigning parameters such as 'input' |
| 66 |
org/apache/solr/analysis/StemmerOverrideFilterFactory.java |
52 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 67 |
org/apache/solr/analysis/StopFilterFactory.java |
56 |
Avoid if (x != y) ..; else ..; |
| 68 |
org/apache/solr/analysis/TokenizerChain.java |
68 |
Avoid reassigning parameters such as 'reader' |
| 69 |
org/apache/solr/analysis/TrieTokenizerFactory.java |
56 |
Avoid protected fields in a final class. Change to private or package access. |
| 70 |
org/apache/solr/analysis/TrieTokenizerFactory.java |
57 |
Avoid protected fields in a final class. Change to private or package access. |
| 71 |
org/apache/solr/analysis/TrieTokenizerFactory.java |
58 |
Avoid protected fields in a final class. Change to private or package access. |
| 72 |
org/apache/solr/analysis/TrieTokenizerFactory.java |
59 |
Avoid protected fields in a final class. Change to private or package access. |
| 73 |
org/apache/solr/analysis/TrieTokenizerFactory.java |
61 |
Avoid protected fields in a final class. Change to private or package access. |
| 74 |
org/apache/solr/analysis/TrieTokenizerFactory.java |
62 |
Avoid protected fields in a final class. Change to private or package access. |
| 75 |
org/apache/solr/analysis/TrieTokenizerFactory.java |
83 |
Avoid reassigning parameters such as 'input' |
| 76 |
org/apache/solr/analysis/TrieTokenizerFactory.java |
113 |
New exception is thrown in catch block, original stack trace may be lost |
| 77 |
org/apache/solr/analysis/TypeTokenFilterFactory.java |
50 |
Avoid if (x != y) ..; else ..; |
| 78 |
org/apache/solr/analysis/TypeTokenFilterFactory.java |
53 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 79 |
org/apache/solr/analysis/WordDelimiterFilterFactory.java |
155 |
Position literals first in String comparisons |
| 80 |
org/apache/solr/analysis/WordDelimiterFilterFactory.java |
157 |
Position literals first in String comparisons |
| 81 |
org/apache/solr/analysis/WordDelimiterFilterFactory.java |
159 |
Position literals first in String comparisons |
| 82 |
org/apache/solr/analysis/WordDelimiterFilterFactory.java |
161 |
Position literals first in String comparisons |
| 83 |
org/apache/solr/analysis/WordDelimiterFilterFactory.java |
163 |
Position literals first in String comparisons |
| 84 |
org/apache/solr/analysis/WordDelimiterFilterFactory.java |
165 |
Position literals first in String comparisons |
| 85 |
org/apache/solr/analysis/WordDelimiterFilterFactory.java |
183 |
Switch statements should have a default label |
| 86 |
org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java |
133 |
Deeply nested if..then statements are hard to read |
| 87 |
org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java |
196 |
Avoid reassigning parameters such as 'docs' |
| 88 |
org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java |
220 |
Consider simply returning the value vs storing it in local variable 'normalized' |
| 89 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
96 |
Avoid if (x != y) ..; else ..; |
| 90 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
117 |
Deeply nested if..then statements are hard to read |
| 91 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
134 |
Document empty method |
| 92 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
308 |
Document empty method |
| 93 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
312 |
Method call on object which may be null |
| 94 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
324 |
Document empty method |
| 95 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
329 |
Document empty method |
| 96 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
339 |
Document empty method |
| 97 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
344 |
Document empty method |
| 98 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
349 |
Document empty method |
| 99 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
354 |
Document empty method |
| 100 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
359 |
Document empty method |
| 101 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
364 |
Document empty method |
| 102 |
org/apache/solr/client/solrj/embedded/JettySolrRunner.java |
369 |
Document empty method |
| 103 |
org/apache/solr/cloud/AssignShard.java |
30 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 104 |
org/apache/solr/cloud/AssignShard.java |
39 |
Avoid reassigning parameters such as 'numShards' |
| 105 |
org/apache/solr/cloud/ElectionContext.java |
45 |
Private field 'zkClient' could be made final; it is only initialized in the declaration or constructor. |
| 106 |
org/apache/solr/cloud/ElectionContext.java |
105 |
Private field 'zkController' could be made final; it is only initialized in the declaration or constructor. |
| 107 |
org/apache/solr/cloud/ElectionContext.java |
106 |
Private field 'cc' could be made final; it is only initialized in the declaration or constructor. |
| 108 |
org/apache/solr/cloud/ElectionContext.java |
107 |
Private field 'syncStrategy' could be made final; it is only initialized in the declaration or constructor. |
| 109 |
org/apache/solr/cloud/ElectionContext.java |
142 |
Deeply nested if..then statements are hard to read |
| 110 |
org/apache/solr/cloud/ElectionContext.java |
148 |
Deeply nested if..then statements are hard to read |
| 111 |
org/apache/solr/cloud/ElectionContext.java |
196 |
These nested if statements could be combined |
| 112 |
org/apache/solr/cloud/LeaderElector.java |
67 |
Private field 'zkCmdExecutor' could be made final; it is only initialized in the declaration or constructor. |
| 113 |
org/apache/solr/cloud/NodeStateWatcher.java |
86 |
Avoid if (x != y) ..; else ..; |
| 114 |
org/apache/solr/cloud/NodeStateWatcher.java |
104 |
These nested if statements could be combined |
| 115 |
org/apache/solr/cloud/NodeStateWatcher.java |
119 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 116 |
org/apache/solr/cloud/NodeStateWatcher.java |
125 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 117 |
org/apache/solr/cloud/NodeStateWatcher.java |
136 |
Avoid empty if statements |
| 118 |
org/apache/solr/cloud/Overseer.java |
83 |
Private field 'nodeStateWatches' could be made final; it is only initialized in the declaration or constructor. |
| 119 |
org/apache/solr/cloud/Overseer.java |
86 |
Private field 'shardLeaderWatches' could be made final; it is only initialized in the declaration or constructor. |
| 120 |
org/apache/solr/cloud/Overseer.java |
87 |
Private field 'zkCmdExecutor' could be made final; it is only initialized in the declaration or constructor. |
| 121 |
org/apache/solr/cloud/Overseer.java |
118 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 122 |
org/apache/solr/cloud/Overseer.java |
126 |
Switch statements should have a default label |
| 123 |
org/apache/solr/cloud/Overseer.java |
191 |
Avoid reassigning parameters such as 'state' |
| 124 |
org/apache/solr/cloud/Overseer.java |
232 |
Consider simply returning the value vs storing it in local variable 'newCloudState' |
| 125 |
org/apache/solr/cloud/Overseer.java |
245 |
Consider simply returning the value vs storing it in local variable 'newCloudState' |
| 126 |
org/apache/solr/cloud/Overseer.java |
275 |
Avoid if (x != y) ..; else ..; |
| 127 |
org/apache/solr/cloud/Overseer.java |
310 |
Avoid if (x != y) ..; else ..; |
| 128 |
org/apache/solr/cloud/Overseer.java |
359 |
Consider simply returning the value vs storing it in local variable 'newState' |
| 129 |
org/apache/solr/cloud/Overseer.java |
367 |
Overridable method 'createWatches' called during object construction |
| 130 |
org/apache/solr/cloud/Overseer.java |
370 |
Avoid using java.lang.ThreadGroup; it is not thread safe |
| 131 |
org/apache/solr/cloud/Overseer.java |
376 |
Use block level rather than method level synchronization |
| 132 |
org/apache/solr/cloud/Overseer.java |
543 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 133 |
org/apache/solr/cloud/Overseer.java |
561 |
Avoid if (x != y) ..; else ..; |
| 134 |
org/apache/solr/cloud/RecoveryStrategy.java |
69 |
Private field 'zkController' could be made final; it is only initialized in the declaration or constructor. |
| 135 |
org/apache/solr/cloud/RecoveryStrategy.java |
70 |
Private field 'baseUrl' could be made final; it is only initialized in the declaration or constructor. |
| 136 |
org/apache/solr/cloud/RecoveryStrategy.java |
71 |
Private field 'coreZkNodeName' could be made final; it is only initialized in the declaration or constructor. |
| 137 |
org/apache/solr/cloud/RecoveryStrategy.java |
72 |
Private field 'zkStateReader' could be made final; it is only initialized in the declaration or constructor. |
| 138 |
org/apache/solr/cloud/RecoveryStrategy.java |
76 |
Private field 'cc' could be made final; it is only initialized in the declaration or constructor. |
| 139 |
org/apache/solr/cloud/RecoveryStrategy.java |
243 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 140 |
org/apache/solr/cloud/RecoveryStrategy.java |
378 |
Avoid empty if statements |
| 141 |
org/apache/solr/cloud/SolrZkServer.java |
55 |
Private field 'dataHome' could be made final; it is only initialized in the declaration or constructor. |
| 142 |
org/apache/solr/cloud/SolrZkServer.java |
56 |
Private field 'confHome' could be made final; it is only initialized in the declaration or constructor. |
| 143 |
org/apache/solr/cloud/SolrZkServer.java |
306 |
Avoid if (x != y) ..; else ..; |
| 144 |
org/apache/solr/cloud/SolrZkServer.java |
332 |
Position literals first in String comparisons |
| 145 |
org/apache/solr/cloud/SolrZkServer.java |
334 |
Position literals first in String comparisons |
| 146 |
org/apache/solr/cloud/SolrZkServer.java |
336 |
Position literals first in String comparisons |
| 147 |
org/apache/solr/cloud/SolrZkServer.java |
338 |
Position literals first in String comparisons |
| 148 |
org/apache/solr/cloud/SolrZkServer.java |
340 |
Position literals first in String comparisons |
| 149 |
org/apache/solr/cloud/SolrZkServer.java |
342 |
Position literals first in String comparisons |
| 150 |
org/apache/solr/cloud/SolrZkServer.java |
344 |
Position literals first in String comparisons |
| 151 |
org/apache/solr/cloud/SolrZkServer.java |
346 |
Position literals first in String comparisons |
| 152 |
org/apache/solr/cloud/SolrZkServer.java |
475 |
New exception is thrown in catch block, original stack trace may be lost |
| 153 |
org/apache/solr/cloud/SyncStrategy.java |
54 |
Perhaps 'shardHandlerFactory' could be replaced by a local variable. |
| 154 |
org/apache/solr/cloud/SyncStrategy.java |
54 |
Private field 'shardHandlerFactory' could be made final; it is only initialized in the declaration or constructor. |
| 155 |
org/apache/solr/cloud/SyncStrategy.java |
56 |
Private field 'shardHandler' could be made final; it is only initialized in the declaration or constructor. |
| 156 |
org/apache/solr/cloud/SyncStrategy.java |
91 |
Consider simply returning the value vs storing it in local variable 'success' |
| 157 |
org/apache/solr/cloud/SyncStrategy.java |
129 |
Avoid empty if statements |
| 158 |
org/apache/solr/cloud/SyncStrategy.java |
265 |
Avoid reassigning parameters such as 'replica' |
| 159 |
org/apache/solr/cloud/ZkController.java |
88 |
Private field 'coreStates' could be made final; it is only initialized in the declaration or constructor. |
| 160 |
org/apache/solr/cloud/ZkController.java |
91 |
Private field 'coreStatesPublishLock' could be made final; it is only initialized in the declaration or constructor. |
| 161 |
org/apache/solr/cloud/ZkController.java |
95 |
Private field 'zkClient' could be made final; it is only initialized in the declaration or constructor. |
| 162 |
org/apache/solr/cloud/ZkController.java |
96 |
Private field 'cmdExecutor' could be made final; it is only initialized in the declaration or constructor. |
| 163 |
org/apache/solr/cloud/ZkController.java |
97 |
Private field 'zkStateReader' could be made final; it is only initialized in the declaration or constructor. |
| 164 |
org/apache/solr/cloud/ZkController.java |
99 |
Private field 'leaderElector' could be made final; it is only initialized in the declaration or constructor. |
| 165 |
org/apache/solr/cloud/ZkController.java |
101 |
Private field 'zkServerAddress' could be made final; it is only initialized in the declaration or constructor. |
| 166 |
org/apache/solr/cloud/ZkController.java |
104 |
Perhaps 'localHostContext' could be replaced by a local variable. |
| 167 |
org/apache/solr/cloud/ZkController.java |
105 |
Perhaps 'localHost' could be replaced by a local variable. |
| 168 |
org/apache/solr/cloud/ZkController.java |
115 |
Private field 'cc' could be made final; it is only initialized in the declaration or constructor. |
| 169 |
org/apache/solr/cloud/ZkController.java |
140 |
Document empty method |
| 170 |
org/apache/solr/cloud/ZkController.java |
311 |
Avoid reassigning parameters such as 'host' |
| 171 |
org/apache/solr/cloud/ZkController.java |
311 |
Avoid reassigning parameters such as 'host' |
| 172 |
org/apache/solr/cloud/ZkController.java |
311 |
Avoid reassigning parameters such as 'host' |
| 173 |
org/apache/solr/cloud/ZkController.java |
589 |
Avoid if (x != y) ..; else ..; |
| 174 |
org/apache/solr/cloud/ZkController.java |
607 |
Avoid if (x != y) ..; else ..; |
| 175 |
org/apache/solr/cloud/ZkController.java |
717 |
Avoid if (x != y) ..; else ..; |
| 176 |
org/apache/solr/cloud/ZkController.java |
851 |
Avoid if (x != y) ..; else ..; |
| 177 |
org/apache/solr/cloud/ZkController.java |
861 |
Avoid if (x != y) ..; else ..; |
| 178 |
org/apache/solr/cloud/ZkController.java |
874 |
Avoid if (x != y) ..; else ..; |
| 179 |
org/apache/solr/cloud/ZkController.java |
940 |
Avoid empty catch blocks |
| 180 |
org/apache/solr/cloud/ZkController.java |
979 |
New exception is thrown in catch block, original stack trace may be lost |
| 181 |
org/apache/solr/cloud/ZkController.java |
1068 |
Avoid if (x != y) ..; else ..; |
| 182 |
org/apache/solr/cloud/ZkController.java |
1108 |
New exception is thrown in catch block, original stack trace may be lost |
| 183 |
org/apache/solr/cloud/ZkController.java |
1147 |
New exception is thrown in catch block, original stack trace may be lost |
| 184 |
org/apache/solr/cloud/ZkSolrResourceLoader.java |
38 |
Private field 'zkController' could be made final; it is only initialized in the declaration or constructor. |
| 185 |
org/apache/solr/cloud/ZkSolrResourceLoader.java |
120 |
This call to Collection.toArray() may be optimizable |
| 186 |
org/apache/solr/core/AbstractSolrEventListener.java |
68 |
Avoid if (x != y) ..; else ..; |
| 187 |
org/apache/solr/core/CachingDirectoryFactory.java |
127 |
Deeply nested if..then statements are hard to read |
| 188 |
org/apache/solr/core/CachingDirectoryFactory.java |
170 |
An empty method in an abstract class should be abstract instead |
| 189 |
org/apache/solr/core/CachingDirectoryFactory.java |
170 |
Document empty method |
| 190 |
org/apache/solr/core/CachingDirectoryFactory.java |
195 |
Avoid reassigning parameters such as 'rawLockType' |
| 191 |
org/apache/solr/core/CodecFactory.java |
29 |
An empty method in an abstract class should be abstract instead |
| 192 |
org/apache/solr/core/CodecFactory.java |
29 |
Document empty method |
| 193 |
org/apache/solr/core/Config.java |
99 |
Avoid reassigning parameters such as 'is' |
| 194 |
org/apache/solr/core/Config.java |
99 |
Avoid reassigning parameters such as 'loader' |
| 195 |
org/apache/solr/core/Config.java |
106 |
Avoid if (x != y) ..; else ..; |
| 196 |
org/apache/solr/core/Config.java |
199 |
Consider simply returning the value vs storing it in local variable 'o' |
| 197 |
org/apache/solr/core/Config.java |
274 |
Avoid if (x != y) ..; else ..; |
| 198 |
org/apache/solr/core/Config.java |
283 |
Avoid if (x != y) ..; else ..; |
| 199 |
org/apache/solr/core/Config.java |
292 |
Avoid if (x != y) ..; else ..; |
| 200 |
org/apache/solr/core/Config.java |
302 |
Avoid if (x != y) ..; else ..; |
| 201 |
org/apache/solr/core/Config.java |
311 |
Avoid if (x != y) ..; else ..; |
| 202 |
org/apache/solr/core/CoreContainer.java |
113 |
Private field 'solrXMLSerializer' could be made final; it is only initialized in the declaration or constructor. |
| 203 |
org/apache/solr/core/CoreContainer.java |
118 |
Perhaps 'zkHost' could be replaced by a local variable. |
| 204 |
org/apache/solr/core/CoreContainer.java |
119 |
Private field 'coreToOrigName' could be made final; it is only initialized in the declaration or constructor. |
| 205 |
org/apache/solr/core/CoreContainer.java |
122 |
Non-static initializers are confusing |
| 206 |
org/apache/solr/core/CoreContainer.java |
148 |
Overridable method 'load' called during object construction |
| 207 |
org/apache/solr/core/CoreContainer.java |
148 |
Overridable method 'load' called during object construction |
| 208 |
org/apache/solr/core/CoreContainer.java |
313 |
Avoid reassigning parameters such as 'file' |
| 209 |
org/apache/solr/core/CoreContainer.java |
363 |
Avoid reassigning parameters such as 'dir' |
| 210 |
org/apache/solr/core/CoreContainer.java |
600 |
Avoid reassigning parameters such as 'name' |
| 211 |
org/apache/solr/core/CoreContainer.java |
630 |
Use equals() to compare object references. |
| 212 |
org/apache/solr/core/CoreContainer.java |
730 |
Avoid if (x != y) ..; else ..; |
| 213 |
org/apache/solr/core/CoreContainer.java |
750 |
Avoid empty if statements |
| 214 |
org/apache/solr/core/CoreContainer.java |
756 |
Avoid if (x != y) ..; else ..; |
| 215 |
org/apache/solr/core/CoreContainer.java |
834 |
Avoid reassigning parameters such as 'name' |
| 216 |
org/apache/solr/core/CoreContainer.java |
899 |
Avoid reassigning parameters such as 'n0' |
| 217 |
org/apache/solr/core/CoreContainer.java |
899 |
Avoid reassigning parameters such as 'n1' |
| 218 |
org/apache/solr/core/CoreContainer.java |
926 |
Avoid reassigning parameters such as 'name' |
| 219 |
org/apache/solr/core/CoreContainer.java |
937 |
Avoid reassigning parameters such as 'name' |
| 220 |
org/apache/solr/core/CoreContainer.java |
961 |
Avoid reassigning parameters such as 'name' |
| 221 |
org/apache/solr/core/CoreContainer.java |
1060 |
Position literals first in String comparisons |
| 222 |
org/apache/solr/core/CoreContainer.java |
1076 |
Position literals first in String comparisons |
| 223 |
org/apache/solr/core/CoreContainer.java |
1276 |
Consider simply returning the value vs storing it in local variable 'schema' |
| 224 |
org/apache/solr/core/CoreDescriptor.java |
42 |
Avoid reassigning parameters such as 'instanceDir' |
| 225 |
org/apache/solr/core/CoreDescriptor.java |
61 |
Overridable method 'getDefaultConfigName' called during object construction |
| 226 |
org/apache/solr/core/CoreDescriptor.java |
62 |
Overridable method 'getDefaultSchemaName' called during object construction |
| 227 |
org/apache/solr/core/IndexDeletionPolicyWrapper.java |
107 |
Use block level rather than method level synchronization |
| 228 |
org/apache/solr/core/IndexDeletionPolicyWrapper.java |
115 |
Use block level rather than method level synchronization |
| 229 |
org/apache/solr/core/IndexDeletionPolicyWrapper.java |
239 |
Avoid if (x != y) ..; else ..; |
| 230 |
org/apache/solr/core/JmxMonitoredMap.java |
54 |
Private field 'jmxRootName' could be made final; it is only initialized in the declaration or constructor. |
| 231 |
org/apache/solr/core/JmxMonitoredMap.java |
56 |
Private field 'coreHashCode' could be made final; it is only initialized in the declaration or constructor. |
| 232 |
org/apache/solr/core/JmxMonitoredMap.java |
61 |
Avoid if (x != y) ..; else ..; |
| 233 |
org/apache/solr/core/JmxMonitoredMap.java |
63 |
Avoid if (x != y) ..; else ..; |
| 234 |
org/apache/solr/core/JmxMonitoredMap.java |
194 |
Private field 'infoBean' could be made final; it is only initialized in the declaration or constructor. |
| 235 |
org/apache/solr/core/JmxMonitoredMap.java |
196 |
Private field 'staticStats' could be made final; it is only initialized in the declaration or constructor. |
| 236 |
org/apache/solr/core/JmxMonitoredMap.java |
198 |
Private field 'coreHashCode' could be made final; it is only initialized in the declaration or constructor. |
| 237 |
org/apache/solr/core/JmxMonitoredMap.java |
260 |
New exception is thrown in catch block, original stack trace may be lost |
| 238 |
org/apache/solr/core/JmxMonitoredMap.java |
267 |
Avoid if (x != y) ..; else ..; |
| 239 |
org/apache/solr/core/QuerySenderListener.java |
58 |
Document empty method |
| 240 |
org/apache/solr/core/QuerySenderListener.java |
79 |
Avoid empty catch blocks |
| 241 |
org/apache/solr/core/RAMDirectoryFactory.java |
45 |
Avoid unnecessary if..then..else statements when returning a boolean |
| 242 |
org/apache/solr/core/RequestHandlers.java |
44 |
Avoid protected fields in a final class. Change to private or package access. |
| 243 |
org/apache/solr/core/RequestHandlers.java |
146 |
Avoid if (x != y) ..; else ..; |
| 244 |
org/apache/solr/core/RequestHandlers.java |
213 |
Private field '_className' could be made final; it is only initialized in the declaration or constructor. |
| 245 |
org/apache/solr/core/RequestHandlers.java |
214 |
Private field '_args' could be made final; it is only initialized in the declaration or constructor. |
| 246 |
org/apache/solr/core/RequestHandlers.java |
243 |
Use block level rather than method level synchronization |
| 247 |
org/apache/solr/core/SolrConfig.java |
194 |
Avoid instantiation through private constructors from outside of the constructor's class. |
| 248 |
org/apache/solr/core/SolrConfig.java |
197 |
Avoid if (x != y) ..; else ..; |
| 249 |
org/apache/solr/core/SolrConfig.java |
208 |
Overridable method 'readPluginInfos' called during object construction |
| 250 |
org/apache/solr/core/SolrConfig.java |
209 |
Overridable method 'readPluginInfos' called during object construction |
| 251 |
org/apache/solr/core/SolrConfig.java |
210 |
Overridable method 'readPluginInfos' called during object construction |
| 252 |
org/apache/solr/core/SolrConfig.java |
211 |
Overridable method 'readPluginInfos' called during object construction |
| 253 |
org/apache/solr/core/SolrConfig.java |
212 |
Overridable method 'readPluginInfos' called during object construction |
| 254 |
org/apache/solr/core/SolrConfig.java |
213 |
Overridable method 'readPluginInfos' called during object construction |
| 255 |
org/apache/solr/core/SolrConfig.java |
214 |
Overridable method 'readPluginInfos' called during object construction |
| 256 |
org/apache/solr/core/SolrConfig.java |
220 |
Overridable method 'readPluginInfos' called during object construction |
| 257 |
org/apache/solr/core/SolrConfig.java |
222 |
Overridable method 'readPluginInfos' called during object construction |
| 258 |
org/apache/solr/core/SolrConfig.java |
223 |
Overridable method 'readPluginInfos' called during object construction |
| 259 |
org/apache/solr/core/SolrConfig.java |
224 |
Overridable method 'readPluginInfos' called during object construction |
| 260 |
org/apache/solr/core/SolrConfig.java |
225 |
Overridable method 'readPluginInfos' called during object construction |
| 261 |
org/apache/solr/core/SolrConfig.java |
226 |
Overridable method 'readPluginInfos' called during object construction |
| 262 |
org/apache/solr/core/SolrConfig.java |
227 |
Overridable method 'readPluginInfos' called during object construction |
| 263 |
org/apache/solr/core/SolrConfig.java |
229 |
Overridable method 'loadUpdatehandlerInfo' called during object construction |
| 264 |
org/apache/solr/core/SolrConfig.java |
290 |
Private field 'pluginStore' could be made final; it is only initialized in the declaration or constructor. |
| 265 |
org/apache/solr/core/SolrConfig.java |
378 |
Avoid if (x != y) ..; else ..; |
| 266 |
org/apache/solr/core/SolrConfig.java |
461 |
Avoid if (x != y) ..; else ..; |
| 267 |
org/apache/solr/core/SolrConfig.java |
466 |
Avoid if (x != y) ..; else ..; |
| 268 |
org/apache/solr/core/SolrCore.java |
189 |
Avoid empty catch blocks |
| 269 |
org/apache/solr/core/SolrCore.java |
241 |
Avoid if (x != y) ..; else ..; |
| 270 |
org/apache/solr/core/SolrCore.java |
333 |
Avoid if (x != y) ..; else ..; |
| 271 |
org/apache/solr/core/SolrCore.java |
346 |
Avoid if (x != y) ..; else ..; |
| 272 |
org/apache/solr/core/SolrCore.java |
410 |
Avoid reassigning parameters such as 'msg' |
| 273 |
org/apache/solr/core/SolrCore.java |
435 |
Avoid reassigning parameters such as 'msg' |
| 274 |
org/apache/solr/core/SolrCore.java |
517 |
Avoid reassigning parameters such as 'dataDir' |
| 275 |
org/apache/solr/core/SolrCore.java |
517 |
Avoid reassigning parameters such as 'dataDir' |
| 276 |
org/apache/solr/core/SolrCore.java |
517 |
Avoid reassigning parameters such as 'dataDir' |
| 277 |
org/apache/solr/core/SolrCore.java |
517 |
Avoid reassigning parameters such as 'schema' |
| 278 |
org/apache/solr/core/SolrCore.java |
644 |
Avoid if (x != y) ..; else ..; |
| 279 |
org/apache/solr/core/SolrCore.java |
692 |
Unnecessary final modifier in final class |
| 280 |
org/apache/solr/core/SolrCore.java |
990 |
Private field 'searcherLock' could be made final; it is only initialized in the declaration or constructor. |
| 281 |
org/apache/solr/core/SolrCore.java |
991 |
Private field 'openSearcherLock' could be made final; it is only initialized in the declaration or constructor. |
| 282 |
org/apache/solr/core/SolrCore.java |
1324 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 283 |
org/apache/solr/core/SolrCore.java |
1341 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 284 |
org/apache/solr/core/SolrCore.java |
1393 |
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. |
| 285 |
org/apache/solr/core/SolrCore.java |
1407 |
Call Thread.notifyAll() rather than Thread.notify() |
| 286 |
org/apache/solr/core/SolrCore.java |
1613 |
Unnecessary final modifier in final class |
| 287 |
org/apache/solr/core/SolrCore.java |
1646 |
Avoid if (x != y) ..; else ..; |
| 288 |
org/apache/solr/core/SolrCore.java |
1704 |
Unnecessary final modifier in final class |
| 289 |
org/apache/solr/core/SolrCore.java |
1717 |
Unnecessary final modifier in final class |
| 290 |
org/apache/solr/core/SolrCore.java |
1923 |
Return an empty array rather than null. |
| 291 |
org/apache/solr/core/SolrCore.java |
1944 |
Private field '_core' could be made final; it is only initialized in the declaration or constructor. |
| 292 |
org/apache/solr/core/SolrCore.java |
1945 |
Private field '_className' could be made final; it is only initialized in the declaration or constructor. |
| 293 |
org/apache/solr/core/SolrCore.java |
1946 |
Private field '_args' could be made final; it is only initialized in the declaration or constructor. |
| 294 |
org/apache/solr/core/SolrCore.java |
1956 |
Use block level rather than method level synchronization |
| 295 |
org/apache/solr/core/SolrResourceLoader.java |
109 |
Overridable method 'addToClassLoader' called during object construction |
| 296 |
org/apache/solr/core/SolrResourceLoader.java |
197 |
Avoid reassigning parameters such as 'parent' |
| 297 |
org/apache/solr/core/SolrResourceLoader.java |
212 |
Avoid if (x != y) ..; else ..; |
| 298 |
org/apache/solr/core/SolrResourceLoader.java |
281 |
Use equals() to compare object references. |
| 299 |
org/apache/solr/core/SolrResourceLoader.java |
282 |
These nested if statements could be combined |
| 300 |
org/apache/solr/core/SolrResourceLoader.java |
381 |
Avoid reassigning parameters such as 'subpackages' |
| 301 |
org/apache/solr/core/SolrResourceLoader.java |
409 |
Avoid empty catch blocks |
| 302 |
org/apache/solr/core/SolrResourceLoader.java |
481 |
These nested if statements could be combined |
| 303 |
org/apache/solr/core/SolrResourceLoader.java |
540 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 304 |
org/apache/solr/core/SolrResourceLoader.java |
564 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 305 |
org/apache/solr/core/SolrXMLSerializer.java |
136 |
Avoid using java.lang.ThreadGroup; it is not thread safe |
| 306 |
org/apache/solr/core/SolrXMLSerializer.java |
155 |
These nested if statements could be combined |
| 307 |
org/apache/solr/core/SolrXMLSerializer.java |
188 |
Avoid empty catch blocks |
| 308 |
org/apache/solr/core/SolrXMLSerializer.java |
192 |
Avoid empty catch blocks |
| 309 |
org/apache/solr/core/SolrXMLSerializer.java |
196 |
Avoid empty catch blocks |
| 310 |
org/apache/solr/core/SolrXMLSerializer.java |
200 |
Avoid empty catch blocks |
| 311 |
org/apache/solr/handler/AnalysisRequestHandlerBase.java |
194 |
Non-static initializers are confusing |
| 312 |
org/apache/solr/handler/AnalysisRequestHandlerBase.java |
260 |
Avoid reassigning parameters such as 'value' |
| 313 |
org/apache/solr/handler/BinaryUpdateRequestHandler.java |
81 |
New exception is thrown in catch block, original stack trace may be lost |
| 314 |
org/apache/solr/handler/BinaryUpdateRequestHandler.java |
93 |
New exception is thrown in catch block, original stack trace may be lost |
| 315 |
org/apache/solr/handler/CSVRequestHandler.java |
152 |
Avoid reassigning parameters such as 'val' |
| 316 |
org/apache/solr/handler/CSVRequestHandler.java |
174 |
Avoid if (x != y) ..; else ..; |
| 317 |
org/apache/solr/handler/CSVRequestHandler.java |
207 |
These nested if statements could be combined |
| 318 |
org/apache/solr/handler/CSVRequestHandler.java |
212 |
These nested if statements could be combined |
| 319 |
org/apache/solr/handler/CSVRequestHandler.java |
236 |
Avoid if (x != y) ..; else ..; |
| 320 |
org/apache/solr/handler/CSVRequestHandler.java |
254 |
Overridable method 'prepareFields' called during object construction |
| 321 |
org/apache/solr/handler/CSVRequestHandler.java |
337 |
Avoid if (x != y) ..; else ..; |
| 322 |
org/apache/solr/handler/DocumentAnalysisRequestHandler.java |
165 |
A switch with less than 3 branches is inefficient, use a if statement instead. |
| 323 |
org/apache/solr/handler/DocumentAnalysisRequestHandler.java |
165 |
Switch statements should have a default label |
| 324 |
org/apache/solr/handler/DocumentAnalysisRequestHandler.java |
233 |
Avoid empty catch blocks |
| 325 |
org/apache/solr/handler/DocumentAnalysisRequestHandler.java |
286 |
Switch statements should have a default label |
| 326 |
org/apache/solr/handler/FieldAnalysisRequestHandler.java |
152 |
Avoid empty catch blocks |
| 327 |
org/apache/solr/handler/JsonLoader.java |
324 |
Avoid reassigning parameters such as 'ev' |
| 328 |
org/apache/solr/handler/JsonLoader.java |
324 |
Avoid reassigning parameters such as 'ev' |
| 329 |
org/apache/solr/handler/JsonLoader.java |
413 |
Avoid empty if statements |
| 330 |
org/apache/solr/handler/JsonLoader.java |
426 |
Avoid empty if statements |
| 331 |
org/apache/solr/handler/JsonUpdateRequestHandler.java |
34 |
Overriding method merely calls super |
| 332 |
org/apache/solr/handler/MoreLikeThisHandler.java |
70 |
Overriding method merely calls super |
| 333 |
org/apache/solr/handler/MoreLikeThisHandler.java |
133 |
Deeply nested if..then statements are hard to read |
| 334 |
org/apache/solr/handler/MoreLikeThisHandler.java |
136 |
Deeply nested if..then statements are hard to read |
| 335 |
org/apache/solr/handler/MoreLikeThisHandler.java |
148 |
Avoid if (x != y) ..; else ..; |
| 336 |
org/apache/solr/handler/MoreLikeThisHandler.java |
151 |
Avoid if (x != y) ..; else ..; |
| 337 |
org/apache/solr/handler/MoreLikeThisHandler.java |
218 |
Avoid unnecessary comparisons in boolean expressions |
| 338 |
org/apache/solr/handler/MoreLikeThisHandler.java |
234 |
Avoid unnecessary comparisons in boolean expressions |
| 339 |
org/apache/solr/handler/MoreLikeThisHandler.java |
330 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 340 |
org/apache/solr/handler/RealTimeGetHandler.java |
49 |
Return an empty array rather than null. |
| 341 |
org/apache/solr/handler/ReplicationHandler.java |
94 |
Private field 'snapPullLock' could be made final; it is only initialized in the declaration or constructor. |
| 342 |
org/apache/solr/handler/ReplicationHandler.java |
98 |
Private field 'confFileNameAlias' could be made final; it is only initialized in the declaration or constructor. |
| 343 |
org/apache/solr/handler/ReplicationHandler.java |
122 |
Private field 'replicationEnabled' could be made final; it is only initialized in the declaration or constructor. |
| 344 |
org/apache/solr/handler/ReplicationHandler.java |
184 |
Avoid if (x != y) ..; else ..; |
| 345 |
org/apache/solr/handler/ReplicationHandler.java |
192 |
Avoid if (x != y) ..; else ..; |
| 346 |
org/apache/solr/handler/ReplicationHandler.java |
201 |
Avoid if (x != y) ..; else ..; |
| 347 |
org/apache/solr/handler/ReplicationHandler.java |
618 |
Avoid if (x != y) ..; else ..; |
| 348 |
org/apache/solr/handler/ReplicationHandler.java |
738 |
Avoid empty catch blocks |
| 349 |
org/apache/solr/handler/ReplicationHandler.java |
801 |
Avoid if (x != y) ..; else ..; |
| 350 |
org/apache/solr/handler/ReplicationHandler.java |
876 |
These nested if statements could be combined |
| 351 |
org/apache/solr/handler/ReplicationHandler.java |
882 |
Avoid empty finally blocks |
| 352 |
org/apache/solr/handler/ReplicationHandler.java |
934 |
Document empty method |
| 353 |
org/apache/solr/handler/ReplicationHandler.java |
1008 |
Document empty method |
| 354 |
org/apache/solr/handler/ReplicationHandler.java |
1015 |
Private field 'params' could be made final; it is only initialized in the declaration or constructor. |
| 355 |
org/apache/solr/handler/ReplicationHandler.java |
1020 |
Private field 'delPolicy' could be made final; it is only initialized in the declaration or constructor. |
| 356 |
org/apache/solr/handler/ReplicationHandler.java |
1058 |
Avoid if (x != y) ..; else ..; |
| 357 |
org/apache/solr/handler/RequestHandlerBase.java |
99 |
No need to check for null before an instanceof |
| 358 |
org/apache/solr/handler/RequestHandlerBase.java |
103 |
No need to check for null before an instanceof |
| 359 |
org/apache/solr/handler/RequestHandlerBase.java |
107 |
No need to check for null before an instanceof |
| 360 |
org/apache/solr/handler/RequestHandlerBase.java |
114 |
Avoid if (x != y) ..; else ..; |
| 361 |
org/apache/solr/handler/RequestHandlerBase.java |
142 |
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. |
| 362 |
org/apache/solr/handler/RequestHandlerBase.java |
169 |
An empty method in an abstract class should be abstract instead |
| 363 |
org/apache/solr/handler/RequestHandlerBase.java |
169 |
Return an empty array rather than null. |
| 364 |
org/apache/solr/handler/RequestHandlerUtils.java |
40 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 365 |
org/apache/solr/handler/RequestHandlerUtils.java |
54 |
Avoid reassigning parameters such as 'params' |
| 366 |
org/apache/solr/handler/RequestHandlerUtils.java |
109 |
Avoid reassigning parameters such as 'params' |
| 367 |
org/apache/solr/handler/SnapPuller.java |
83 |
Private field 'pollIntervalStr' could be made final; it is only initialized in the declaration or constructor. |
| 368 |
org/apache/solr/handler/SnapPuller.java |
109 |
Private field 'useInternal' could be made final; it is only initialized in the declaration or constructor. |
| 369 |
org/apache/solr/handler/SnapPuller.java |
111 |
Private field 'useExternal' could be made final; it is only initialized in the declaration or constructor. |
| 370 |
org/apache/solr/handler/SnapPuller.java |
116 |
Private field 'pollDisabled' could be made final; it is only initialized in the declaration or constructor. |
| 371 |
org/apache/solr/handler/SnapPuller.java |
123 |
Use block level rather than method level synchronization |
| 372 |
org/apache/solr/handler/SnapPuller.java |
234 |
Avoid empty catch blocks |
| 373 |
org/apache/solr/handler/SnapPuller.java |
259 |
Avoid if (x != y) ..; else ..; |
| 374 |
org/apache/solr/handler/SnapPuller.java |
359 |
Avoid if (x != y) ..; else ..; |
| 375 |
org/apache/solr/handler/SnapPuller.java |
393 |
New exception is thrown in catch block, original stack trace may be lost |
| 376 |
org/apache/solr/handler/SnapPuller.java |
502 |
These nested if statements could be combined |
| 377 |
org/apache/solr/handler/SnapPuller.java |
703 |
These nested if statements could be combined |
| 378 |
org/apache/solr/handler/SnapPuller.java |
724 |
Avoid empty if statements |
| 379 |
org/apache/solr/handler/SnapPuller.java |
920 |
Private field 'copy2Dir' could be made final; it is only initialized in the declaration or constructor. |
| 380 |
org/apache/solr/handler/SnapPuller.java |
932 |
Private field 'fileOutputStream' could be made final; it is only initialized in the declaration or constructor. |
| 381 |
org/apache/solr/handler/SnapPuller.java |
942 |
Private field 'isConf' could be made final; it is only initialized in the declaration or constructor. |
| 382 |
org/apache/solr/handler/SnapPuller.java |
948 |
Private field 'indexGen' could be made final; it is only initialized in the declaration or constructor. |
| 383 |
org/apache/solr/handler/SnapPuller.java |
1171 |
Avoid reassigning parameters such as 'respBody' |
| 384 |
org/apache/solr/handler/SnapPuller.java |
1171 |
Avoid reassigning parameters such as 'respBody' |
| 385 |
org/apache/solr/handler/SnapPuller.java |
1171 |
Avoid reassigning parameters such as 'respBody' |
| 386 |
org/apache/solr/handler/SnapPuller.java |
1171 |
Avoid reassigning parameters such as 'respBody' |
| 387 |
org/apache/solr/handler/SnapPuller.java |
1173 |
Avoid if (x != y) ..; else ..; |
| 388 |
org/apache/solr/handler/SnapPuller.java |
1216 |
New exception is thrown in catch block, original stack trace may be lost |
| 389 |
org/apache/solr/handler/SnapShooter.java |
53 |
Private field 'solrCore' could be made final; it is only initialized in the declaration or constructor. |
| 390 |
org/apache/solr/handler/SnapShooter.java |
54 |
Private field 'lockFactory' could be made final; it is only initialized in the declaration or constructor. |
| 391 |
org/apache/solr/handler/SnapShooter.java |
154 |
When instantiating a SimpleDateFormat object, specify a Locale |
| 392 |
org/apache/solr/handler/SnapShooter.java |
173 |
Private field 'buffer' could be made final; it is only initialized in the declaration or constructor. |
| 393 |
org/apache/solr/handler/SnapShooter.java |
174 |
Private field 'indexCommit' could be made final; it is only initialized in the declaration or constructor. |
| 394 |
org/apache/solr/handler/SnapShooter.java |
175 |
Private field 'delPolicy' could be made final; it is only initialized in the declaration or constructor. |
| 395 |
org/apache/solr/handler/XMLLoader.java |
102 |
A high ratio of statements to labels in a switch statement. Consider refactoring. |
| 396 |
org/apache/solr/handler/XMLLoader.java |
102 |
A switch with less than 3 branches is inefficient, use a if statement instead. |
| 397 |
org/apache/solr/handler/XMLLoader.java |
102 |
Switch statements should have a default label |
| 398 |
org/apache/solr/handler/XMLLoader.java |
131 |
Avoid if (x != y) ..; else ..; |
| 399 |
org/apache/solr/handler/XMLLoader.java |
187 |
Avoid empty if statements |
| 400 |
org/apache/solr/handler/XMLLoader.java |
189 |
Avoid empty if statements |
| 401 |
org/apache/solr/handler/XMLLoader.java |
201 |
Switch statements should have a default label |
| 402 |
org/apache/solr/handler/XMLLoader.java |
274 |
Switch statements should have a default label |
| 403 |
org/apache/solr/handler/XMLLoader.java |
286 |
These nested if statements could be combined |
| 404 |
org/apache/solr/handler/admin/AdminHandlers.java |
128 |
Return an empty array rather than null. |
| 405 |
org/apache/solr/handler/admin/CoreAdminHandler.java |
78 |
Perhaps 'shardHandlerFactory' could be replaced by a local variable. |
| 406 |
org/apache/solr/handler/admin/CoreAdminHandler.java |
139 |
The default label should be the last label in a switch statement |
| 407 |
org/apache/solr/handler/admin/CoreAdminHandler.java |
254 |
Avoid if (x != y) ..; else ..; |
| 408 |
org/apache/solr/handler/admin/CoreAdminHandler.java |
329 |
These nested if statements could be combined |
| 409 |
org/apache/solr/handler/admin/CoreAdminHandler.java |
491 |
Document empty method |
| 410 |
org/apache/solr/handler/admin/CoreAdminHandler.java |
497 |
Avoid if (x != y) ..; else ..; |
| 411 |
org/apache/solr/handler/admin/CoreAdminHandler.java |
567 |
Avoid if (x != y) ..; else ..; |
| 412 |
org/apache/solr/handler/admin/CoreAdminHandler.java |
572 |
Avoid if (x != y) ..; else ..; |
| 413 |
org/apache/solr/handler/admin/CoreAdminHandler.java |
632 |
Avoid if (x != y) ..; else ..; |
| 414 |
org/apache/solr/handler/admin/CoreAdminHandler.java |
837 |
Avoid reassigning parameters such as 'path' |
| 415 |
org/apache/solr/handler/admin/CoreAdminHandler.java |
837 |
Avoid reassigning parameters such as 'path' |
| 416 |
org/apache/solr/handler/admin/LogLevelHandler.java |
136 |
Avoid reassigning parameters such as 'category' |
| 417 |
org/apache/solr/handler/admin/LogLevelHandler.java |
165 |
Use equals() to compare object references. |
| 418 |
org/apache/solr/handler/admin/LogLevelHandler.java |
291 |
Avoid reassigning parameters such as 'category' |
| 419 |
org/apache/solr/handler/admin/LogLevelHandler.java |
328 |
Use equals() to compare object references. |
| 420 |
org/apache/solr/handler/admin/LogLevelHandler.java |
375 |
Avoid empty catch blocks |
| 421 |
org/apache/solr/handler/admin/LukeRequestHandler.java |
137 |
Avoid if (x != y) ..; else ..; |
| 422 |
org/apache/solr/handler/admin/LukeRequestHandler.java |
145 |
Avoid empty catch blocks |
| 423 |
org/apache/solr/handler/admin/LukeRequestHandler.java |
200 |
Avoid if (x != y) ..; else ..; |
| 424 |
org/apache/solr/handler/admin/LukeRequestHandler.java |
263 |
Avoid if (x != y) ..; else ..; |
| 425 |
org/apache/solr/handler/admin/LukeRequestHandler.java |
359 |
Avoid if (x != y) ..; else ..; |
| 426 |
org/apache/solr/handler/admin/LukeRequestHandler.java |
516 |
Use equals() to compare object references. |
| 427 |
org/apache/solr/handler/admin/PluginInfoHandler.java |
70 |
Avoid if (x != y) ..; else ..; |
| 428 |
org/apache/solr/handler/admin/PluginInfoHandler.java |
71 |
Avoid if (x != y) ..; else ..; |
| 429 |
org/apache/solr/handler/admin/PluginInfoHandler.java |
72 |
Avoid if (x != y) ..; else ..; |
| 430 |
org/apache/solr/handler/admin/PluginInfoHandler.java |
73 |
Avoid if (x != y) ..; else ..; |
| 431 |
org/apache/solr/handler/admin/PropertiesRequestHandler.java |
38 |
Avoid if (x != y) ..; else ..; |
| 432 |
org/apache/solr/handler/admin/ShowFileRequestHandler.java |
158 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 433 |
org/apache/solr/handler/admin/ShowFileRequestHandler.java |
172 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 434 |
org/apache/solr/handler/admin/ShowFileRequestHandler.java |
209 |
New exception is thrown in catch block, original stack trace may be lost |
| 435 |
org/apache/solr/handler/admin/SolrInfoMBeanHandler.java |
72 |
New exception is thrown in catch block, original stack trace may be lost |
| 436 |
org/apache/solr/handler/admin/SystemInfoHandler.java |
65 |
Private field 'hostname' could be made final; it is only initialized in the declaration or constructor. |
| 437 |
org/apache/solr/handler/admin/SystemInfoHandler.java |
72 |
Avoid empty catch blocks |
| 438 |
org/apache/solr/handler/admin/SystemInfoHandler.java |
95 |
Avoid if (x != y) ..; else ..; |
| 439 |
org/apache/solr/handler/admin/SystemInfoHandler.java |
175 |
Avoid empty catch blocks |
| 440 |
org/apache/solr/handler/component/DebugComponent.java |
46 |
Document empty method |
| 441 |
org/apache/solr/handler/component/DebugComponent.java |
94 |
Avoid if (x != y) ..; else ..; |
| 442 |
org/apache/solr/handler/component/DebugComponent.java |
111 |
Document empty method |
| 443 |
org/apache/solr/handler/component/DebugComponent.java |
114 |
Private field 'excludeSet' could be made final; it is only initialized in the declaration or constructor. |
| 444 |
org/apache/solr/handler/component/DebugComponent.java |
165 |
Avoid reassigning parameters such as 'dest' |
| 445 |
org/apache/solr/handler/component/DebugComponent.java |
191 |
These nested if statements could be combined |
| 446 |
org/apache/solr/handler/component/DebugComponent.java |
214 |
Use equals() to compare object references. |
| 447 |
org/apache/solr/handler/component/DebugComponent.java |
257 |
Return an empty array rather than null. |
| 448 |
org/apache/solr/handler/component/FacetComponent.java |
85 |
Deeply nested if..then statements are hard to read |
| 449 |
org/apache/solr/handler/component/FacetComponent.java |
119 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 450 |
org/apache/solr/handler/component/FacetComponent.java |
130 |
Avoid if (x != y) ..; else ..; |
| 451 |
org/apache/solr/handler/component/FacetComponent.java |
205 |
Avoid if (x != y) ..; else ..; |
| 452 |
org/apache/solr/handler/component/FacetComponent.java |
275 |
Avoid if (x != y) ..; else ..; |
| 453 |
org/apache/solr/handler/component/FacetComponent.java |
341 |
Position literals first in String comparisons |
| 454 |
org/apache/solr/handler/component/FacetComponent.java |
342 |
Position literals first in String comparisons |
| 455 |
org/apache/solr/handler/component/FacetComponent.java |
343 |
Position literals first in String comparisons |
| 456 |
org/apache/solr/handler/component/FacetComponent.java |
600 |
Return an empty array rather than null. |
| 457 |
org/apache/solr/handler/component/FacetComponent.java |
715 |
Avoid if (x != y) ..; else ..; |
| 458 |
org/apache/solr/handler/component/HighlightComponent.java |
85 |
Avoid if (x != y) ..; else ..; |
| 459 |
org/apache/solr/handler/component/HighlightComponent.java |
107 |
Avoid if (x != y) ..; else ..; |
| 460 |
org/apache/solr/handler/component/HighlightComponent.java |
115 |
Avoid if (x != y) ..; else ..; |
| 461 |
org/apache/solr/handler/component/HighlightComponent.java |
154 |
Avoid if (x != y) ..; else ..; |
| 462 |
org/apache/solr/handler/component/HighlightComponent.java |
164 |
Document empty method |
| 463 |
org/apache/solr/handler/component/HighlightComponent.java |
211 |
Return an empty array rather than null. |
| 464 |
org/apache/solr/handler/component/HttpShardHandler.java |
60 |
Private field 'httpShardHandlerFactory' could be made final; it is only initialized in the declaration or constructor. |
| 465 |
org/apache/solr/handler/component/HttpShardHandler.java |
61 |
Private field 'completionService' could be made final; it is only initialized in the declaration or constructor. |
| 466 |
org/apache/solr/handler/component/HttpShardHandler.java |
62 |
Private field 'pending' could be made final; it is only initialized in the declaration or constructor. |
| 467 |
org/apache/solr/handler/component/HttpShardHandler.java |
63 |
Private field 'shardToURLs' could be made final; it is only initialized in the declaration or constructor. |
| 468 |
org/apache/solr/handler/component/HttpShardHandler.java |
64 |
Private field 'httpClient' could be made final; it is only initialized in the declaration or constructor. |
| 469 |
org/apache/solr/handler/component/HttpShardHandler.java |
155 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 470 |
org/apache/solr/handler/component/HttpShardHandler.java |
176 |
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. |
| 471 |
org/apache/solr/handler/component/HttpShardHandler.java |
209 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 472 |
org/apache/solr/handler/component/HttpShardHandler.java |
265 |
Avoid if (x != y) ..; else ..; |
| 473 |
org/apache/solr/handler/component/HttpShardHandler.java |
291 |
Avoid if (x != y) ..; else ..; |
| 474 |
org/apache/solr/handler/component/HttpShardHandlerFactory.java |
162 |
Avoid if (x != y) ..; else ..; |
| 475 |
org/apache/solr/handler/component/MoreLikeThisComponent.java |
46 |
Document empty method |
| 476 |
org/apache/solr/handler/component/MoreLikeThisComponent.java |
125 |
Return an empty array rather than null. |
| 477 |
org/apache/solr/handler/component/QueryComponent.java |
192 |
New exception is thrown in catch block, original stack trace may be lost |
| 478 |
org/apache/solr/handler/component/QueryComponent.java |
256 |
Deeply nested if..then statements are hard to read |
| 479 |
org/apache/solr/handler/component/QueryComponent.java |
310 |
Deeply nested if..then statements are hard to read |
| 480 |
org/apache/solr/handler/component/QueryComponent.java |
317 |
Deeply nested if..then statements are hard to read |
| 481 |
org/apache/solr/handler/component/QueryComponent.java |
403 |
Avoid if (x != y) ..; else ..; |
| 482 |
org/apache/solr/handler/component/QueryComponent.java |
620 |
Avoid if (x != y) ..; else ..; |
| 483 |
org/apache/solr/handler/component/QueryComponent.java |
622 |
Avoid if (x != y) ..; else ..; |
| 484 |
org/apache/solr/handler/component/QueryComponent.java |
761 |
Avoid if (x != y) ..; else ..; |
| 485 |
org/apache/solr/handler/component/QueryComponent.java |
792 |
Avoid if (x != y) ..; else ..; |
| 486 |
org/apache/solr/handler/component/QueryComponent.java |
1010 |
Return an empty array rather than null. |
| 487 |
org/apache/solr/handler/component/QueryElevationComponent.java |
160 |
Avoid unnecessary comparisons in boolean expressions |
| 488 |
org/apache/solr/handler/component/QueryElevationComponent.java |
167 |
Avoid unnecessary comparisons in boolean expressions |
| 489 |
org/apache/solr/handler/component/QueryElevationComponent.java |
185 |
Avoid if (x != y) ..; else ..; |
| 490 |
org/apache/solr/handler/component/QueryElevationComponent.java |
240 |
Avoid if (x != y) ..; else ..; |
| 491 |
org/apache/solr/handler/component/QueryElevationComponent.java |
267 |
New exception is thrown in catch block, original stack trace may be lost |
| 492 |
org/apache/solr/handler/component/QueryElevationComponent.java |
278 |
These nested if statements could be combined |
| 493 |
org/apache/solr/handler/component/QueryElevationComponent.java |
301 |
Avoid reassigning parameters such as 'ex' |
| 494 |
org/apache/solr/handler/component/QueryElevationComponent.java |
301 |
Avoid reassigning parameters such as 'ids' |
| 495 |
org/apache/solr/handler/component/QueryElevationComponent.java |
372 |
Avoid unnecessary comparisons in boolean expressions |
| 496 |
org/apache/solr/handler/component/QueryElevationComponent.java |
380 |
Avoid unnecessary comparisons in boolean expressions |
| 497 |
org/apache/solr/handler/component/QueryElevationComponent.java |
479 |
Private field 'elevations' could be made final; it is only initialized in the declaration or constructor. |
| 498 |
org/apache/solr/handler/component/QueryElevationComponent.java |
480 |
Private field 'ordSet' could be made final; it is only initialized in the declaration or constructor. |
| 499 |
org/apache/solr/handler/component/QueryElevationComponent.java |
545 |
Avoid unnecessary comparisons in boolean expressions |
| 500 |
org/apache/solr/handler/component/RealTimeGetComponent.java |
148 |
Deeply nested if..then statements are hard to read |
| 501 |
org/apache/solr/handler/component/RealTimeGetComponent.java |
406 |
Return an empty array rather than null. |
| 502 |
org/apache/solr/handler/component/SearchComponent.java |
62 |
An empty method in an abstract class should be abstract instead |
| 503 |
org/apache/solr/handler/component/SearchComponent.java |
62 |
Document empty method |
| 504 |
org/apache/solr/handler/component/SearchComponent.java |
66 |
An empty method in an abstract class should be abstract instead |
| 505 |
org/apache/solr/handler/component/SearchComponent.java |
66 |
Document empty method |
| 506 |
org/apache/solr/handler/component/SearchComponent.java |
72 |
An empty method in an abstract class should be abstract instead |
| 507 |
org/apache/solr/handler/component/SearchComponent.java |
72 |
Document empty method |
| 508 |
org/apache/solr/handler/component/SearchComponent.java |
77 |
An empty method in an abstract class should be abstract instead |
| 509 |
org/apache/solr/handler/component/SearchComponent.java |
99 |
An empty method in an abstract class should be abstract instead |
| 510 |
org/apache/solr/handler/component/SearchComponent.java |
99 |
Return an empty array rather than null. |
| 511 |
org/apache/solr/handler/component/SearchComponent.java |
103 |
An empty method in an abstract class should be abstract instead |
| 512 |
org/apache/solr/handler/component/SearchHandler.java |
125 |
Avoid unnecessary comparisons in boolean expressions |
| 513 |
org/apache/solr/handler/component/SearchHandler.java |
132 |
Avoid unnecessary comparisons in boolean expressions |
| 514 |
org/apache/solr/handler/component/SearchHandler.java |
146 |
Document empty method |
| 515 |
org/apache/solr/handler/component/SearchHandler.java |
170 |
Avoid unnecessary comparisons in boolean expressions |
| 516 |
org/apache/solr/handler/component/SearchHandler.java |
196 |
Avoid if (x != y) ..; else ..; |
| 517 |
org/apache/solr/handler/component/SearchHandler.java |
201 |
Avoid if (x != y) ..; else ..; |
| 518 |
org/apache/solr/handler/component/SearchHandler.java |
293 |
These nested if statements could be combined |
| 519 |
org/apache/solr/handler/component/ShardDoc.java |
77 |
Avoid if (x != y) ..; else ..; |
| 520 |
org/apache/solr/handler/component/ShardDoc.java |
84 |
Avoid if (x != y) ..; else ..; |
| 521 |
org/apache/solr/handler/component/ShardDoc.java |
126 |
Overridable method 'getCachedComparator' called during object construction |
| 522 |
org/apache/solr/handler/component/ShardDoc.java |
257 |
Use equals() to compare object references. |
| 523 |
org/apache/solr/handler/component/ShardDoc.java |
279 |
Use equals() to compare object references. |
| 524 |
org/apache/solr/handler/component/ShardDoc.java |
299 |
Use equals() to compare object references. |
| 525 |
org/apache/solr/handler/component/ShardResponse.java |
26 |
Perhaps 'rspCode' could be replaced by a local variable. |
| 526 |
org/apache/solr/handler/component/SpellCheckComponent.java |
126 |
Avoid if (x != y) ..; else ..; |
| 527 |
org/apache/solr/handler/component/SpellCheckComponent.java |
136 |
Avoid unnecessary comparisons in boolean expressions |
| 528 |
org/apache/solr/handler/component/SpellCheckComponent.java |
137 |
Avoid if (x != y) ..; else ..; |
| 529 |
org/apache/solr/handler/component/SpellCheckComponent.java |
229 |
Avoid if (x != y) ..; else ..; |
| 530 |
org/apache/solr/handler/component/SpellCheckComponent.java |
367 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 531 |
org/apache/solr/handler/component/SpellCheckComponent.java |
472 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 532 |
org/apache/solr/handler/component/SpellCheckComponent.java |
509 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 533 |
org/apache/solr/handler/component/SpellCheckComponent.java |
529 |
Avoid if (x != y) ..; else ..; |
| 534 |
org/apache/solr/handler/component/SpellCheckComponent.java |
531 |
Avoid if (x != y) ..; else ..; |
| 535 |
org/apache/solr/handler/component/SpellCheckComponent.java |
533 |
Avoid unnecessary comparisons in boolean expressions |
| 536 |
org/apache/solr/handler/component/SpellCheckComponent.java |
533 |
Avoid unnecessary comparisons in boolean expressions |
| 537 |
org/apache/solr/handler/component/SpellCheckComponent.java |
535 |
Avoid unnecessary comparisons in boolean expressions |
| 538 |
org/apache/solr/handler/component/SpellCheckComponent.java |
535 |
Avoid unnecessary comparisons in boolean expressions |
| 539 |
org/apache/solr/handler/component/SpellCheckComponent.java |
540 |
Avoid unnecessary comparisons in boolean expressions |
| 540 |
org/apache/solr/handler/component/SpellCheckComponent.java |
565 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 541 |
org/apache/solr/handler/component/SpellCheckComponent.java |
597 |
Document empty method |
| 542 |
org/apache/solr/handler/component/SpellCheckComponent.java |
636 |
Document empty method |
| 543 |
org/apache/solr/handler/component/SpellCheckComponent.java |
640 |
Document empty method |
| 544 |
org/apache/solr/handler/component/StatsComponent.java |
83 |
Avoid if (x != y) ..; else ..; |
| 545 |
org/apache/solr/handler/component/StatsComponent.java |
134 |
Avoid if (x != y) ..; else ..; |
| 546 |
org/apache/solr/handler/component/StatsComponent.java |
229 |
Avoid unnecessary comparisons in boolean expressions |
| 547 |
org/apache/solr/handler/component/StatsValuesFactory.java |
33 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 548 |
org/apache/solr/handler/component/TermVectorComponent.java |
130 |
Avoid if (x != y) ..; else ..; |
| 549 |
org/apache/solr/handler/component/TermVectorComponent.java |
180 |
Avoid if (x != y) ..; else ..; |
| 550 |
org/apache/solr/handler/component/TermVectorComponent.java |
236 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 551 |
org/apache/solr/handler/component/TermVectorComponent.java |
243 |
Avoid if (x != y) ..; else ..; |
| 552 |
org/apache/solr/handler/component/TermVectorComponent.java |
279 |
Avoid unnecessary comparisons in boolean expressions |
| 553 |
org/apache/solr/handler/component/TermVectorComponent.java |
399 |
Document empty method |
| 554 |
org/apache/solr/handler/component/TermVectorComponent.java |
411 |
Document empty method |
| 555 |
org/apache/solr/handler/component/TermsComponent.java |
115 |
Avoid if (x != y) ..; else ..; |
| 556 |
org/apache/solr/handler/component/TermsComponent.java |
165 |
Avoid if (x != y) ..; else ..; |
| 557 |
org/apache/solr/handler/component/TermsComponent.java |
171 |
Avoid unnecessary comparisons in boolean expressions |
| 558 |
org/apache/solr/handler/component/TermsComponent.java |
247 |
New exception is thrown in catch block, original stack trace may be lost |
| 559 |
org/apache/solr/handler/component/TermsComponent.java |
325 |
Private field 'fieldmap' could be made final; it is only initialized in the declaration or constructor. |
| 560 |
org/apache/solr/highlight/BreakIteratorBoundaryScanner.java |
48 |
Position literals first in String comparisons |
| 561 |
org/apache/solr/highlight/BreakIteratorBoundaryScanner.java |
51 |
Position literals first in String comparisons |
| 562 |
org/apache/solr/highlight/BreakIteratorBoundaryScanner.java |
54 |
Position literals first in String comparisons |
| 563 |
org/apache/solr/highlight/BreakIteratorBoundaryScanner.java |
57 |
Position literals first in String comparisons |
| 564 |
org/apache/solr/highlight/DefaultSolrHighlighter.java |
74 |
Document empty constructor |
| 565 |
org/apache/solr/highlight/DefaultSolrHighlighter.java |
467 |
Avoid empty catch blocks |
| 566 |
org/apache/solr/highlight/DefaultSolrHighlighter.java |
472 |
Avoid if (x != y) ..; else ..; |
| 567 |
org/apache/solr/highlight/DefaultSolrHighlighter.java |
530 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 568 |
org/apache/solr/highlight/DefaultSolrHighlighter.java |
538 |
This call to Collection.toArray() may be optimizable |
| 569 |
org/apache/solr/highlight/GapFragmenter.java |
30 |
Avoid reassigning parameters such as 'params' |
| 570 |
org/apache/solr/highlight/GapFragmenter.java |
72 |
Document empty constructor |
| 571 |
org/apache/solr/highlight/HighlightingPluginBase.java |
39 |
No need to check for null before an instanceof |
| 572 |
org/apache/solr/highlight/HighlightingPluginBase.java |
63 |
An empty method in an abstract class should be abstract instead |
| 573 |
org/apache/solr/highlight/HighlightingPluginBase.java |
63 |
Return an empty array rather than null. |
| 574 |
org/apache/solr/highlight/HtmlFormatter.java |
29 |
Avoid reassigning parameters such as 'params' |
| 575 |
org/apache/solr/highlight/RegexFragmenter.java |
66 |
Avoid reassigning parameters such as 'params' |
| 576 |
org/apache/solr/highlight/RegexFragmenter.java |
77 |
Use equals() to compare object references. |
| 577 |
org/apache/solr/highlight/SolrBoundaryScanner.java |
28 |
Avoid reassigning parameters such as 'params' |
| 578 |
org/apache/solr/highlight/SolrFragmentsBuilder.java |
40 |
Avoid reassigning parameters such as 'params' |
| 579 |
org/apache/solr/highlight/SolrFragmentsBuilder.java |
55 |
Avoid reassigning parameters such as 'params' |
| 580 |
org/apache/solr/internal/csv/CSVParser.java |
192 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 581 |
org/apache/solr/internal/csv/CSVParser.java |
306 |
Avoid reassigning parameters such as 'tkn' |
| 582 |
org/apache/solr/internal/csv/CSVParser.java |
405 |
Avoid reassigning parameters such as 'c' |
| 583 |
org/apache/solr/internal/csv/CSVParser.java |
455 |
Avoid reassigning parameters such as 'c' |
| 584 |
org/apache/solr/internal/csv/CSVParser.java |
455 |
Avoid reassigning parameters such as 'c' |
| 585 |
org/apache/solr/internal/csv/CSVParser.java |
455 |
Avoid reassigning parameters such as 'c' |
| 586 |
org/apache/solr/internal/csv/CSVParser.java |
521 |
Avoid reassigning parameters such as 'c' |
| 587 |
org/apache/solr/internal/csv/CSVParser.java |
521 |
Avoid reassigning parameters such as 'c' |
| 588 |
org/apache/solr/internal/csv/CSVParser.java |
536 |
New exception is thrown in catch block, original stack trace may be lost |
| 589 |
org/apache/solr/internal/csv/CSVParser.java |
543 |
Avoid reassigning parameters such as 'c' |
| 590 |
org/apache/solr/internal/csv/CSVParser.java |
588 |
Avoid reassigning parameters such as 'c' |
| 591 |
org/apache/solr/internal/csv/CSVParser.java |
591 |
These nested if statements could be combined |
| 592 |
org/apache/solr/internal/csv/CSVPrinter.java |
132 |
Avoid if (x != y) ..; else ..; |
| 593 |
org/apache/solr/internal/csv/CSVPrinter.java |
134 |
Avoid if (x != y) ..; else ..; |
| 594 |
org/apache/solr/internal/csv/CSVStrategy.java |
82 |
Overridable method 'setDelimiter' called during object construction |
| 595 |
org/apache/solr/internal/csv/CSVStrategy.java |
83 |
Overridable method 'setEncapsulator' called during object construction |
| 596 |
org/apache/solr/internal/csv/CSVStrategy.java |
84 |
Overridable method 'setCommentStart' called during object construction |
| 597 |
org/apache/solr/internal/csv/CSVStrategy.java |
85 |
Overridable method 'setEscape' called during object construction |
| 598 |
org/apache/solr/internal/csv/CSVStrategy.java |
86 |
Overridable method 'setIgnoreLeadingWhitespaces' called during object construction |
| 599 |
org/apache/solr/internal/csv/CSVStrategy.java |
87 |
Overridable method 'setIgnoreTrailingWhitespaces' called during object construction |
| 600 |
org/apache/solr/internal/csv/CSVStrategy.java |
88 |
Overridable method 'setUnicodeEscapeInterpretation' called during object construction |
| 601 |
org/apache/solr/internal/csv/CSVStrategy.java |
89 |
Overridable method 'setIgnoreEmptyLines' called during object construction |
| 602 |
org/apache/solr/internal/csv/CSVUtils.java |
26 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 603 |
org/apache/solr/internal/csv/CSVUtils.java |
38 |
Document empty constructor |
| 604 |
org/apache/solr/internal/csv/CSVUtils.java |
69 |
Avoid empty catch blocks |
| 605 |
org/apache/solr/internal/csv/ExtendedBufferedReader.java |
51 |
Private field 'line' could be made final; it is only initialized in the declaration or constructor. |
| 606 |
org/apache/solr/internal/csv/ExtendedBufferedReader.java |
116 |
Avoid reassigning parameters such as 'len' |
| 607 |
org/apache/solr/internal/csv/writer/CSVConfig.java |
249 |
Ensure you override both equals() and hashCode() |
| 608 |
org/apache/solr/internal/csv/writer/CSVConfig.java |
250 |
Method call on object which may be null |
| 609 |
org/apache/solr/internal/csv/writer/CSVConfigGuesser.java |
53 |
Overridable method 'setInputStream' called during object construction |
| 610 |
org/apache/solr/internal/csv/writer/CSVConfigGuesser.java |
98 |
Avoid empty catch blocks |
| 611 |
org/apache/solr/internal/csv/writer/CSVField.java |
35 |
Document empty constructor |
| 612 |
org/apache/solr/internal/csv/writer/CSVField.java |
42 |
Overridable method 'setName' called during object construction |
| 613 |
org/apache/solr/internal/csv/writer/CSVField.java |
50 |
Overridable method 'setName' called during object construction |
| 614 |
org/apache/solr/internal/csv/writer/CSVField.java |
51 |
Overridable method 'setSize' called during object construction |
| 615 |
org/apache/solr/internal/csv/writer/CSVWriter.java |
39 |
Document empty constructor |
| 616 |
org/apache/solr/internal/csv/writer/CSVWriter.java |
43 |
Overridable method 'setConfig' called during object construction |
| 617 |
org/apache/solr/internal/csv/writer/CSVWriter.java |
79 |
Avoid reassigning parameters such as 'value' |
| 618 |
org/apache/solr/internal/csv/writer/CSVWriter.java |
79 |
Avoid reassigning parameters such as 'value' |
| 619 |
org/apache/solr/internal/csv/writer/CSVWriter.java |
79 |
Avoid reassigning parameters such as 'value' |
| 620 |
org/apache/solr/internal/csv/writer/CSVWriter.java |
79 |
Avoid reassigning parameters such as 'value' |
| 621 |
org/apache/solr/request/LocalSolrQueryRequest.java |
36 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 622 |
org/apache/solr/request/PerSegmentSingleValuedFaceting.java |
141 |
New exception is thrown in catch block, original stack trace may be lost |
| 623 |
org/apache/solr/request/PerSegmentSingleValuedFaceting.java |
240 |
Avoid if (x != y) ..; else ..; |
| 624 |
org/apache/solr/request/SimpleFacets.java |
153 |
Deeply nested if..then statements are hard to read |
| 625 |
org/apache/solr/request/SimpleFacets.java |
258 |
Avoid if (x != y) ..; else ..; |
| 626 |
org/apache/solr/request/SimpleFacets.java |
331 |
Avoid if (x != y) ..; else ..; |
| 627 |
org/apache/solr/request/SimpleFacets.java |
339 |
Avoid if (x != y) ..; else ..; |
| 628 |
org/apache/solr/request/SimpleFacets.java |
393 |
Avoid if (x != y) ..; else ..; |
| 629 |
org/apache/solr/request/SimpleFacets.java |
436 |
Avoid reassigning parameters such as 'prefix' |
| 630 |
org/apache/solr/request/SimpleFacets.java |
468 |
Avoid if (x != y) ..; else ..; |
| 631 |
org/apache/solr/request/SimpleFacets.java |
657 |
Position literals first in String comparisons |
| 632 |
org/apache/solr/request/SimpleFacets.java |
657 |
Position literals first in String comparisons |
| 633 |
org/apache/solr/request/SimpleFacets.java |
683 |
Avoid if (x != y) ..; else ..; |
| 634 |
org/apache/solr/request/SimpleFacets.java |
1213 |
Avoid if (x != y) ..; else ..; |
| 635 |
org/apache/solr/request/SolrRequestInfo.java |
84 |
Avoid if (x != y) ..; else ..; |
| 636 |
org/apache/solr/request/UnInvertedField.java |
179 |
New exception is thrown in catch block, original stack trace may be lost |
| 637 |
org/apache/solr/request/UnInvertedField.java |
196 |
Overridable method 'toString' called during object construction |
| 638 |
org/apache/solr/request/UnInvertedField.java |
278 |
Avoid empty if statements |
| 639 |
org/apache/solr/request/UnInvertedField.java |
627 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 640 |
org/apache/solr/response/BinaryResponseWriter.java |
79 |
Avoid reassigning parameters such as 'o' |
| 641 |
org/apache/solr/response/BinaryResponseWriter.java |
207 |
Avoid if (x != y) ..; else ..; |
| 642 |
org/apache/solr/response/CSVResponseWriter.java |
48 |
Document empty method |
| 643 |
org/apache/solr/response/CSVResponseWriter.java |
261 |
Position literals first in String comparisons |
| 644 |
org/apache/solr/response/CSVResponseWriter.java |
346 |
Document empty method |
| 645 |
org/apache/solr/response/CSVResponseWriter.java |
419 |
Document empty method |
| 646 |
org/apache/solr/response/CSVResponseWriter.java |
423 |
Document empty method |
| 647 |
org/apache/solr/response/JSONResponseWriter.java |
69 |
Private field 'namedListStyle' could be made final; it is only initialized in the declaration or constructor. |
| 648 |
org/apache/solr/response/JSONResponseWriter.java |
70 |
Private field 'wrapperFunction' could be made final; it is only initialized in the declaration or constructor. |
| 649 |
org/apache/solr/response/JSONResponseWriter.java |
296 |
Use equals() to compare object references. |
| 650 |
org/apache/solr/response/JSONResponseWriter.java |
298 |
Use equals() to compare object references. |
| 651 |
org/apache/solr/response/JSONResponseWriter.java |
300 |
Use equals() to compare object references. |
| 652 |
org/apache/solr/response/JSONResponseWriter.java |
302 |
Use equals() to compare object references. |
| 653 |
org/apache/solr/response/JSONResponseWriter.java |
489 |
Avoid reassigning parameters such as 'isFirstVal' |
| 654 |
org/apache/solr/response/JSONResponseWriter.java |
489 |
Avoid reassigning parameters such as 'isFirstVal' |
| 655 |
org/apache/solr/response/PHPSerializedResponseWriter.java |
44 |
Document empty method |
| 656 |
org/apache/solr/response/PHPSerializedResponseWriter.java |
140 |
Avoid if (x != y) ..; else ..; |
| 657 |
org/apache/solr/response/SolrQueryResponse.java |
94 |
Document empty constructor |
| 658 |
org/apache/solr/response/SolrQueryResponse.java |
198 |
Consider simply returning the value vs storing it in local variable 'header' |
| 659 |
org/apache/solr/response/TextResponseWriter.java |
129 |
Avoid if (x != y) ..; else ..; |
| 660 |
org/apache/solr/response/XMLWriter.java |
145 |
Avoid if (x != y) ..; else ..; |
| 661 |
org/apache/solr/response/XSLTResponseWriter.java |
110 |
New exception is thrown in catch block, original stack trace may be lost |
| 662 |
org/apache/solr/response/transform/BaseEditorialTransformer.java |
53 |
Avoid unnecessary comparisons in boolean expressions |
| 663 |
org/apache/solr/response/transform/BaseEditorialTransformer.java |
73 |
Avoid if (x != y) ..; else ..; |
| 664 |
org/apache/solr/response/transform/DocTransformer.java |
48 |
An empty method in an abstract class should be abstract instead |
| 665 |
org/apache/solr/response/transform/DocTransformer.java |
48 |
Document empty method |
| 666 |
org/apache/solr/response/transform/ExplainAugmenterFactory.java |
47 |
Avoid if (x != y) ..; else ..; |
| 667 |
org/apache/solr/response/transform/ExplainAugmenterFactory.java |
61 |
New exception is thrown in catch block, original stack trace may be lost |
| 668 |
org/apache/solr/response/transform/ScoreAugmenter.java |
46 |
These nested if statements could be combined |
| 669 |
org/apache/solr/schema/AbstractSubTypeFieldType.java |
57 |
Avoid if (x != y) ..; else ..; |
| 670 |
org/apache/solr/schema/AbstractSubTypeFieldType.java |
61 |
Avoid if (x != y) ..; else ..; |
| 671 |
org/apache/solr/schema/CollationField.java |
109 |
Avoid if (x != y) ..; else ..; |
| 672 |
org/apache/solr/schema/CollationField.java |
156 |
Avoid if (x != y) ..; else ..; |
| 673 |
org/apache/solr/schema/CollationField.java |
158 |
Avoid if (x != y) ..; else ..; |
| 674 |
org/apache/solr/schema/CurrencyField.java |
74 |
Perhaps 'exchangeRateProviderClass' could be replaced by a local variable. |
| 675 |
org/apache/solr/schema/CurrencyField.java |
260 |
Private field 'targetCurrencyCode' could be made final; it is only initialized in the declaration or constructor. |
| 676 |
org/apache/solr/schema/CurrencyField.java |
261 |
Private field 'currencyValues' could be made final; it is only initialized in the declaration or constructor. |
| 677 |
org/apache/solr/schema/CurrencyField.java |
262 |
Private field 'amountValues' could be made final; it is only initialized in the declaration or constructor. |
| 678 |
org/apache/solr/schema/CurrencyField.java |
281 |
This final field could be made static |
| 679 |
org/apache/solr/schema/CurrencyField.java |
395 |
Avoid if (x != y) ..; else ..; |
| 680 |
org/apache/solr/schema/CurrencyField.java |
396 |
Avoid if (x != y) ..; else ..; |
| 681 |
org/apache/solr/schema/CurrencyField.java |
397 |
Avoid if (x != y) ..; else ..; |
| 682 |
org/apache/solr/schema/CurrencyField.java |
403 |
Avoid if (x != y) ..; else ..; |
| 683 |
org/apache/solr/schema/CurrencyField.java |
404 |
Avoid if (x != y) ..; else ..; |
| 684 |
org/apache/solr/schema/CurrencyField.java |
405 |
Avoid if (x != y) ..; else ..; |
| 685 |
org/apache/solr/schema/CurrencyField.java |
501 |
Avoid if (x != y) ..; else ..; |
| 686 |
org/apache/solr/schema/CurrencyField.java |
506 |
Avoid if (x != y) ..; else ..; |
| 687 |
org/apache/solr/schema/CurrencyField.java |
627 |
Private field 'amount' could be made final; it is only initialized in the declaration or constructor. |
| 688 |
org/apache/solr/schema/CurrencyField.java |
628 |
Private field 'currencyCode' could be made final; it is only initialized in the declaration or constructor. |
| 689 |
org/apache/solr/schema/DateField.java |
185 |
Avoid reassigning parameters such as 'value' |
| 690 |
org/apache/solr/schema/FieldProperties.java |
28 |
This abstract class does not have any abstract methods |
| 691 |
org/apache/solr/schema/FieldProperties.java |
83 |
Avoid reassigning parameters such as 'properties' |
| 692 |
org/apache/solr/schema/FieldType.java |
98 |
An empty method in an abstract class should be abstract instead |
| 693 |
org/apache/solr/schema/FieldType.java |
117 |
An empty method in an abstract class should be abstract instead |
| 694 |
org/apache/solr/schema/FieldType.java |
117 |
Document empty method |
| 695 |
org/apache/solr/schema/FieldType.java |
176 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 696 |
org/apache/solr/schema/FieldType.java |
205 |
Avoid if (x != y) ..; else ..; |
| 697 |
org/apache/solr/schema/FieldTypePluginLoader.java |
49 |
Avoid protected fields in a final class. Change to private or package access. |
| 698 |
org/apache/solr/schema/IndexSchema.java |
86 |
Private field 'copyFieldTargetCounts' could be made final; it is only initialized in the declaration or constructor. |
| 699 |
org/apache/solr/schema/IndexSchema.java |
96 |
Avoid reassigning parameters such as 'is' |
| 700 |
org/apache/solr/schema/IndexSchema.java |
96 |
Avoid reassigning parameters such as 'name' |
| 701 |
org/apache/solr/schema/IndexSchema.java |
286 |
Overridable method 'analyzerCache' called during object construction |
| 702 |
org/apache/solr/schema/IndexSchema.java |
301 |
Avoid if (x != y) ..; else ..; |
| 703 |
org/apache/solr/schema/IndexSchema.java |
324 |
Avoid if (x != y) ..; else ..; |
| 704 |
org/apache/solr/schema/IndexSchema.java |
538 |
Avoid if (x != y) ..; else ..; |
| 705 |
org/apache/solr/schema/IndexSchema.java |
555 |
Avoid unnecessary comparisons in boolean expressions |
| 706 |
org/apache/solr/schema/IndexSchema.java |
712 |
Avoid unnecessary if..then..else statements when returning a boolean |
| 707 |
org/apache/solr/schema/LatLonType.java |
310 |
Avoid if (x != y) ..; else ..; |
| 708 |
org/apache/solr/schema/LatLonType.java |
314 |
Document empty method |
| 709 |
org/apache/solr/schema/LatLonType.java |
555 |
Avoid if (x != y) ..; else ..; |
| 710 |
org/apache/solr/schema/OpenExchangeRatesOrgProvider.java |
99 |
Avoid if (x != y) ..; else ..; |
| 711 |
org/apache/solr/schema/OpenExchangeRatesOrgProvider.java |
104 |
Avoid if (x != y) ..; else ..; |
| 712 |
org/apache/solr/schema/OpenExchangeRatesOrgProvider.java |
176 |
Private field 'rates' could be made final; it is only initialized in the declaration or constructor. |
| 713 |
org/apache/solr/schema/OpenExchangeRatesOrgProvider.java |
181 |
Private field 'parser' could be made final; it is only initialized in the declaration or constructor. |
| 714 |
org/apache/solr/schema/OpenExchangeRatesOrgProvider.java |
194 |
Position literals first in String comparisons |
| 715 |
org/apache/solr/schema/OpenExchangeRatesOrgProvider.java |
197 |
Position literals first in String comparisons |
| 716 |
org/apache/solr/schema/OpenExchangeRatesOrgProvider.java |
200 |
Position literals first in String comparisons |
| 717 |
org/apache/solr/schema/OpenExchangeRatesOrgProvider.java |
203 |
Position literals first in String comparisons |
| 718 |
org/apache/solr/schema/OpenExchangeRatesOrgProvider.java |
206 |
Position literals first in String comparisons |
| 719 |
org/apache/solr/schema/RandomSortField.java |
68 |
Avoid reassigning parameters such as 'key' |
| 720 |
org/apache/solr/schema/RandomSortField.java |
68 |
Avoid reassigning parameters such as 'key' |
| 721 |
org/apache/solr/schema/RandomSortField.java |
68 |
Avoid reassigning parameters such as 'key' |
| 722 |
org/apache/solr/schema/RandomSortField.java |
68 |
Avoid reassigning parameters such as 'key' |
| 723 |
org/apache/solr/schema/RandomSortField.java |
68 |
Avoid reassigning parameters such as 'key' |
| 724 |
org/apache/solr/schema/RandomSortField.java |
68 |
Avoid reassigning parameters such as 'key' |
| 725 |
org/apache/solr/schema/RandomSortField.java |
100 |
Document empty method |
| 726 |
org/apache/solr/schema/TextField.java |
212 |
Avoid if (x != y) ..; else ..; |
| 727 |
org/apache/solr/schema/TextField.java |
213 |
Avoid if (x != y) ..; else ..; |
| 728 |
org/apache/solr/schema/TextField.java |
220 |
Avoid empty catch blocks |
| 729 |
org/apache/solr/schema/TextField.java |
231 |
Avoid empty catch blocks |
| 730 |
org/apache/solr/schema/TextField.java |
241 |
Avoid unnecessary comparisons in boolean expressions |
| 731 |
org/apache/solr/schema/TextField.java |
243 |
Avoid empty catch blocks |
| 732 |
org/apache/solr/schema/TextField.java |
258 |
Avoid unnecessary comparisons in boolean expressions |
| 733 |
org/apache/solr/schema/TextField.java |
260 |
Avoid empty catch blocks |
| 734 |
org/apache/solr/schema/TextField.java |
282 |
Avoid unnecessary comparisons in boolean expressions |
| 735 |
org/apache/solr/schema/TextField.java |
287 |
Avoid empty catch blocks |
| 736 |
org/apache/solr/schema/TextField.java |
291 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 737 |
org/apache/solr/schema/TextField.java |
293 |
This call to Collection.toArray() may be optimizable |
| 738 |
org/apache/solr/schema/TextField.java |
295 |
This call to Collection.toArray() may be optimizable |
| 739 |
org/apache/solr/schema/TextField.java |
303 |
This call to Collection.toArray() may be optimizable |
| 740 |
org/apache/solr/schema/TextField.java |
305 |
This call to Collection.toArray() may be optimizable |
| 741 |
org/apache/solr/schema/TextField.java |
323 |
Avoid unnecessary comparisons in boolean expressions |
| 742 |
org/apache/solr/schema/TextField.java |
328 |
Avoid empty catch blocks |
| 743 |
org/apache/solr/schema/TrieDateField.java |
36 |
Non-static initializers are confusing |
| 744 |
org/apache/solr/schema/TrieDoubleField.java |
37 |
Non-static initializers are confusing |
| 745 |
org/apache/solr/schema/TrieField.java |
114 |
Avoid if (x != y) ..; else ..; |
| 746 |
org/apache/solr/schema/TrieField.java |
145 |
A switch statement does not contain a break |
| 747 |
org/apache/solr/schema/TrieField.java |
414 |
Avoid if (x != y) ..; else ..; |
| 748 |
org/apache/solr/schema/TrieField.java |
566 |
Avoid reassigning parameters such as 'ft' |
| 749 |
org/apache/solr/schema/TrieField.java |
573 |
A switch statement does not contain a break |
| 750 |
org/apache/solr/schema/TrieFloatField.java |
37 |
Non-static initializers are confusing |
| 751 |
org/apache/solr/schema/TrieIntField.java |
31 |
Non-static initializers are confusing |
| 752 |
org/apache/solr/schema/TrieLongField.java |
31 |
Non-static initializers are confusing |
| 753 |
org/apache/solr/search/BoostQParserPlugin.java |
44 |
Document empty method |
| 754 |
org/apache/solr/search/CacheConfig.java |
52 |
Document empty constructor |
| 755 |
org/apache/solr/search/DisMaxQParser.java |
85 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 756 |
org/apache/solr/search/DisMaxQParser.java |
196 |
Avoid if (x != y) ..; else ..; |
| 757 |
org/apache/solr/search/DisMaxQParserPlugin.java |
115 |
Document empty method |
| 758 |
org/apache/solr/search/DocSetBase.java |
37 |
Ensure you override both equals() and hashCode() |
| 759 |
org/apache/solr/search/DocSetCollector.java |
51 |
Avoid reassigning parameters such as 'doc' |
| 760 |
org/apache/solr/search/DocSetCollector.java |
84 |
Document empty method |
| 761 |
org/apache/solr/search/DocSetDelegateCollector.java |
40 |
Avoid reassigning parameters such as 'doc' |
| 762 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
59 |
Document empty method |
| 763 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
84 |
An Interface should be used only to model a behaviour; consider converting this to a class. |
| 764 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
115 |
Perhaps 'multBoosts' could be replaced by a local variable. |
| 765 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
135 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 766 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
169 |
Avoid if (x != y) ..; else ..; |
| 767 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
262 |
These nested if statements could be combined |
| 768 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
314 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 769 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
315 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 770 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
316 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 771 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
432 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 772 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
454 |
Avoid reassigning parameters such as 'shingleSize' |
| 773 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
521 |
Consider simply returning the value vs storing it in local variable 'highFields' |
| 774 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
711 |
A switch statement does not contain a break |
| 775 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
711 |
Switch statements should have a default label |
| 776 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
751 |
Avoid if (x != y) ..; else ..; |
| 777 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
991 |
Position literals first in String comparisons |
| 778 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
991 |
Position literals first in String comparisons |
| 779 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1034 |
Position literals first in String comparisons |
| 780 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1035 |
Position literals first in String comparisons |
| 781 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1068 |
Avoid if (x != y) ..; else ..; |
| 782 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1070 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 783 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1080 |
Consider simply returning the value vs storing it in local variable 'q' |
| 784 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1122 |
Avoid if (x != y) ..; else ..; |
| 785 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1156 |
A switch statement does not contain a break |
| 786 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1156 |
Switch statements should have a default label |
| 787 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1196 |
Use equals() to compare object references. |
| 788 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1248 |
Private field 'userFieldsMap' could be made final; it is only initialized in the declaration or constructor. |
| 789 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1249 |
Private field 'dynamicUserFields' could be made final; it is only initialized in the declaration or constructor. |
| 790 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1250 |
Private field 'negativeDynamicUserFields' could be made final; it is only initialized in the declaration or constructor. |
| 791 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1254 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 792 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1325 |
Position literals first in String comparisons |
| 793 |
org/apache/solr/search/ExtendedDismaxQParserPlugin.java |
1348 |
Avoid unnecessary if..then..else statements when returning a boolean |
| 794 |
org/apache/solr/search/ExtendedQueryBase.java |
58 |
Avoid if (x != y) ..; else ..; |
| 795 |
org/apache/solr/search/FastLRUCache.java |
207 |
Return an empty array rather than null. |
| 796 |
org/apache/solr/search/FieldQParserPlugin.java |
38 |
Document empty method |
| 797 |
org/apache/solr/search/FunctionQParser.java |
72 |
Avoid if (x != y) ..; else ..; |
| 798 |
org/apache/solr/search/FunctionQParser.java |
76 |
Avoid if (x != y) ..; else ..; |
| 799 |
org/apache/solr/search/FunctionQParser.java |
138 |
Consider simply returning the value vs storing it in local variable 'value' |
| 800 |
org/apache/solr/search/FunctionQParser.java |
150 |
Consider simply returning the value vs storing it in local variable 'value' |
| 801 |
org/apache/solr/search/FunctionQParser.java |
162 |
Consider simply returning the value vs storing it in local variable 'value' |
| 802 |
org/apache/solr/search/FunctionQParser.java |
262 |
Avoid if (x != y) ..; else ..; |
| 803 |
org/apache/solr/search/FunctionQParserPlugin.java |
31 |
Document empty method |
| 804 |
org/apache/solr/search/FunctionRangeQParserPlugin.java |
49 |
Document empty method |
| 805 |
org/apache/solr/search/Grouping.java |
82 |
Perhaps 'getDocSet' could be replaced by a local variable. |
| 806 |
org/apache/solr/search/Grouping.java |
88 |
Private field 'grouped' could be made final; it is only initialized in the declaration or constructor. |
| 807 |
org/apache/solr/search/Grouping.java |
89 |
Private field 'idSet' could be made final; it is only initialized in the declaration or constructor. |
| 808 |
org/apache/solr/search/Grouping.java |
295 |
Avoid if (x != y) ..; else ..; |
| 809 |
org/apache/solr/search/Grouping.java |
373 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 810 |
org/apache/solr/search/Grouping.java |
374 |
Avoid if (x != y) ..; else ..; |
| 811 |
org/apache/solr/search/Grouping.java |
414 |
Avoid reassigning parameters such as 'collector' |
| 812 |
org/apache/solr/search/Grouping.java |
537 |
An empty method in an abstract class should be abstract instead |
| 813 |
org/apache/solr/search/Grouping.java |
548 |
An empty method in an abstract class should be abstract instead |
| 814 |
org/apache/solr/search/Grouping.java |
572 |
An empty method in an abstract class should be abstract instead |
| 815 |
org/apache/solr/search/Grouping.java |
629 |
Avoid if (x != y) ..; else ..; |
| 816 |
org/apache/solr/search/Grouping.java |
747 |
Avoid if (x != y) ..; else ..; |
| 817 |
org/apache/solr/search/Grouping.java |
755 |
Avoid if (x != y) ..; else ..; |
| 818 |
org/apache/solr/search/Grouping.java |
786 |
Avoid if (x != y) ..; else ..; |
| 819 |
org/apache/solr/search/Grouping.java |
808 |
Avoid if (x != y) ..; else ..; |
| 820 |
org/apache/solr/search/Grouping.java |
954 |
Avoid if (x != y) ..; else ..; |
| 821 |
org/apache/solr/search/Grouping.java |
962 |
Avoid if (x != y) ..; else ..; |
| 822 |
org/apache/solr/search/Grouping.java |
1001 |
Avoid if (x != y) ..; else ..; |
| 823 |
org/apache/solr/search/HashDocSet.java |
119 |
Non-static initializers are confusing |
| 824 |
org/apache/solr/search/HashDocSet.java |
129 |
Document empty method |
| 825 |
org/apache/solr/search/JoinQParserPlugin.java |
50 |
Document empty method |
| 826 |
org/apache/solr/search/JoinQParserPlugin.java |
88 |
Use equals() to compare object references. |
| 827 |
org/apache/solr/search/JoinQParserPlugin.java |
266 |
Use equals() to compare object references. |
| 828 |
org/apache/solr/search/JoinQParserPlugin.java |
289 |
Use equals() to compare object references. |
| 829 |
org/apache/solr/search/JoinQParserPlugin.java |
360 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 830 |
org/apache/solr/search/JoinQParserPlugin.java |
370 |
Avoid if (x != y) ..; else ..; |
| 831 |
org/apache/solr/search/JoinQParserPlugin.java |
423 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 832 |
org/apache/solr/search/JoinQParserPlugin.java |
520 |
Avoid if (x != y) ..; else ..; |
| 833 |
org/apache/solr/search/LFUCache.java |
214 |
Return an empty array rather than null. |
| 834 |
org/apache/solr/search/LRUCache.java |
64 |
Avoid reassigning parameters such as 'persistence' |
| 835 |
org/apache/solr/search/LRUCache.java |
206 |
Document empty method |
| 836 |
org/apache/solr/search/LRUCache.java |
233 |
Return an empty array rather than null. |
| 837 |
org/apache/solr/search/LuceneQParserPlugin.java |
40 |
Document empty method |
| 838 |
org/apache/solr/search/LuceneQParserPlugin.java |
109 |
Deeply nested if..then statements are hard to read |
| 839 |
org/apache/solr/search/LuceneQueryOptimizer.java |
38 |
Private field 'cache' could be made final; it is only initialized in the declaration or constructor. |
| 840 |
org/apache/solr/search/LuceneQueryOptimizer.java |
40 |
Private field 'threshold' could be made final; it is only initialized in the declaration or constructor. |
| 841 |
org/apache/solr/search/LuceneQueryOptimizer.java |
109 |
Avoid if (x != y) ..; else ..; |
| 842 |
org/apache/solr/search/NestedQParserPlugin.java |
38 |
Document empty method |
| 843 |
org/apache/solr/search/OldLuceneQParserPlugin.java |
31 |
Document empty method |
| 844 |
org/apache/solr/search/PrefixQParserPlugin.java |
36 |
Document empty method |
| 845 |
org/apache/solr/search/QParser.java |
70 |
Deeply nested if..then statements are hard to read |
| 846 |
org/apache/solr/search/QParser.java |
154 |
Deeply nested if..then statements are hard to read |
| 847 |
org/apache/solr/search/QParser.java |
202 |
Avoid reassigning parameters such as 'defaultType' |
| 848 |
org/apache/solr/search/QParser.java |
218 |
An empty method in an abstract class should be abstract instead |
| 849 |
org/apache/solr/search/QParser.java |
249 |
Avoid reassigning parameters such as 'useGlobalParams' |
| 850 |
org/apache/solr/search/QParser.java |
279 |
Avoid if (x != y) ..; else ..; |
| 851 |
org/apache/solr/search/QParser.java |
280 |
Avoid if (x != y) ..; else ..; |
| 852 |
org/apache/solr/search/QParser.java |
311 |
Avoid reassigning parameters such as 'qstr' |
| 853 |
org/apache/solr/search/QParser.java |
325 |
Avoid if (x != y) ..; else ..; |
| 854 |
org/apache/solr/search/QueryParsing.java |
59 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 855 |
org/apache/solr/search/QueryParsing.java |
121 |
Avoid if (x != y) ..; else ..; |
| 856 |
org/apache/solr/search/QueryParsing.java |
156 |
These nested if statements could be combined |
| 857 |
org/apache/solr/search/QueryParsing.java |
209 |
Avoid empty if statements |
| 858 |
org/apache/solr/search/QueryParsing.java |
267 |
Avoid if (x != y) ..; else ..; |
| 859 |
org/apache/solr/search/QueryParsing.java |
383 |
Avoid if (x != y) ..; else ..; |
| 860 |
org/apache/solr/search/QueryParsing.java |
397 |
Avoid if (x != y) ..; else ..; |
| 861 |
org/apache/solr/search/QueryParsing.java |
479 |
Avoid if (x != y) ..; else ..; |
| 862 |
org/apache/solr/search/QueryParsing.java |
804 |
Avoid empty if statements |
| 863 |
org/apache/solr/search/QueryParsing.java |
835 |
Switch statements should have a default label |
| 864 |
org/apache/solr/search/QueryResultKey.java |
54 |
Avoid if (x != y) ..; else ..; |
| 865 |
org/apache/solr/search/QueryResultKey.java |
95 |
Use equals() to compare object references. |
| 866 |
org/apache/solr/search/QueryUtils.java |
30 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 867 |
org/apache/solr/search/QueryUtils.java |
37 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 868 |
org/apache/solr/search/QueryUtils.java |
58 |
Use equals() to compare object references. |
| 869 |
org/apache/solr/search/QueryUtils.java |
68 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 870 |
org/apache/solr/search/RawQParserPlugin.java |
40 |
Document empty method |
| 871 |
org/apache/solr/search/ReturnFields.java |
63 |
Private field 'okFieldNames' could be made final; it is only initialized in the declaration or constructor. |
| 872 |
org/apache/solr/search/ReturnFields.java |
80 |
Overridable method 'add' called during object construction |
| 873 |
org/apache/solr/search/ReturnFields.java |
92 |
Overridable method 'add' called during object construction |
| 874 |
org/apache/solr/search/ReturnFields.java |
98 |
Overridable method 'add' called during object construction |
| 875 |
org/apache/solr/search/ReturnFields.java |
250 |
Avoid if (x != y) ..; else ..; |
| 876 |
org/apache/solr/search/ReturnFields.java |
254 |
Avoid empty if statements |
| 877 |
org/apache/solr/search/ReturnFields.java |
275 |
Avoid if (x != y) ..; else ..; |
| 878 |
org/apache/solr/search/ReturnFields.java |
330 |
Avoid if (x != y) ..; else ..; |
| 879 |
org/apache/solr/search/SolrCacheBase.java |
23 |
This abstract class does not have any abstract methods |
| 880 |
org/apache/solr/search/SolrConstantScoreQuery.java |
63 |
Document empty method |
| 881 |
org/apache/solr/search/SolrConstantScoreQuery.java |
96 |
Private field 'context' could be made final; it is only initialized in the declaration or constructor. |
| 882 |
org/apache/solr/search/SolrFieldCacheMBean.java |
52 |
Return an empty array rather than null. |
| 883 |
org/apache/solr/search/SolrIndexSearcher.java |
82 |
Private field 'debug' could be made final; it is only initialized in the declaration or constructor. |
| 884 |
org/apache/solr/search/SolrIndexSearcher.java |
85 |
Private field 'openTime' could be made final; it is only initialized in the declaration or constructor. |
| 885 |
org/apache/solr/search/SolrIndexSearcher.java |
102 |
Perhaps 'optimizer' could be replaced by a local variable. |
| 886 |
org/apache/solr/search/SolrIndexSearcher.java |
130 |
Avoid if (x != y) ..; else ..; |
| 887 |
org/apache/solr/search/SolrIndexSearcher.java |
429 |
Private field 'fieldsToLoad' could be made final; it is only initialized in the declaration or constructor. |
| 888 |
org/apache/solr/search/SolrIndexSearcher.java |
574 |
Avoid if (x != y) ..; else ..; |
| 889 |
org/apache/solr/search/SolrIndexSearcher.java |
675 |
Avoid reassigning parameters such as 'query' |
| 890 |
org/apache/solr/search/SolrIndexSearcher.java |
675 |
Avoid reassigning parameters such as 'query' |
| 891 |
org/apache/solr/search/SolrIndexSearcher.java |
690 |
Use equals() to compare object references. |
| 892 |
org/apache/solr/search/SolrIndexSearcher.java |
801 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 893 |
org/apache/solr/search/SolrIndexSearcher.java |
873 |
Avoid if (x != y) ..; else ..; |
| 894 |
org/apache/solr/search/SolrIndexSearcher.java |
971 |
Avoid if (x != y) ..; else ..; |
| 895 |
org/apache/solr/search/SolrIndexSearcher.java |
1044 |
Avoid reassigning parameters such as 'query' |
| 896 |
org/apache/solr/search/SolrIndexSearcher.java |
1044 |
Avoid reassigning parameters such as 'query' |
| 897 |
org/apache/solr/search/SolrIndexSearcher.java |
1060 |
Use equals() to compare object references. |
| 898 |
org/apache/solr/search/SolrIndexSearcher.java |
1183 |
These nested if statements could be combined |
| 899 |
org/apache/solr/search/SolrIndexSearcher.java |
1262 |
Avoid if (x != y) ..; else ..; |
| 900 |
org/apache/solr/search/SolrIndexSearcher.java |
1312 |
Avoid if (x != y) ..; else ..; |
| 901 |
org/apache/solr/search/SolrIndexSearcher.java |
1315 |
Document empty method |
| 902 |
org/apache/solr/search/SolrIndexSearcher.java |
1322 |
Document empty method |
| 903 |
org/apache/solr/search/SolrIndexSearcher.java |
1343 |
Document empty method |
| 904 |
org/apache/solr/search/SolrIndexSearcher.java |
1376 |
Avoid if (x != y) ..; else ..; |
| 905 |
org/apache/solr/search/SolrIndexSearcher.java |
1406 |
Avoid if (x != y) ..; else ..; |
| 906 |
org/apache/solr/search/SolrIndexSearcher.java |
1450 |
Avoid if (x != y) ..; else ..; |
| 907 |
org/apache/solr/search/SolrIndexSearcher.java |
1465 |
Document empty method |
| 908 |
org/apache/solr/search/SolrIndexSearcher.java |
1535 |
Avoid if (x != y) ..; else ..; |
| 909 |
org/apache/solr/search/SolrIndexSearcher.java |
1838 |
Use equals() to compare object references. |
| 910 |
org/apache/solr/search/SolrIndexSearcher.java |
1875 |
Use equals() to compare object references. |
| 911 |
org/apache/solr/search/SolrIndexSearcher.java |
1876 |
Use equals() to compare object references. |
| 912 |
org/apache/solr/search/SolrIndexSearcher.java |
1879 |
Use equals() to compare object references. |
| 913 |
org/apache/solr/search/SolrIndexSearcher.java |
1918 |
Document empty method |
| 914 |
org/apache/solr/search/SolrIndexSearcher.java |
1994 |
Return an empty array rather than null. |
| 915 |
org/apache/solr/search/SolrIndexSearcher.java |
2192 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 916 |
org/apache/solr/search/SolrIndexSearcher.java |
2218 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 917 |
org/apache/solr/search/SolrIndexSearcher.java |
2244 |
Avoid reassigning parameters such as 'doc' |
| 918 |
org/apache/solr/search/SolrQueryParser.java |
185 |
Avoid reassigning parameters such as 'termStr' |
| 919 |
org/apache/solr/search/SolrQueryParser.java |
194 |
Avoid reassigning parameters such as 'termStr' |
| 920 |
org/apache/solr/search/SolrQueryParser.java |
241 |
Avoid reassigning parameters such as 'termStr' |
| 921 |
org/apache/solr/search/SortedIntDocSet.java |
319 |
Avoid reassigning parameters such as 'a' |
| 922 |
org/apache/solr/search/SortedIntDocSet.java |
319 |
Avoid reassigning parameters such as 'b' |
| 923 |
org/apache/solr/search/SortedIntDocSet.java |
319 |
Avoid reassigning parameters such as 'lena' |
| 924 |
org/apache/solr/search/SortedIntDocSet.java |
319 |
Avoid reassigning parameters such as 'lenb' |
| 925 |
org/apache/solr/search/SortedIntDocSet.java |
636 |
Avoid reassigning parameters such as 'high' |
| 926 |
org/apache/solr/search/SortedIntDocSet.java |
636 |
Avoid reassigning parameters such as 'low' |
| 927 |
org/apache/solr/search/SortedIntDocSet.java |
714 |
Avoid reassigning parameters such as 'target' |
| 928 |
org/apache/solr/search/Sorting.java |
29 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 929 |
org/apache/solr/search/Sorting.java |
44 |
Avoid if (x != y) ..; else ..; |
| 930 |
org/apache/solr/search/SpatialBoxQParserPlugin.java |
35 |
Document empty method |
| 931 |
org/apache/solr/search/SpatialFilterQParser.java |
89 |
Avoid empty if statements |
| 932 |
org/apache/solr/search/SpatialFilterQParserPlugin.java |
61 |
Document empty method |
| 933 |
org/apache/solr/search/SpatialOptions.java |
40 |
Document empty constructor |
| 934 |
org/apache/solr/search/SurroundQParserPlugin.java |
51 |
Document empty method |
| 935 |
org/apache/solr/search/SurroundQParserPlugin.java |
99 |
New exception is thrown in catch block, original stack trace may be lost |
| 936 |
org/apache/solr/search/SurroundQParserPlugin.java |
113 |
Consider simply returning the value vs storing it in local variable 'lquery' |
| 937 |
org/apache/solr/search/TermQParserPlugin.java |
47 |
Document empty method |
| 938 |
org/apache/solr/search/TermQParserPlugin.java |
59 |
Avoid if (x != y) ..; else ..; |
| 939 |
org/apache/solr/search/ValueSourceParser.java |
58 |
An empty method in an abstract class should be abstract instead |
| 940 |
org/apache/solr/search/ValueSourceParser.java |
58 |
Document empty method |
| 941 |
org/apache/solr/search/ValueSourceParser.java |
122 |
Consider simply returning the value vs storing it in local variable 'source' |
| 942 |
org/apache/solr/search/ValueSourceParser.java |
836 |
Document empty method |
| 943 |
org/apache/solr/search/ValueSourceParser.java |
1127 |
Document empty method |
| 944 |
org/apache/solr/search/ValueSourceParser.java |
1255 |
Overriding method merely calls super |
| 945 |
org/apache/solr/search/function/FileFloatSource.java |
61 |
Private field 'field' could be made final; it is only initialized in the declaration or constructor. |
| 946 |
org/apache/solr/search/function/FileFloatSource.java |
293 |
Avoid empty catch blocks |
| 947 |
org/apache/solr/search/function/ValueSourceRangeFilter.java |
119 |
Avoid if (x != y) ..; else ..; |
| 948 |
org/apache/solr/search/function/ValueSourceRangeFilter.java |
120 |
Avoid if (x != y) ..; else ..; |
| 949 |
org/apache/solr/search/function/ValueSourceRangeFilter.java |
127 |
Avoid if (x != y) ..; else ..; |
| 950 |
org/apache/solr/search/function/ValueSourceRangeFilter.java |
129 |
Avoid if (x != y) ..; else ..; |
| 951 |
org/apache/solr/search/function/distance/GeohashHaversineFunction.java |
49 |
Private field 'geoHash1' could be made final; it is only initialized in the declaration or constructor. |
| 952 |
org/apache/solr/search/function/distance/GeohashHaversineFunction.java |
49 |
Private field 'geoHash2' could be made final; it is only initialized in the declaration or constructor. |
| 953 |
org/apache/solr/search/function/distance/GeohashHaversineFunction.java |
50 |
Private field 'radius' could be made final; it is only initialized in the declaration or constructor. |
| 954 |
org/apache/solr/search/function/distance/GeohashHaversineFunction.java |
90 |
Avoid unnecessary comparisons in boolean expressions |
| 955 |
org/apache/solr/search/function/distance/HaversineConstFunction.java |
65 |
Avoid empty if statements |
| 956 |
org/apache/solr/search/function/distance/HaversineConstFunction.java |
65 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 957 |
org/apache/solr/search/function/distance/HaversineConstFunction.java |
152 |
New exception is thrown in catch block, original stack trace may be lost |
| 958 |
org/apache/solr/search/function/distance/HaversineConstFunction.java |
157 |
Return an empty array rather than null. |
| 959 |
org/apache/solr/search/grouping/CommandHandler.java |
41 |
Class cannot be instantiated and does not provide any static methods or fields |
| 960 |
org/apache/solr/search/grouping/CommandHandler.java |
46 |
Private field 'commands' could be made final; it is only initialized in the declaration or constructor. |
| 961 |
org/apache/solr/search/grouping/CommandHandler.java |
95 |
Avoid instantiation through private constructors from outside of the constructor's class. |
| 962 |
org/apache/solr/search/grouping/CommandHandler.java |
145 |
Avoid if (x != y) ..; else ..; |
| 963 |
org/apache/solr/search/grouping/CommandHandler.java |
194 |
Avoid reassigning parameters such as 'collector' |
| 964 |
org/apache/solr/search/grouping/CommandHandler.java |
194 |
Avoid reassigning parameters such as 'collector' |
| 965 |
org/apache/solr/search/grouping/distributed/command/QueryCommand.java |
36 |
Class cannot be instantiated and does not provide any static methods or fields |
| 966 |
org/apache/solr/search/grouping/distributed/command/QueryCommand.java |
103 |
Avoid instantiation through private constructors from outside of the constructor's class. |
| 967 |
org/apache/solr/search/grouping/distributed/command/QueryCommand.java |
142 |
Avoid if (x != y) ..; else ..; |
| 968 |
org/apache/solr/search/grouping/distributed/command/SearchGroupsFieldCommand.java |
37 |
Class cannot be instantiated and does not provide any static methods or fields |
| 969 |
org/apache/solr/search/grouping/distributed/command/SearchGroupsFieldCommand.java |
65 |
Avoid instantiation through private constructors from outside of the constructor's class. |
| 970 |
org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java |
40 |
Class cannot be instantiated and does not provide any static methods or fields |
| 971 |
org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java |
99 |
Avoid instantiation through private constructors from outside of the constructor's class. |
| 972 |
org/apache/solr/search/grouping/distributed/requestfactory/TopGroupsShardRequestFactory.java |
117 |
Avoid if (x != y) ..; else ..; |
| 973 |
org/apache/solr/search/grouping/distributed/shardresultserializer/SearchGroupsResultTransformer.java |
81 |
Avoid if (x != y) ..; else ..; |
| 974 |
org/apache/solr/search/grouping/distributed/shardresultserializer/SearchGroupsResultTransformer.java |
99 |
Avoid if (x != y) ..; else ..; |
| 975 |
org/apache/solr/search/grouping/distributed/shardresultserializer/SearchGroupsResultTransformer.java |
112 |
Avoid if (x != y) ..; else ..; |
| 976 |
org/apache/solr/search/grouping/distributed/shardresultserializer/TopGroupsResultTransformer.java |
145 |
Avoid if (x != y) ..; else ..; |
| 977 |
org/apache/solr/search/grouping/distributed/shardresultserializer/TopGroupsResultTransformer.java |
200 |
Avoid if (x != y) ..; else ..; |
| 978 |
org/apache/solr/search/grouping/distributed/shardresultserializer/TopGroupsResultTransformer.java |
216 |
Avoid if (x != y) ..; else ..; |
| 979 |
org/apache/solr/search/grouping/distributed/shardresultserializer/TopGroupsResultTransformer.java |
253 |
Avoid if (x != y) ..; else ..; |
| 980 |
org/apache/solr/search/grouping/endresulttransformer/GroupedEndResultTransformer.java |
69 |
Avoid if (x != y) ..; else ..; |
| 981 |
org/apache/solr/search/similarities/DFRSimilarityFactory.java |
173 |
Avoid if (x != y) ..; else ..; |
| 982 |
org/apache/solr/search/similarities/DFRSimilarityFactory.java |
176 |
Avoid if (x != y) ..; else ..; |
| 983 |
org/apache/solr/search/similarities/DFRSimilarityFactory.java |
179 |
Avoid if (x != y) ..; else ..; |
| 984 |
org/apache/solr/search/similarities/DFRSimilarityFactory.java |
182 |
Avoid if (x != y) ..; else ..; |
| 985 |
org/apache/solr/search/similarities/LMDirichletSimilarityFactory.java |
55 |
Avoid if (x != y) ..; else ..; |
| 986 |
org/apache/solr/search/similarities/SchemaSimilarityFactory.java |
35 |
Private field 'defaultSimilarity' could be made final; it is only initialized in the declaration or constructor. |
| 987 |
org/apache/solr/servlet/DirectSolrConnection.java |
93 |
Avoid reassigning parameters such as 'params' |
| 988 |
org/apache/solr/servlet/DirectSolrConnection.java |
98 |
These nested if statements could be combined |
| 989 |
org/apache/solr/servlet/DirectSolrConnection.java |
115 |
Avoid reassigning parameters such as 'params' |
| 990 |
org/apache/solr/servlet/LoadAdminUiServlet.java |
51 |
Avoid if (x != y) ..; else ..; |
| 991 |
org/apache/solr/servlet/SolrDispatchFilter.java |
185 |
Deeply nested if..then statements are hard to read |
| 992 |
org/apache/solr/servlet/SolrDispatchFilter.java |
190 |
Deeply nested if..then statements are hard to read |
| 993 |
org/apache/solr/servlet/SolrDispatchFilter.java |
190 |
These nested if statements could be combined |
| 994 |
org/apache/solr/servlet/SolrDispatchFilter.java |
200 |
Avoid if (x != y) ..; else ..; |
| 995 |
org/apache/solr/servlet/SolrDispatchFilter.java |
227 |
Deeply nested if..then statements are hard to read |
| 996 |
org/apache/solr/servlet/SolrDispatchFilter.java |
227 |
These nested if statements could be combined |
| 997 |
org/apache/solr/servlet/SolrDispatchFilter.java |
445 |
Avoid reassigning parameters such as 'core' |
| 998 |
org/apache/solr/servlet/SolrDispatchFilter.java |
446 |
Avoid reassigning parameters such as 'req' |
| 999 |
org/apache/solr/servlet/SolrRequestParsers.java |
64 |
Perhaps 'parsers' could be replaced by a local variable. |
| 1000 |
org/apache/solr/servlet/SolrRequestParsers.java |
64 |
Private field 'parsers' could be made final; it is only initialized in the declaration or constructor. |
| 1001 |
org/apache/solr/servlet/SolrRequestParsers.java |
67 |
Private field 'standard' could be made final; it is only initialized in the declaration or constructor. |
| 1002 |
org/apache/solr/servlet/SolrRequestParsers.java |
172 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 1003 |
org/apache/solr/servlet/SolrRequestParsers.java |
316 |
Private field 'uploadLimitKB' could be made final; it is only initialized in the declaration or constructor. |
| 1004 |
org/apache/solr/servlet/ZookeeperInfoServlet.java |
52 |
Document empty method |
| 1005 |
org/apache/solr/servlet/ZookeeperInfoServlet.java |
124 |
Avoid reassigning parameters such as 'addr' |
| 1006 |
org/apache/solr/servlet/ZookeeperInfoServlet.java |
130 |
These nested if statements could be combined |
| 1007 |
org/apache/solr/servlet/ZookeeperInfoServlet.java |
145 |
Overridable method 'writeError' called during object construction |
| 1008 |
org/apache/solr/servlet/ZookeeperInfoServlet.java |
153 |
Overridable method 'writeError' called during object construction |
| 1009 |
org/apache/solr/servlet/ZookeeperInfoServlet.java |
159 |
Overridable method 'writeError' called during object construction |
| 1010 |
org/apache/solr/servlet/ZookeeperInfoServlet.java |
177 |
Avoid reassigning parameters such as 'path' |
| 1011 |
org/apache/solr/servlet/ZookeeperInfoServlet.java |
177 |
Avoid reassigning parameters such as 'path' |
| 1012 |
org/apache/solr/servlet/ZookeeperInfoServlet.java |
177 |
Avoid reassigning parameters such as 'path' |
| 1013 |
org/apache/solr/servlet/cache/HttpCacheHeaderUtil.java |
44 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 1014 |
org/apache/solr/servlet/cache/HttpCacheHeaderUtil.java |
196 |
Avoid unnecessary return statements |
| 1015 |
org/apache/solr/servlet/cache/HttpCacheHeaderUtil.java |
260 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 1016 |
org/apache/solr/servlet/cache/HttpCacheHeaderUtil.java |
272 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 1017 |
org/apache/solr/servlet/cache/HttpCacheHeaderUtil.java |
307 |
Avoid empty catch blocks |
| 1018 |
org/apache/solr/spelling/AbstractLuceneSpellChecker.java |
99 |
These nested if statements could be combined |
| 1019 |
org/apache/solr/spelling/AbstractLuceneSpellChecker.java |
106 |
Avoid if (x != y) ..; else ..; |
| 1020 |
org/apache/solr/spelling/AbstractLuceneSpellChecker.java |
118 |
Avoid if (x != y) ..; else ..; |
| 1021 |
org/apache/solr/spelling/AbstractLuceneSpellChecker.java |
146 |
Avoid if (x != y) ..; else ..; |
| 1022 |
org/apache/solr/spelling/AbstractLuceneSpellChecker.java |
155 |
Avoid if (x != y) ..; else ..; |
| 1023 |
org/apache/solr/spelling/AbstractLuceneSpellChecker.java |
163 |
Avoid unnecessary comparisons in boolean expressions |
| 1024 |
org/apache/solr/spelling/AbstractLuceneSpellChecker.java |
209 |
Avoid if (x != y) ..; else ..; |
| 1025 |
org/apache/solr/spelling/DirectSolrSpellChecker.java |
98 |
Private field 'checker' could be made final; it is only initialized in the declaration or constructor. |
| 1026 |
org/apache/solr/spelling/DirectSolrSpellChecker.java |
172 |
Document empty method |
| 1027 |
org/apache/solr/spelling/DirectSolrSpellChecker.java |
175 |
Document empty method |
| 1028 |
org/apache/solr/spelling/FileBasedSpellChecker.java |
86 |
Avoid if (x != y) ..; else ..; |
| 1029 |
org/apache/solr/spelling/IndexBasedSpellChecker.java |
105 |
Avoid if (x != y) ..; else ..; |
| 1030 |
org/apache/solr/spelling/PossibilityIterator.java |
41 |
Private field 'possibilityList' could be made final; it is only initialized in the declaration or constructor. |
| 1031 |
org/apache/solr/spelling/QueryConverter.java |
50 |
Perhaps 'args' could be replaced by a local variable. |
| 1032 |
org/apache/solr/spelling/SolrSpellChecker.java |
91 |
Avoid empty catch blocks |
| 1033 |
org/apache/solr/spelling/SpellCheckCollator.java |
40 |
Avoid reassigning parameters such as 'maxTries' |
| 1034 |
org/apache/solr/spelling/SpellCheckCollator.java |
40 |
Avoid reassigning parameters such as 'maxTries' |
| 1035 |
org/apache/solr/spelling/SpellingOptions.java |
64 |
Document empty constructor |
| 1036 |
org/apache/solr/spelling/SpellingQueryConverter.java |
106 |
Avoid unnecessary comparisons in boolean expressions |
| 1037 |
org/apache/solr/spelling/SpellingQueryConverter.java |
106 |
Avoid unnecessary comparisons in boolean expressions |
| 1038 |
org/apache/solr/spelling/SpellingQueryConverter.java |
106 |
Position literals first in String comparisons |
| 1039 |
org/apache/solr/spelling/SpellingQueryConverter.java |
106 |
Position literals first in String comparisons |
| 1040 |
org/apache/solr/spelling/SpellingQueryConverter.java |
109 |
Avoid empty catch blocks |
| 1041 |
org/apache/solr/spelling/SpellingResult.java |
40 |
Private field 'suggestions' could be made final; it is only initialized in the declaration or constructor. |
| 1042 |
org/apache/solr/spelling/SpellingResult.java |
45 |
Document empty constructor |
| 1043 |
org/apache/solr/spelling/suggest/Suggester.java |
108 |
Avoid if (x != y) ..; else ..; |
| 1044 |
org/apache/solr/spelling/suggest/Suggester.java |
141 |
Avoid if (x != y) ..; else ..; |
| 1045 |
org/apache/solr/spelling/suggest/fst/FSTLookupFactory.java |
55 |
Avoid if (x != y) ..; else ..; |
| 1046 |
org/apache/solr/spelling/suggest/fst/FSTLookupFactory.java |
59 |
Avoid if (x != y) ..; else ..; |
| 1047 |
org/apache/solr/spelling/suggest/fst/WFSTLookupFactory.java |
47 |
Avoid if (x != y) ..; else ..; |
| 1048 |
org/apache/solr/update/AddUpdateCommand.java |
81 |
These nested if statements could be combined |
| 1049 |
org/apache/solr/update/AddUpdateCommand.java |
89 |
Deeply nested if..then statements are hard to read |
| 1050 |
org/apache/solr/update/CommitTracker.java |
44 |
Avoid protected fields in a final class. Change to private or package access. |
| 1051 |
org/apache/solr/update/CommitTracker.java |
47 |
This final field could be made static |
| 1052 |
org/apache/solr/update/CommitTracker.java |
58 |
Private field 'docsSinceCommit' could be made final; it is only initialized in the declaration or constructor. |
| 1053 |
org/apache/solr/update/CommitTracker.java |
59 |
Private field 'autoCommitCount' could be made final; it is only initialized in the declaration or constructor. |
| 1054 |
org/apache/solr/update/CommitTracker.java |
65 |
This final field could be made static |
| 1055 |
org/apache/solr/update/CommitTracker.java |
67 |
Perhaps 'name' could be replaced by a local variable. |
| 1056 |
org/apache/solr/update/CommitTracker.java |
67 |
Private field 'name' could be made final; it is only initialized in the declaration or constructor. |
| 1057 |
org/apache/solr/update/CommitTracker.java |
83 |
Use block level rather than method level synchronization |
| 1058 |
org/apache/solr/update/CommitTracker.java |
162 |
Document empty method |
| 1059 |
org/apache/solr/update/DefaultSolrCoreState.java |
39 |
Private field 'directoryFactory' could be made final; it is only initialized in the declaration or constructor. |
| 1060 |
org/apache/solr/update/DefaultSolrCoreState.java |
50 |
Use block level rather than method level synchronization |
| 1061 |
org/apache/solr/update/DefaultSolrCoreState.java |
58 |
Use block level rather than method level synchronization |
| 1062 |
org/apache/solr/update/DefaultSolrCoreState.java |
72 |
Avoid if (x != y) ..; else ..; |
| 1063 |
org/apache/solr/update/DefaultSolrCoreState.java |
97 |
Use block level rather than method level synchronization |
| 1064 |
org/apache/solr/update/DefaultSolrCoreState.java |
105 |
Use block level rather than method level synchronization |
| 1065 |
org/apache/solr/update/DirectUpdateHandler2.java |
202 |
Avoid if (x != y) ..; else ..; |
| 1066 |
org/apache/solr/update/DirectUpdateHandler2.java |
390 |
Avoid if (x != y) ..; else ..; |
| 1067 |
org/apache/solr/update/DirectUpdateHandler2.java |
628 |
Return an empty array rather than null. |
| 1068 |
org/apache/solr/update/DocumentBuilder.java |
63 |
Deeply nested if..then statements are hard to read |
| 1069 |
org/apache/solr/update/DocumentBuilder.java |
76 |
These nested if statements could be combined |
| 1070 |
org/apache/solr/update/DocumentBuilder.java |
78 |
Deeply nested if..then statements are hard to read |
| 1071 |
org/apache/solr/update/DocumentBuilder.java |
143 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 1072 |
org/apache/solr/update/DocumentBuilder.java |
148 |
Document empty method |
| 1073 |
org/apache/solr/update/DocumentBuilder.java |
159 |
Avoid if (x != y) ..; else ..; |
| 1074 |
org/apache/solr/update/DocumentBuilder.java |
187 |
Consider simply returning the value vs storing it in local variable 'ret' |
| 1075 |
org/apache/solr/update/DocumentBuilder.java |
316 |
Avoid if (x != y) ..; else ..; |
| 1076 |
org/apache/solr/update/PeerSync.java |
63 |
Private field 'replicas' could be made final; it is only initialized in the declaration or constructor. |
| 1077 |
org/apache/solr/update/PeerSync.java |
64 |
Private field 'nUpdates' could be made final; it is only initialized in the declaration or constructor. |
| 1078 |
org/apache/solr/update/PeerSync.java |
65 |
Private field 'maxUpdates' could be made final; it is only initialized in the declaration or constructor. |
| 1079 |
org/apache/solr/update/PeerSync.java |
67 |
Private field 'uhandler' could be made final; it is only initialized in the declaration or constructor. |
| 1080 |
org/apache/solr/update/PeerSync.java |
68 |
Private field 'ulog' could be made final; it is only initialized in the declaration or constructor. |
| 1081 |
org/apache/solr/update/PeerSync.java |
69 |
Perhaps 'shardHandlerFactory' could be replaced by a local variable. |
| 1082 |
org/apache/solr/update/PeerSync.java |
69 |
Private field 'shardHandlerFactory' could be made final; it is only initialized in the declaration or constructor. |
| 1083 |
org/apache/solr/update/PeerSync.java |
70 |
Private field 'shardHandler' could be made final; it is only initialized in the declaration or constructor. |
| 1084 |
org/apache/solr/update/PeerSync.java |
72 |
Perhaps 'recentUpdates' could be replaced by a local variable. |
| 1085 |
org/apache/solr/update/PeerSync.java |
75 |
Perhaps 'ourUpdates' could be replaced by a local variable. |
| 1086 |
org/apache/solr/update/PeerSync.java |
194 |
These nested if statements could be combined |
| 1087 |
org/apache/solr/update/PeerSync.java |
215 |
Avoid if (x != y) ..; else ..; |
| 1088 |
org/apache/solr/update/PeerSync.java |
216 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 1089 |
org/apache/solr/update/PeerSync.java |
246 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 1090 |
org/apache/solr/update/PeerSync.java |
275 |
Avoid reassigning parameters such as 'replica' |
| 1091 |
org/apache/solr/update/PeerSync.java |
337 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 1092 |
org/apache/solr/update/PeerSync.java |
535 |
Avoid returning from a finally block |
| 1093 |
org/apache/solr/update/SolrCmdDistributor.java |
74 |
Private field 'response' could be made final; it is only initialized in the declaration or constructor. |
| 1094 |
org/apache/solr/update/SolrCmdDistributor.java |
89 |
Document empty constructor |
| 1095 |
org/apache/solr/update/SolrCmdDistributor.java |
311 |
Avoid if (x != y) ..; else ..; |
| 1096 |
org/apache/solr/update/SolrCmdDistributor.java |
325 |
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. |
| 1097 |
org/apache/solr/update/SolrCmdDistributor.java |
341 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 1098 |
org/apache/solr/update/SolrCmdDistributor.java |
413 |
Private field 'nodeProps' could be made final; it is only initialized in the declaration or constructor. |
| 1099 |
org/apache/solr/update/SolrIndexConfig.java |
93 |
Avoid reassigning parameters such as 'def' |
| 1100 |
org/apache/solr/update/SolrIndexConfig.java |
93 |
Avoid reassigning parameters such as 'prefix' |
| 1101 |
org/apache/solr/update/SolrIndexWriter.java |
55 |
Private field 'directoryFactory' could be made final; it is only initialized in the declaration or constructor. |
| 1102 |
org/apache/solr/update/SolrIndexWriter.java |
73 |
Avoid if (x != y) ..; else ..; |
| 1103 |
org/apache/solr/update/TransactionLog.java |
119 |
Avoid if (x != y) ..; else ..; |
| 1104 |
org/apache/solr/update/TransactionLog.java |
241 |
Avoid reassigning parameters such as 'fis' |
| 1105 |
org/apache/solr/update/TransactionLog.java |
243 |
Avoid if (x != y) ..; else ..; |
| 1106 |
org/apache/solr/update/TransactionLog.java |
533 |
Private field 'codec' could be made final; it is only initialized in the declaration or constructor. |
| 1107 |
org/apache/solr/update/TransactionLog.java |
597 |
Private field 'codec' could be made final; it is only initialized in the declaration or constructor. |
| 1108 |
org/apache/solr/update/TransactionLog.java |
647 |
Avoid empty if statements |
| 1109 |
org/apache/solr/update/TransactionLog.java |
694 |
Private field 'ch' could be made final; it is only initialized in the declaration or constructor. |
| 1110 |
org/apache/solr/update/TransactionLog.java |
707 |
Consider simply returning the value vs storing it in local variable 'ret' |
| 1111 |
org/apache/solr/update/UpdateHandler.java |
121 |
Avoid if (x != y) ..; else ..; |
| 1112 |
org/apache/solr/update/UpdateLog.java |
87 |
Private field 'logs' could be made final; it is only initialized in the declaration or constructor. |
| 1113 |
org/apache/solr/update/UpdateLog.java |
88 |
Private field 'newestLogsOnStartup' could be made final; it is only initialized in the declaration or constructor. |
| 1114 |
org/apache/solr/update/UpdateLog.java |
97 |
This final field could be made static |
| 1115 |
org/apache/solr/update/UpdateLog.java |
98 |
This final field could be made static |
| 1116 |
org/apache/solr/update/UpdateLog.java |
100 |
Private field 'oldDeletes' could be made final; it is only initialized in the declaration or constructor. |
| 1117 |
org/apache/solr/update/UpdateLog.java |
115 |
Private field 'defaultSyncLevel' could be made final; it is only initialized in the declaration or constructor. |
| 1118 |
org/apache/solr/update/UpdateLog.java |
223 |
Use equals() to compare object references. |
| 1119 |
org/apache/solr/update/UpdateLog.java |
553 |
Avoid reassigning parameters such as 'syncLevel' |
| 1120 |
org/apache/solr/update/UpdateLog.java |
656 |
Use equals() to compare object references. |
| 1121 |
org/apache/solr/update/UpdateLog.java |
656 |
Use equals() to compare object references. |
| 1122 |
org/apache/solr/update/UpdateLog.java |
690 |
Avoid reassigning parameters such as 'n' |
| 1123 |
org/apache/solr/update/UpdateLog.java |
937 |
Private field 'loglog' could be made final; it is only initialized in the declaration or constructor. |
| 1124 |
org/apache/solr/update/UpdateLog.java |
1014 |
Avoid if (x != y) ..; else ..; |
| 1125 |
org/apache/solr/update/UpdateLog.java |
1023 |
Avoid empty if statements |
| 1126 |
org/apache/solr/update/VersionInfo.java |
39 |
Private field 'core' could be made final; it is only initialized in the declaration or constructor. |
| 1127 |
org/apache/solr/update/VersionInfo.java |
40 |
Private field 'updateHandler' could be made final; it is only initialized in the declaration or constructor. |
| 1128 |
org/apache/solr/update/VersionInfo.java |
42 |
Private field 'versionField' could be made final; it is only initialized in the declaration or constructor. |
| 1129 |
org/apache/solr/update/VersionInfo.java |
43 |
Perhaps 'idField' could be replaced by a local variable. |
| 1130 |
org/apache/solr/update/VersionInfo.java |
43 |
Private field 'idField' could be made final; it is only initialized in the declaration or constructor. |
| 1131 |
org/apache/solr/update/VersionInfo.java |
164 |
Consider simply returning the value vs storing it in local variable 'ver' |
| 1132 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
81 |
Perhaps 'updateHandler' could be replaced by a local variable. |
| 1133 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
85 |
Private field 'returnVersions' could be made final; it is only initialized in the declaration or constructor. |
| 1134 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
96 |
Private field 'zkEnabled' could be made final; it is only initialized in the declaration or constructor. |
| 1135 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
98 |
Private field 'cloudDesc' could be made final; it is only initialized in the declaration or constructor. |
| 1136 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
100 |
Private field 'zkController' could be made final; it is only initialized in the declaration or constructor. |
| 1137 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
310 |
These nested if statements could be combined |
| 1138 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
391 |
Avoid if (x != y) ..; else ..; |
| 1139 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
515 |
Avoid if (x != y) ..; else ..; |
| 1140 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
844 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 1141 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
867 |
Private field 'zkStateReader' could be made final; it is only initialized in the declaration or constructor. |
| 1142 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
868 |
Private field 'collection' could be made final; it is only initialized in the declaration or constructor. |
| 1143 |
org/apache/solr/update/processor/DistributedUpdateProcessor.java |
869 |
Private field 'shardId' could be made final; it is only initialized in the declaration or constructor. |
| 1144 |
org/apache/solr/update/processor/DistributedUpdateProcessorFactory.java |
29 |
Document empty method |
| 1145 |
org/apache/solr/update/processor/FieldMutatingUpdateProcessor.java |
163 |
Use equals() to compare object references. |
| 1146 |
org/apache/solr/update/processor/FieldMutatingUpdateProcessor.java |
167 |
Use equals() to compare object references. |
| 1147 |
org/apache/solr/update/processor/FieldMutatingUpdateProcessor.java |
171 |
Use equals() to compare object references. |
| 1148 |
org/apache/solr/update/processor/FieldMutatingUpdateProcessor.java |
222 |
Avoid instantiation through private constructors from outside of the constructor's class. |
| 1149 |
org/apache/solr/update/processor/FieldMutatingUpdateProcessorFactory.java |
119 |
Private field 'exclusions' could be made final; it is only initialized in the declaration or constructor. |
| 1150 |
org/apache/solr/update/processor/FieldValueMutatingUpdateProcessor.java |
65 |
Use equals() to compare object references. |
| 1151 |
org/apache/solr/update/processor/Lookup3Signature.java |
25 |
Document empty constructor |
| 1152 |
org/apache/solr/update/processor/MD5Signature.java |
38 |
Private field 'digester' could be made final; it is only initialized in the declaration or constructor. |
| 1153 |
org/apache/solr/update/processor/RunUpdateProcessorFactory.java |
43 |
Perhaps 'req' could be replaced by a local variable. |
| 1154 |
org/apache/solr/update/processor/Signature.java |
22 |
An empty method in an abstract class should be abstract instead |
| 1155 |
org/apache/solr/update/processor/Signature.java |
22 |
Document empty method |
| 1156 |
org/apache/solr/update/processor/SignatureUpdateProcessorFactory.java |
136 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() |
| 1157 |
org/apache/solr/update/processor/TextProfileSignature.java |
62 |
Overriding method merely calls super |
| 1158 |
org/apache/solr/update/processor/TextProfileSignature.java |
82 |
Deeply nested if..then statements are hard to read |
| 1159 |
org/apache/solr/update/processor/TextProfileSignature.java |
87 |
Deeply nested if..then statements are hard to read |
| 1160 |
org/apache/solr/update/processor/URLClassifyProcessor.java |
91 |
Overridable method 'setEnabled' called during object construction |
| 1161 |
org/apache/solr/update/processor/URLClassifyProcessor.java |
119 |
Deeply nested if..then statements are hard to read |
| 1162 |
org/apache/solr/update/processor/URLClassifyProcessor.java |
122 |
Deeply nested if..then statements are hard to read |
| 1163 |
org/apache/solr/update/processor/URLClassifyProcessor.java |
196 |
Avoid if (x != y) ..; else ..; |
| 1164 |
org/apache/solr/update/processor/UniqFieldsUpdateProcessorFactory.java |
92 |
Deeply nested if..then statements are hard to read |
| 1165 |
org/apache/solr/update/processor/UpdateRequestProcessor.java |
43 |
This abstract class does not have any abstract methods |
| 1166 |
org/apache/solr/update/processor/UpdateRequestProcessorFactory.java |
37 |
An empty method in an abstract class should be abstract instead |
| 1167 |
org/apache/solr/util/BCDUtils.java |
24 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 1168 |
org/apache/solr/util/BCDUtils.java |
58 |
Avoid reassigning parameters such as 'end' |
| 1169 |
org/apache/solr/util/BCDUtils.java |
58 |
Avoid reassigning parameters such as 'end' |
| 1170 |
org/apache/solr/util/BCDUtils.java |
86 |
Avoid empty if statements |
| 1171 |
org/apache/solr/util/BCDUtils.java |
185 |
Avoid reassigning parameters such as 'end' |
| 1172 |
org/apache/solr/util/BCDUtils.java |
185 |
Avoid reassigning parameters such as 'end' |
| 1173 |
org/apache/solr/util/BCDUtils.java |
185 |
Avoid reassigning parameters such as 'end' |
| 1174 |
org/apache/solr/util/BCDUtils.java |
185 |
Avoid reassigning parameters such as 'end' |
| 1175 |
org/apache/solr/util/BCDUtils.java |
185 |
Avoid reassigning parameters such as 'start' |
| 1176 |
org/apache/solr/util/BCDUtils.java |
265 |
Avoid reassigning parameters such as 'start' |
| 1177 |
org/apache/solr/util/BCDUtils.java |
265 |
Avoid reassigning parameters such as 'start' |
| 1178 |
org/apache/solr/util/BCDUtils.java |
309 |
Avoid reassigning parameters such as 'end' |
| 1179 |
org/apache/solr/util/BCDUtils.java |
309 |
Avoid reassigning parameters such as 'end' |
| 1180 |
org/apache/solr/util/BCDUtils.java |
309 |
Avoid reassigning parameters such as 'end' |
| 1181 |
org/apache/solr/util/BCDUtils.java |
309 |
Avoid reassigning parameters such as 'end' |
| 1182 |
org/apache/solr/util/BCDUtils.java |
309 |
Avoid reassigning parameters such as 'end' |
| 1183 |
org/apache/solr/util/BCDUtils.java |
309 |
Avoid reassigning parameters such as 'end' |
| 1184 |
org/apache/solr/util/BCDUtils.java |
309 |
Avoid reassigning parameters such as 'start' |
| 1185 |
org/apache/solr/util/BCDUtils.java |
395 |
Avoid reassigning parameters such as 'start' |
| 1186 |
org/apache/solr/util/BCDUtils.java |
395 |
Avoid reassigning parameters such as 'start' |
| 1187 |
org/apache/solr/util/BCDUtils.java |
395 |
Avoid reassigning parameters such as 'start' |
| 1188 |
org/apache/solr/util/BoundedTreeSet.java |
32 |
Overridable method 'setMaxSize' called during object construction |
| 1189 |
org/apache/solr/util/BoundedTreeSet.java |
36 |
Overridable method 'setMaxSize' called during object construction |
| 1190 |
org/apache/solr/util/BoundedTreeSet.java |
40 |
Overridable method 'setMaxSize' called during object construction |
| 1191 |
org/apache/solr/util/BoundedTreeSet.java |
44 |
Overridable method 'setMaxSize' called during object construction |
| 1192 |
org/apache/solr/util/ConcurrentLFUCache.java |
53 |
Perhaps 'acceptableWaterMark' could be replaced by a local variable. |
| 1193 |
org/apache/solr/util/ConcurrentLFUCache.java |
143 |
Avoid if (x != y) ..; else ..; |
| 1194 |
org/apache/solr/util/ConcurrentLFUCache.java |
379 |
Private field 'evictionCounter' could be made final; it is only initialized in the declaration or constructor. |
| 1195 |
org/apache/solr/util/ConcurrentLFUCache.java |
424 |
Private field 'cache' could be made final; it is only initialized in the declaration or constructor. |
| 1196 |
org/apache/solr/util/ConcurrentLRUCache.java |
141 |
Avoid if (x != y) ..; else ..; |
| 1197 |
org/apache/solr/util/ConcurrentLRUCache.java |
539 |
Private field 'evictionCounter' could be made final; it is only initialized in the declaration or constructor. |
| 1198 |
org/apache/solr/util/ConcurrentLRUCache.java |
584 |
Private field 'cache' could be made final; it is only initialized in the declaration or constructor. |
| 1199 |
org/apache/solr/util/DOMUtil.java |
32 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 1200 |
org/apache/solr/util/DOMUtil.java |
77 |
Consider simply returning the value vs storing it in local variable 'val' |
| 1201 |
org/apache/solr/util/DOMUtil.java |
163 |
Avoid if (x != y) ..; else ..; |
| 1202 |
org/apache/solr/util/DOMUtil.java |
190 |
A switch statement does not contain a break |
| 1203 |
org/apache/solr/util/DOMUtil.java |
190 |
Switch statements should have a default label |
| 1204 |
org/apache/solr/util/DOMUtil.java |
363 |
Avoid if (x != y) ..; else ..; |
| 1205 |
org/apache/solr/util/DateMathParser.java |
191 |
Private field 'zone' could be made final; it is only initialized in the declaration or constructor. |
| 1206 |
org/apache/solr/util/DateMathParser.java |
192 |
Private field 'loc' could be made final; it is only initialized in the declaration or constructor. |
| 1207 |
org/apache/solr/util/DateMathParser.java |
258 |
New exception is thrown in catch block, original stack trace may be lost |
| 1208 |
org/apache/solr/util/DateMathParser.java |
272 |
New exception is thrown in catch block, original stack trace may be lost |
| 1209 |
org/apache/solr/util/DateMathParser.java |
282 |
New exception is thrown in catch block, original stack trace may be lost |
| 1210 |
org/apache/solr/util/DefaultSolrThreadFactory.java |
31 |
Avoid if (x != y) ..; else ..; |
| 1211 |
org/apache/solr/util/DefaultSolrThreadFactory.java |
32 |
Avoid using java.lang.ThreadGroup; it is not thread safe |
| 1212 |
org/apache/solr/util/FileUtils.java |
26 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 1213 |
org/apache/solr/util/FileUtils.java |
51 |
Avoid empty catch blocks |
| 1214 |
org/apache/solr/util/FileUtils.java |
52 |
Avoid empty catch blocks |
| 1215 |
org/apache/solr/util/LongPriorityQueue.java |
36 |
Overridable method 'initialize' called during object construction |
| 1216 |
org/apache/solr/util/LongPriorityQueue.java |
188 |
Avoid reassigning parameters such as 'n' |
| 1217 |
org/apache/solr/util/NumberUtils.java |
27 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 1218 |
org/apache/solr/util/NumberUtils.java |
152 |
Avoid reassigning parameters such as 'offset' |
| 1219 |
org/apache/solr/util/NumberUtils.java |
152 |
Avoid reassigning parameters such as 'offset' |
| 1220 |
org/apache/solr/util/NumberUtils.java |
152 |
Avoid reassigning parameters such as 'offset' |
| 1221 |
org/apache/solr/util/NumberUtils.java |
152 |
Avoid reassigning parameters such as 'val' |
| 1222 |
org/apache/solr/util/NumberUtils.java |
160 |
Avoid reassigning parameters such as 'offset' |
| 1223 |
org/apache/solr/util/NumberUtils.java |
160 |
Avoid reassigning parameters such as 'offset' |
| 1224 |
org/apache/solr/util/NumberUtils.java |
160 |
Avoid reassigning parameters such as 'offset' |
| 1225 |
org/apache/solr/util/NumberUtils.java |
177 |
Avoid reassigning parameters such as 'offset' |
| 1226 |
org/apache/solr/util/NumberUtils.java |
177 |
Avoid reassigning parameters such as 'offset' |
| 1227 |
org/apache/solr/util/NumberUtils.java |
177 |
Avoid reassigning parameters such as 'offset' |
| 1228 |
org/apache/solr/util/NumberUtils.java |
177 |
Avoid reassigning parameters such as 'offset' |
| 1229 |
org/apache/solr/util/NumberUtils.java |
177 |
Avoid reassigning parameters such as 'val' |
| 1230 |
org/apache/solr/util/NumberUtils.java |
187 |
Avoid reassigning parameters such as 'offset' |
| 1231 |
org/apache/solr/util/NumberUtils.java |
187 |
Avoid reassigning parameters such as 'offset' |
| 1232 |
org/apache/solr/util/NumberUtils.java |
187 |
Avoid reassigning parameters such as 'offset' |
| 1233 |
org/apache/solr/util/NumberUtils.java |
187 |
Avoid reassigning parameters such as 'offset' |
| 1234 |
org/apache/solr/util/PrimUtils.java |
20 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 1235 |
org/apache/solr/util/RTimer.java |
51 |
Overridable method 'now' called during object construction |
| 1236 |
org/apache/solr/util/SimplePostTool.java |
313 |
Avoid empty catch blocks |
| 1237 |
org/apache/solr/util/SimplePostTool.java |
328 |
Avoid empty catch blocks |
| 1238 |
org/apache/solr/util/SolrPluginUtils.java |
66 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 1239 |
org/apache/solr/util/SolrPluginUtils.java |
160 |
Deeply nested if..then statements are hard to read |
| 1240 |
org/apache/solr/util/SolrPluginUtils.java |
374 |
Consider simply returning the value vs storing it in local variable 'results' |
| 1241 |
org/apache/solr/util/SolrPluginUtils.java |
376 |
New exception is thrown in catch block, original stack trace may be lost |
| 1242 |
org/apache/solr/util/SolrPluginUtils.java |
475 |
Avoid reassigning parameters such as 'spec' |
| 1243 |
org/apache/solr/util/SolrPluginUtils.java |
475 |
Avoid reassigning parameters such as 'spec' |
| 1244 |
org/apache/solr/util/SolrPluginUtils.java |
475 |
Avoid reassigning parameters such as 'spec' |
| 1245 |
org/apache/solr/util/SuggestMissingFactories.java |
40 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 1246 |
org/apache/solr/util/SuggestMissingFactories.java |
124 |
Private field 'jarFiles' could be made final; it is only initialized in the declaration or constructor. |
| 1247 |
org/apache/solr/util/SuggestMissingFactories.java |
125 |
Private field 'cl' could be made final; it is only initialized in the declaration or constructor. |
| 1248 |
org/apache/solr/util/SuggestMissingFactories.java |
206 |
Avoid empty catch blocks |
| 1249 |
org/apache/solr/util/SystemIdResolver.java |
159 |
Avoid reassigning parameters such as 'name' |
| 1250 |
org/apache/solr/util/SystemIdResolver.java |
159 |
Avoid reassigning parameters such as 'name' |
| 1251 |
org/apache/solr/util/VersionedFile.java |
38 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 1252 |
org/apache/solr/util/VersionedFile.java |
72 |
Avoid empty catch blocks |
| 1253 |
org/apache/solr/util/VersionedFile.java |
91 |
Use block level rather than method level synchronization |
| 1254 |
org/apache/solr/util/plugin/AbstractPluginLoader.java |
142 |
Avoid if (x != y) ..; else ..; |
| 1255 |
org/apache/solr/util/xslt/TransformerProvider.java |
45 |
A class which only has private constructors should be final |
| 1256 |
org/apache/solr/util/xslt/TransformerProvider.java |
69 |
Use block level rather than method level synchronization |
| 1257 |
org/apache/solr/util/xslt/TransformerProvider.java |
88 |
New exception is thrown in catch block, original stack trace may be lost |
| 1258 |
org/apache/solr/util/xslt/TransformerProvider.java |
119 |
New exception is thrown in catch block, original stack trace may be lost |