[LUCENE-3782] An incomplete fix for the NPE bugs in Directory.java

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Abandoned
• Affects Version/s: 3.0
• Component/s: core/store
• Labels: incomplete_fix missing_fixes
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Guangtai Liang
• Created: 14/Feb/12 13:10
• Updated: 28/Aug/22 13:08
• Resolved: 09/Jun/16 14:27

Description

The fix revision 499089 was aimed to remove an NPE bug (LUCENE-773) on the value of "lockFactory " in the method "clearLock" of the file "/lucene/java/trunk/src/java/org/apache/lucene/store/Directory.java" , but it is incomplete.

Since the value "lockFactory " could be null during the runtime execution, its value should also be null-checked before being dereferenced in other methods.

The buggy code locations the same fix needs to be applied at are as bellows:

Line 106 of the methods "doc()" , and "freq":

public Lock makeLock(String name)

{ [Line 106] return lockFactory.makeLock(name); }