[LUCENE-3712] Remove unused (and untested) methods from ReaderUtil that are also veeeeery ineffective

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5
• Fix Version/s: 3.6, 4.0-ALPHA
• Component/s: core/other
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 21/Jan/12 14:11
• Updated: 28/Aug/22 13:05
• Resolved: 24/Jan/12 12:57

Description

ReaderUtil contains two methods that are nowhere used and not even tested. Additionally those are implemented with useless List->array copying; ineffective docStart calculation for a binary search later instead directly returning the reader while scanning – and I am not sure if they really work as expected. As ReaderUtil is @lucene.internal we should remove them in 3.x and trunk, alternatively the useless array copy / docStarts handling should be removed and tests added:

public static IndexReader subReader(int doc, IndexReader reader)
public static IndexReader subReader(IndexReader reader, int subIndex)