Lucene - Core
  1. Lucene - Core
  2. LUCENE-3712

Remove unused (and untested) methods from ReaderUtil that are also veeeeery ineffective

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: core/other
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      ReaderUtil contains two methods that are nowhere used and not even tested. Additionally those are implemented with useless List->array copying; ineffective docStart calculation for a binary search later instead directly returning the reader while scanning – and I am not sure if they really work as expected. As ReaderUtil is @lucene.internal we should remove them in 3.x and trunk, alternatively the useless array copy / docStarts handling should be removed and tests added:

      public static IndexReader subReader(int doc, IndexReader reader)
      public static IndexReader subReader(IndexReader reader, int subIndex)
      
      1. LUCENE-3712.patch
        2 kB
        Uwe Schindler

        Activity

        Hide
        Robert Muir added a comment -

        +1, untested and unused, nuke it.

        Show
        Robert Muir added a comment - +1, untested and unused, nuke it.
        Hide
        Uwe Schindler added a comment -

        Committed trunk revision: 1235228
        Committed 3.x revision: 1235234

        Show
        Uwe Schindler added a comment - Committed trunk revision: 1235228 Committed 3.x revision: 1235234

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development