Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-3712

Remove unused (and untested) methods from ReaderUtil that are also veeeeery ineffective

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.5
    • 3.6, 4.0-ALPHA
    • core/other
    • None
    • New

    Description

      ReaderUtil contains two methods that are nowhere used and not even tested. Additionally those are implemented with useless List->array copying; ineffective docStart calculation for a binary search later instead directly returning the reader while scanning – and I am not sure if they really work as expected. As ReaderUtil is @lucene.internal we should remove them in 3.x and trunk, alternatively the useless array copy / docStarts handling should be removed and tests added:

      public static IndexReader subReader(int doc, IndexReader reader)
      public static IndexReader subReader(IndexReader reader, int subIndex)
      

      Attachments

        1. LUCENE-3712.patch
          2 kB
          Uwe Schindler

        Activity

          People

            uschindler Uwe Schindler
            uschindler Uwe Schindler
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: