Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0-ALPHA
    • modules/analysis
    • None
    • New

    Description

      In LUCENE-2309 it was suggested that we should make Analyzer reusability compulsory. ReusableAnalyzerBase is a fantastic way to drive reusability so lets move it into core (so that we can then change all impls over to using it).

      Attachments

        1. LUCENE-3376.patch
          64 kB
          Chris Male
        2. LUCENE-3376.patch
          64 kB
          Chris Male

        Activity

          rcmuir Robert Muir added a comment -

          I agree: we should push this logic into analyzer.

          the first step to doing this is sort of a nightmare, i think that is to remove tokenStream() and only support reusableTokenStream() in all the tests etc... it seems easy but its a ton of work actually.

          rcmuir Robert Muir added a comment - I agree: we should push this logic into analyzer. the first step to doing this is sort of a nightmare, i think that is to remove tokenStream() and only support reusableTokenStream() in all the tests etc... it seems easy but its a ton of work actually.
          cmale Chris Male added a comment -

          My plan was to move the class ReusableAnalyzerBase into core and then port all Analyzers over to using it. Then I would drop tokenStream() and rename ReusableAnalyzerBase to just Analyzer.

          Manageable?

          cmale Chris Male added a comment - My plan was to move the class ReusableAnalyzerBase into core and then port all Analyzers over to using it. Then I would drop tokenStream() and rename ReusableAnalyzerBase to just Analyzer. Manageable?
          cmale Chris Male added a comment -

          Patch which moves ReusableAnalyzerBase into core and updates all references.

          Command:

          svn move modules/analysis/common/src/java/org/apache/lucene/analysis/util/ReusableAnalyzerBase.java lucene/src/java/org/apache/lucene/analysis/ReusableAnalyzerBase.java
          
          cmale Chris Male added a comment - Patch which moves ReusableAnalyzerBase into core and updates all references. Command: svn move modules/analysis/common/src/java/org/apache/lucene/analysis/util/ReusableAnalyzerBase.java lucene/src/java/org/apache/lucene/analysis/ReusableAnalyzerBase.java
          cmale Chris Male added a comment -

          Updated patch including CHANGES.txt entry. Will commit tomorrow

          cmale Chris Male added a comment - Updated patch including CHANGES.txt entry. Will commit tomorrow
          cmale Chris Male added a comment -

          Committed revision 1160117.

          cmale Chris Male added a comment - Committed revision 1160117.
          tomoko Tomoko Uchida added a comment -

          This issue was moved to GitHub issue: #4449.

          tomoko Tomoko Uchida added a comment - This issue was moved to GitHub issue: #4449 .

          People

            cmale Chris Male
            cmale Chris Male
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: