[LUCENE-2769] FilterIndexReader in trunk does not implement getSequentialSubReaders() correctly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0-ALPHA
• Lucene Fields: New, Patch Available
• Assignee: Unassigned
• Reporter: Uwe Schindler
• Created: 19/Nov/10 08:25
• Updated: 28/Aug/22 12:36
• Resolved: 19/Nov/10 18:51

Description

Since LUCENE-2459, getSequentialSubReaders() in FilterIndexReader returns null, so it returns an atomic reader. But If you call then any of the enum methods, it throws Exception because the underlying reader is not atomic.

We should move the null-returning method to SlowMultiReaderWrapper and fix FilterIndexReader's default to return in.getSequentialSubReaders(). Ideally an implementation must of course also wrap the sub-readers.

If we change this we have to look into other Impls like the MultiPassIndexSplitter if we need to add atomicity.

Issue Links

• is broken by: LUCENE-2459 FilterIndexReader doesn't work correctly with post-flex SegmentMerger
• is related to: LUCENE-1720 TimeLimitedIndexReader and associated utility class
• is related to: LUCENE-2771 Remove norms() support from non-atomic IndexReaders
• is related to: LUCENE-2770 Optimize SegmentMerger to work on atomic (Segment)Readers where possible