Uploaded image for project: 'Log4net'
  1. Log4net
  2. LOG4NET-81

LoggerRepositorySkeleton's OnConfigurationChanged method always raises its event with EventArgs.Empty instead of passing through its EventArgs parameter.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 1.2.10
    • 1.2.11
    • None
    • None

    Description

      This code:

      protected virtual void OnConfigurationChanged(EventArgs e)
      {
      if (e == null)

      { e = EventArgs.Empty; }

      LoggerRepositoryConfigurationChangedEventHandler handler = m_configurationChangedEvent;
      if (handler != null)
      { handler(this, EventArgs.Empty); }
      }

      should be changed to match the other event handlers in the class:

      protected virtual void OnConfigurationChanged(EventArgs e)
      {
      if (e == null)
      { e = EventArgs.Empty; }

      LoggerRepositoryConfigurationChangedEventHandler handler = m_configurationChangedEvent;
      if (handler != null)

      { handler(this, e); // do not always pass in EventArgs.Empty }

      }

      Attachments

        Activity

          People

            ron liu ron
            ron liu ron
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: