[LIBCLOUD-323] Make vCloud driver more robust

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.12.3
• Fix Version/s: 0.13.0
• Component/s: Compute
• Assignee: Tomaz Muraus
• Reporter: Michel Samia
• Created: 30/Apr/13 07:51
• Updated: 05/Sep/13 10:24
• Resolved: 04/May/13 05:57

Description

There are several small and easy-to-fix problems in VCloud driver:

1. VCloud_1_5_NodeDriver._validate_vm_memory(): now there is a specialized list of acceptable Virtual memory sizes for vCloud 1.5, but it seems that these values don't work in version 1.5. The old values from vCloud 0.8 work well
2. VCloudNodeDriver.ex_list_nodes(): because node listing has two phases (in first phase we send request for getting URLs of all the VMs and in the second we send one request per VM for getting all info about the VM), there can happen a situation where some VM is deleted between these two phases. Then we want to ignore this VM and we don't want to report any error (=raise an exception). The existing checker of this situation is too generic and can silence any other exception satisfying some other conditions
3. VCloud_1_5_NodeDriver._to_node(): the OS XML element is not required, so when not present, we cannot get its attributes

We have fixed all these three problems in the patch attached below