Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.12.3
    • Fix Version/s: 0.13.0
    • Component/s: Compute
    • Labels:
      None

      Description

      There are several small and easy-to-fix problems in VCloud driver:

      1. VCloud_1_5_NodeDriver._validate_vm_memory(): now there is a specialized list of acceptable Virtual memory sizes for vCloud 1.5, but it seems that these values don't work in version 1.5. The old values from vCloud 0.8 work well
      2. VCloudNodeDriver.ex_list_nodes(): because node listing has two phases (in first phase we send request for getting URLs of all the VMs and in the second we send one request per VM for getting all info about the VM), there can happen a situation where some VM is deleted between these two phases. Then we want to ignore this VM and we don't want to report any error (=raise an exception). The existing checker of this situation is too generic and can silence any other exception satisfying some other conditions
      3. VCloud_1_5_NodeDriver._to_node(): the OS XML element is not required, so when not present, we cannot get its attributes

      We have fixed all these three problems in the patch attached below

      1. LIBCLOUD-323_withTests.patch
        36 kB
        Michel Samia
      2. LIBCLOUD-vcloud_minor_patches.patch
        3 kB
        Michel Samia

        Activity

        Hide
        kami Tomaz Muraus added a comment -

        Looks good so I've merged your patch into trunk and 0.12.x.

        Thanks.

        Show
        kami Tomaz Muraus added a comment - Looks good so I've merged your patch into trunk and 0.12.x. Thanks.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1479041 from Tomaz Muraus
        [ https://svn.apache.org/r1479041 ]

        Various improvements and bug-fixes in the VCloud driver.

        Contributed by Michel Samia, part of LIBCLOUD-323.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1479041 from Tomaz Muraus [ https://svn.apache.org/r1479041 ] Various improvements and bug-fixes in the VCloud driver. Contributed by Michel Samia, part of LIBCLOUD-323 .
        Hide
        msamia Michel Samia added a comment -

        New patch with tests for problems 2 and 3. Problem 1 cannot be tested without connecting to real vCloud.

        Show
        msamia Michel Samia added a comment - New patch with tests for problems 2 and 3. Problem 1 cannot be tested without connecting to real vCloud.
        Hide
        kami Tomaz Muraus added a comment -

        Thanks.

        The patch looks good, but I would really like to see some tests for those changes. Let us know if you need help with writing them.

        Show
        kami Tomaz Muraus added a comment - Thanks. The patch looks good, but I would really like to see some tests for those changes. Let us know if you need help with writing them.
        Hide
        msamia Michel Samia added a comment -

        Patch fixing this issue

        Show
        msamia Michel Samia added a comment - Patch fixing this issue

          People

          • Assignee:
            kami Tomaz Muraus
            Reporter:
            msamia Michel Samia
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development