Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None

      Description

      Currently there is no way to check contents of the feature. It's also hard to determine what dependencies feature has.

      First command - describes feature using Feature instance. Command by default displays info about configuration (-c), dependencies (-d) and bundles (-b option) in feature.

      karaf@root> features:desc payment-service
      Description of payment-service 1.0.0.SNAPSHOT feature
      ----------------------------------------------------------------
      Feature has no configuration.
      Feature dependens on:
        datasource 0.0.0
        dataaccess 0.0.0
        activemq-camel 0.0.0
        camel-jetty 0.0.0
        contract 0.0.0
      Feature contains followed bundles:
        mvn:org.code-house.esb.payment/engine/1.0.0.SNAPSHOT
        mvn:org.code-house.esb.payment/binding/1.0.0.SNAPSHOT
        mvn:org.code-house.esb.payment/persistence/1.0.0.SNAPSHOT
      

      Second command displays features tree. If user will pass -b parameter feature bundles will be attached to tree.

      karaf@root> features:tree payment-service
       payment-service 1.0.0.SNAPSHOT
          datasource 0.0.0
             activemq 0.0.0 *
             postgresql 8.3
             spring 2.5.6.SEC01
             commons-dbcp 0.0.0
          dataaccess 1.0.0.SNAPSHOT
             domain 1.0.0.SNAPSHOT
                persistence-api 1.0.0
             hibernate 0.0.0
                persistence-api 1.0.0
          activemq-camel 5.3.0-fuse-01-00
          camel-jetty 0.0.0 *
          contract 1.0.0.SNAPSHOT
      Tree contains 2 unresolved dependencies
       * means that node declares dependency but the dependant feature is not available.
      
      karaf@root> features:tree domain
       domain 1.0.0.SNAPSHOT
          persistence-api 1.0.0
      
      karaf@root> features:tree -b domain
       domain 1.0.0.SNAPSHOT
       + mvn:org.code-house/domain/1.0.0.SNAPSHOT
       + mvn:org.code-house.security/domain/1.0.0.SNAPSHOT
       \ mvn:org.code-house.shippingstock/domain/1.0.0.SNAPSHOT
          persistence-api 1.0.0
          \ mvn:javax.persistence/com.springsource.javax.persistence/1.0.0
      
      1. desc_tree-commands.patch
        21 kB
        Łukasz Dywicki
      2. info-command.patch
        19 kB
        Łukasz Dywicki

        Issue Links

          Activity

          Hide
          splatch Łukasz Dywicki added a comment -

          Patch to resolve issue.

          Show
          splatch Łukasz Dywicki added a comment - Patch to resolve issue.
          Hide
          ccustine Chris Custine added a comment -

          I'm liking this patch a lot, but I am very tempted to combine the 2 commands into a single "features:info" command (your desc command) and make the tree command into option like "features:info -t webconsole" or something like that. We are starting to see the beginnings of command bloat in the console so I am trying to keep things as concise but flexible as possible. WDYT?

          Show
          ccustine Chris Custine added a comment - I'm liking this patch a lot, but I am very tempted to combine the 2 commands into a single "features:info" command (your desc command) and make the tree command into option like "features:info -t webconsole" or something like that. We are starting to see the beginnings of command bloat in the console so I am trying to keep things as concise but flexible as possible. WDYT?
          Hide
          splatch Łukasz Dywicki added a comment -

          Chris:
          As I said you on IRC - I agree with you - one command will be better than two separated.

          Regards,
          Luke

          Show
          splatch Łukasz Dywicki added a comment - Chris: As I said you on IRC - I agree with you - one command will be better than two separated. Regards, Luke
          Hide
          gnt Guillaume Nodet added a comment -

          Do you think you could rework this patch to combine both commands into a single one ?

          Show
          gnt Guillaume Nodet added a comment - Do you think you could rework this patch to combine both commands into a single one ?
          Hide
          splatch Łukasz Dywicki added a comment -

          Patch with single command features:info -t -c -b -d name [version] and small refactor in completers.

          Show
          splatch Łukasz Dywicki added a comment - Patch with single command features:info -t -c -b -d name [version] and small refactor in completers.
          Hide
          gnt Guillaume Nodet added a comment -

          URL: http://svn.apache.org/viewvc?rev=956491&view=rev
          Log:
          FELIX-2141: Add features:info command

          Added:
          felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/InfoFeatureCommand.java
          felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/completers/AllFeatureCompleter.java
          felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/completers/FeatureCompleterSupport.java

          • copied, changed from r956295, felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/completers/AvailableFeatureCompleter.java
            Modified:
            felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/completers/AvailableFeatureCompleter.java
            felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/completers/InstalledFeatureCompleter.java
            felix/trunk/karaf/features/command/src/main/resources/OSGI-INF/blueprint/features-command.xml
            felix/trunk/karaf/features/core/src/main/java/org/apache/felix/karaf/features/FeaturesService.java
            felix/trunk/karaf/features/core/src/main/java/org/apache/felix/karaf/features/internal/FeaturesServiceImpl.java
          Show
          gnt Guillaume Nodet added a comment - URL: http://svn.apache.org/viewvc?rev=956491&view=rev Log: FELIX-2141 : Add features:info command Added: felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/InfoFeatureCommand.java felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/completers/AllFeatureCompleter.java felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/completers/FeatureCompleterSupport.java copied, changed from r956295, felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/completers/AvailableFeatureCompleter.java Modified: felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/completers/AvailableFeatureCompleter.java felix/trunk/karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/completers/InstalledFeatureCompleter.java felix/trunk/karaf/features/command/src/main/resources/OSGI-INF/blueprint/features-command.xml felix/trunk/karaf/features/core/src/main/java/org/apache/felix/karaf/features/FeaturesService.java felix/trunk/karaf/features/core/src/main/java/org/apache/felix/karaf/features/internal/FeaturesServiceImpl.java

            People

            • Assignee:
              gnt Guillaume Nodet
              Reporter:
              splatch Łukasz Dywicki
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development