[KARAF-4593] karaf script contains error in $JAVA variable

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 4.0.4
• Component/s: karaf

Environment

Windows, Linux

• Assignee: Guillaume Nodet
• Reporter: Daniel Peon
• Created: 23/Jun/16 13:59
• Updated: 15/Sep/18 16:35
• Resolved: 20/Jul/16 15:56

Description

Hi,

I found a problem executing any script which launches karaf script.

The variable $JAVA is used without being quoted, so when Java is installed in a folder with spaces (so common in Windows), the script will complain with the message:

<path_to_script>/karaf: line 239: [: : integer expression expected

This line corresponds to this part of the code:

>>> if [ "$VERSION" -lt "80" ]; then

This $VERSION variable was set 2 lines before as follows:

>>>VERSION=`$JAVA -version 2>&1 | egrep '"([0-9].[0-9]\..[0-9])."' | awk '

{print substr($3,2,length($3)-2)}

' | awk '

{print substr($1, 3, 3)}

' | sed -e 's;\.;;g'`

That variable $JAVA should be quoted so that it allows spaces in the path to Java installation.

Kind regards.

Issue Links

• Is contained by: KARAF-4566 "karaf" script invokes /bin/sh but requires /bin/bash functions