[KARAF-4566] "karaf" script invokes /bin/sh but requires /bin/bash functions

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.6
• Fix Version/s: 4.1.0, 3.0.7, 4.0.6
• Component/s: karaf

Environment

Solaris (SunOS solaris11.3 5.11 11.3 i86pc i386 i86pc)

• Assignee: Jean-Baptiste Onofré
• Reporter: Alexis de Talhouët
• Created: 08/Jun/16 21:41
• Updated: 14/Sep/18 08:35
• Resolved: 09/Jun/16 13:18

Description

The bin/karaf script uses the "local" command which is a shell builtin of bash and similar shells, but is not required for POSIX-compliance in sh. When I attempt to run karaf on a Solaris system, I see the following output:

root@solaris:/opendaylight/bin# ./karaf
./karaf[172]: local: not found [No such file or directory]
./karaf[182]: local: not found [No such file or directory]
./karaf[183]: local: not found [No such file or directory]

Lines 172, 182 and 183 invoke "local" to make local variables to the function. According to "man bash", this is a shell builtin. However, bin/karaf is invoked as:

#!/bin/sh

On most flavors of linux, this resolves to bash or dash which probably runs in a restricted environment after checking to see that its $0 is sh. But on Solaris's /bin/sh is actually ksh93 for backwards compatibility.

Since "local" is not part of a POSIX-compliant /bin/sh, depending on it in a script that is invoked with /bin/sh is a bug.

(this explaination is borrowed from https://issues.apache.org/jira/browse/MNG-5852)

Issue Links

• contains: KARAF-4593 karaf script contains error in $JAVA variable
• links to: GitHub Pull Request #197